February 2024 - Wine-GitLab

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) Feb. 13, 2024

Feb. 13, 2024

Hi, sorry for the delay, but here is another batch of comments. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60987

1 0

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) Feb. 13, 2024

Feb. 13, 2024

On Mon Feb 12 00:49:11 2024 +0000, Conor McCarthy wrote: > The SM6 implementation is now upstream, so these todos are unnecessary > (and were removed in an upstream commit). You'd rather need to remove the `todo(sm<6)` annotations that Conor left behind, once (with your patches) that feature is available in the HLSL compiler. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60986

1 0

Re: [PATCH v10 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Giovanni Mascellani (＠giomasce) Feb. 13, 2024

Feb. 13, 2024

On Sun Feb 11 16:37:35 2024 +0000, Petrichor Park wrote: > What would make `vkd3d_string_buffer_printf` better? It looks like > `hlsl_sprintf_alloc` just forwards to that inside and I don't see what I > would be writing that would be better. Because you can call `vkd3d_string_buffer_printf()` repeatedly on the same buffer, so you don't need a final `hlsl_sprintf_alloc()` just to stitch the two strings together. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364#note_60985

1 0

[PATCH v7 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Feb. 13, 2024

Feb. 13, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v7: tests: Remove [require] directives for tests that use int and bool uniforms. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

3 5

Re: [PATCH v12 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) Feb. 13, 2024

Feb. 13, 2024

Huw Davies (@huw) commented about include/netioapi.h: > IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIpNetTable2(ADDRESS_FAMILY,MIB_IPNET_TABLE2**); > IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetUnicastIpAddressEntry(MIB_UNICASTIPADDRESS_ROW*); > IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetUnicastIpAddressTable(ADDRESS_FAMILY,MIB_UNICASTIPADDRESS_TABLE**); > +IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY,MIB_ANYCASTIPADDRESS_TABLE**); These are sorted alphabetically. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_60979

1 0

[PATCH 0/1] MR4853: iphlpapi: Implement GetRTTAndHopCount().
by Marc-Aurel Zent (＠mzent) Feb. 13, 2024

Feb. 13, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4853

3 5

Re: [PATCH v2 0/6] MR5072: sapi: Implement some methods for ISpeechObjectToken(s). - approved
by Huw Davies (＠huw) Feb. 13, 2024

Feb. 13, 2024

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5072

1 0

Re: [PATCH v3 0/5] MR5021: windows.security.authentication.onlineid: Implement IOnlineIdSystemAuthenticatorStatics::get_Default().
by Rémi Bernon Feb. 13, 2024

Feb. 13, 2024

On Tue Feb 13 04:42:21 2024 +0000, Mohamad Al-Jaf wrote: > I don't see how this is different from previous MRs that didn't help > with any application, but were approved anyway like the windows.ui > IUISettings and InputPane stub interfaces. At least in this case there's > a possibility it would help. Well, I'm approving because some application calls it and possibly fails because of it, but in general we prefer to only implement things that applications actually need. Things that are called but not causing any issues can be left unimplemented, there are plenty of useless features in Windows and we don't necessarily want to implement them until they are actually needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5021#note_60970

1 0

Re: [PATCH v3 0/5] MR5021: windows.security.authentication.onlineid: Implement IOnlineIdSystemAuthenticatorStatics::get_Default(). - approved
by Rémi Bernon Feb. 13, 2024

Feb. 13, 2024

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5021

1 0

[PATCH 0/1] MR5073: oleaut32: Handle exponent in VarBstrFromR[48] in non-English locales.
by Daniel Lehman (＠dlehman25) Feb. 13, 2024

Feb. 13, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5073

2 1