February 2024 - Wine-GitLab

Re: [PATCH v7 0/1] MR3368: where: Implement search with default options.
by Alexandre Julliard (＠julliard) Feb. 12, 2024

Feb. 12, 2024

Alexandre Julliard (@julliard) commented about programs/where/main.c: > + if (colon) > + { > + *colon = 0; > + search_paths = pattern; > + pattern = colon + 1; > + } > + else > + { > + DWORD len = GetEnvironmentVariableW(L"PATH", NULL, 0); > + search_paths = malloc(len * sizeof(WCHAR)); > + if (!search_paths) > + { > + ERR("Out of memory\n"); > + return 1; > + } > + GetEnvironmentVariableW(L"PATH", search_paths, len); You want wgetenv(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3368#note_60921

1 0

Re: [PATCH v7 0/1] MR3368: where: Implement search with default options.
by Alexandre Julliard (＠julliard) Feb. 12, 2024

Feb. 12, 2024

Alexandre Julliard (@julliard) commented about programs/where/main.c: > + wcscpy(glob, search_path); > + wcscat(glob, L"\\"); > + wcscat(glob, pattern); > + wcscat(glob, extensions[i]); > + > + handle = FindFirstFileExW(glob, FindExInfoBasic, &match, 0, NULL, 0); > + more = (handle != INVALID_HANDLE_VALUE); > + > + while (more) > + { > + if (PathCombineW(match_path, search_path, match.cFileName)) > + { > + printf("%ls\n", match_path); > + found = TRUE; > + } > + more = FindNextFileW(handle, &match); This is not the correct pattern for FindFirstFile/FindNextFile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3368#note_60920

1 0

[PATCH v3 0/2] MR5064: Handle DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 properly
by Fabian Maurer (＠DarkShadow44) Feb. 12, 2024

Feb. 12, 2024

-- v3: user32/sysparams: Handle DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 in GetAwarenessFromDpiAwarenessContext https://gitlab.winehq.org/wine/wine/-/merge_requests/5064

4 5

[PATCH 0/2] MR5069: wininet: Avoid crash in InternetCreateUrl with scheme unknown.
by Bernhard Übelacker Feb. 12, 2024

Feb. 12, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=33050 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5069

3 6

[PATCH v6 0/6] MR569: tests/shader_runer: Support SRV buffers.
by Francisco Casas (＠fcasas) Feb. 12, 2024

Feb. 12, 2024

This allows to declare SRV buffers in the shader tests using `[buffer srv n]` blocks, and passing them to the different backends. Also, 1/2 includes a missing bit required to parse `Buffer<>` types in the HLSL compiler. This is a step towards supporting StructuredBuffer types in further patches. -- v6: vkd3d-shader/hlsl: Parse Buffer types. tests/shader-runner: Change probe directive syntax on shader_test files. tests/shader-runner: Change resource declaration syntax on shader_test files. tests/shader-runner: Support SRV buffers. tests/shader-runner: Separate resource_type into type and dimension. vkd3d-shader/hlsl: Use positive logic on add_*_method_call() functions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/569

2 7

[PATCH v6 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Feb. 12, 2024

Feb. 12, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v6: tests: Remove [require] directives for tests that use int and bool uniforms. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

2 4

[PATCH 0/1] MR5071: kernel32/tests: Add tests for critical section debug info presence.
by Paul Gofman (＠gofman) Feb. 12, 2024

Feb. 12, 2024

My intention is to make InitializeCriticalSection[Ex] behaviour compatible with modern Windows which doesn't allocate debug info without RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO flag. Before this can be done it requires fixing all the Wine modules currently relying on the old behaviour. That will also make some of those Wine modules (e. g., winhttp) work on modern Windows instead of crashing on debug info access. Besides the latter, the motivation under the planned change is spare heap alloc / free during InitializeCriticalSection / DeleteCriticalSection by default as some games do quite a lot of those. Also avoiding it helps Witch on the Holy Night to survive use after free like it does on Windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5071

2 1

[PATCH v5 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Feb. 12, 2024

Feb. 12, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v5: tests: Remove [require] directives for tests that use int and bool uniforms. tests/shader-runner: Introduce "if" qualifier. tests: Don't ignore SM1 on a non-const-indexing.shader_test test. tests/vkd3d-shader: Set uninitialized uniforms to a value. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

3 5

[PATCH v13 0/7] MR4082: gdiplus: Implement font linking in GdipDrawString.
by Santino Mazza (＠tati1454) Feb. 12, 2024

Feb. 12, 2024

-- v13: gdiplus: Implement font linking for gdiplus. gdiplus/tests: Add interactive test for font linking. https://gitlab.winehq.org/wine/wine/-/merge_requests/4082

3 9

[PATCH v2 0/1] MR5063: ntdll: Remove stale comment from set_async_direct_result() documentation.
by Jinoh Kang (＠iamahuman) Feb. 12, 2024

Feb. 12, 2024

The supplied async handle passed to set_async_direct_result() cannot be NULL. Fixes: 6b16ead607e (ntdll: The async handle passed to set_async_direct_result() cannot be NULL., 2022-09-16) -- v2: ntdll: Remove stale comment from set_async_direct_result() documentation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5063

3 3