February 2024 - Wine-GitLab

[PATCH v18 0/9] MR4982: Load and play MIDI
by Yuxuan Shui (＠yshui) Feb. 8, 2024

Feb. 8, 2024

There are still some issues I need to fix, mainly around timing conversion between MIDI and dmusic. Right now MIDI files seem to be cut off before the end is reached. Please have a look at the general approach in the meantime, I need to know if this is the right way to do this or not. -- v18: dmime: Create a band track for MIDI segments. dmime/test: Add test for getting band track from midi file. dmime: Implement IDirectMusicTrack_Play for MIDI tracks. dmime: Implement getting/setting TempoParam for MIDI tracks. dmime: Parse MIDI tracks. https://gitlab.winehq.org/wine/wine/-/merge_requests/4982

3 19

[PATCH 0/1] MR5052: krnl386: Restore simulated real mode interrupts.
by Alex Henrie (＠alexhenrie) Feb. 8, 2024

Feb. 8, 2024

This partially reverts commit ed6bdb3c51cd4b8c94f9839806321703e7aa9765 and commit 526b245237b9571beebac8a4653e7dd74c62c7de. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56225 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5052

3 2

[PATCH v2 0/1] MR4443: Do not release media session topologies until the media session is shutdown.
by Santino Mazza (＠tati1454) Feb. 8, 2024

Feb. 8, 2024

-- v2: mf: Release topologies when shutting down the session. https://gitlab.winehq.org/wine/wine/-/merge_requests/4443

4 4

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Henri Verbeet (＠hverbeet) Feb. 8, 2024

Feb. 8, 2024

Looking a bit closer, I notice that we don't set VK_DYNAMIC_STATE_DEPTH_BOUNDS. We should add that to dynamic_states[] in d3d12_pipeline_state_get_or_create_pipeline(). Perhaps that's a good argument for waiting for the tests to verify things work as intended though... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60601

1 0

[PATCH 0/1] MR5056: ntdll: Fix DW_OP_abs absolute value warning on labs() for clang.
by Marc-Aurel Zent (＠mzent) Feb. 8, 2024

Feb. 8, 2024

Fixes the following warning on clang-15: ``` dlls/ntdll/unix/dwarf.h:915:45: warning: taking the absolute value of unsigned type 'ULONG_PTR' (aka 'unsigned long') has no effect [-Wabsolute-value] case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^ dlls/ntdll/unix/dwarf.h:915:45: note: remove the call to 'labs' since unsigned values cannot be negative case DW_OP_abs: stack[sp] = labs(stack[sp]); break; ^~~~ ``` Despite what it says the existing code was functioning correctly already though AFAICT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5056

2 1

[PATCH v2 0/4] MR4983: mfreadwrite/tests: Test source reader transforms with video processing attributes.
by Rémi Bernon Feb. 8, 2024

Feb. 8, 2024

-- v2: mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_ADVANCED_VIDEO_PROCESSING. mfreadwrite/tests: Test source reader transforms with MF_SOURCE_READER_ENABLE_VIDEO_PROCESSING. mfreadwrite/tests: Test source reader exposed transforms and types. mfreadwrite/tests: Initialize test source stream types from descriptors. https://gitlab.winehq.org/wine/wine/-/merge_requests/4983

2 7

Re: [PATCH v4 0/1] MR632: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) Feb. 8, 2024

Feb. 8, 2024

I see no problem merging as-is -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632#note_60599

1 0

[PATCH v3 0/1] MR632: Draft: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) Feb. 8, 2024

Feb. 8, 2024

Spec https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12gr…. I am just unsure if checking the max and minimum range is necessary, or if that can be understood as programming error. -- v3: vkd3d: Implement d3d12_command_list_OMSetDepthBounds() https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632

2 1

[PATCH v2 0/1] MR632: Draft: vkd3d: Implement d3d12_command_list_OMSetDepthBounds()
by Raphael Abrantes (＠antenabr2) Feb. 8, 2024

Feb. 8, 2024

Spec https://learn.microsoft.com/en-us/windows/win32/api/d3d12/nf-d3d12-id3d12gr…. I am just unsure if checking the max and minimum range is necessary, or if that can be understood as programming error. -- v2: vkd3d: Implement d3d12_command_list_OMSetDepthBounds() https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/632

3 3

Re: [PATCH v2 0/6] MR5053: wined3d: FFP refactoring.
by Henri Verbeet (＠hverbeet) Feb. 8, 2024

Feb. 8, 2024

Would it make sense to rename shader_select()/vp_enable()/fp_enable() to something like shader_apply_draw_state()/vp_apply_draw_state()/fp_apply_draw_state(), along the lines of wined3d_context_vk_apply_draw_state()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5053#note_60593

1 0