April 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/5] MR5463: mfreadwrite: Test and fix some reference leaks.
by Rémi Bernon May 28, 2024

May 28, 2024

These were probably the cause of crashes of https://gitlab.winehq.org/wine/wine/-/merge_requests/5459 runs on 32bit Linux VMs. Also included some test fixes that were in https://gitlab.winehq.org/wine/wine/-/merge_requests/5459. -- v2: mfreadwrite/reader: Avoid leaking the stream transform service MFT. mfreadwrite/tests: Shutdown the test stream event queues on source shutdown. mfreadwrite/tests: Avoid using MFCreateMediaBufferFromMediaType. mfreadwrite/tests: Do not accept MFVideoFormat_RGB32 in the test transform. mf/tests: Fix printf format warning. https://gitlab.winehq.org/wine/wine/-/merge_requests/5463

1 8

[PATCH 0/3] MR5474: winhttp: Receive response timeout and connection caching.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5474

3 5

[PATCH v5 0/3] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Rémi Bernon May 28, 2024

May 28, 2024

Wine incorrectly inserts a sample copier. D3D awareness is handled per node, and each node will have their own sample allocator created from the D3D device manager provided by the session. -- v5: mf/tests: Test device manager handling in the topology loader. mf/tests: Test D3D awareness handling in the topology loader. include: Add MFTOPOLOGY_DXVA_MODE enum definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/5464

2 8

[PATCH v2 0/2] MR2724: wined3d: Submit command buffers that are built for longer than 2 ms.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

This improves performance for the game "Grounded", on a AMD Radeon RX 6700 XT, with radv from Mesa 22.3.6. Testing was done with the "cb_access_map_w" option enabled, which also improves performance with the game by itself. >From my testing, it's possible to raise the threshold from 2 ms up to 5 ms or so, before the driver or GPU seems to reclock back to the lower power level. However, this measurement is questionable for several reasons. It seems to vary depending on the scene being rendered, and of course this will be specific to the game and driver and GPU in question anyway. The game also has a weird approach to vsync that seems to involve it presenting stale frames (and hence artificially inflating the FPS), which I'm not fully sure I accounted for while measuring. And of course, it's hard to be sure that 5 ms is actually the threshold for how long the driver will go before powering down the GPU. In any case, it seems better to err on the side of submitting more often, to make sure the fix affects more drivers. While submission isn't cheap, it seems to me that submitting every 2 ms is unlikely to cause a bottleneck [consider that this is at most 8 (more) submissions per frame]. The maximum of 4 concurrent periodically submitted buffers was chosen arbitrarily. Removing the maximum altogether does not measurably affect performance for this game either way. Credit goes to Philip Rebohle and his work on DXVK for helping me to notice that periodic submission might make a difference. -- v2: wined3d: Submit command buffers that are built for longer than 2 ms. wined3d: Retrieve the VkCommandBuffer from wined3d_context_vk after executing RTV barriers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2724

7 15

[PATCH 0/2] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

4 10

[PATCH 0/4] MR5458: widl: Add support for interfaces to SLTG typelib generator.
by Dmitry Timoshkov (＠dmitry) May 28, 2024

May 28, 2024

Adding support for interfaces implies adding support for function descriptions, so the patch is a bit large. I didn't manage to create an .idl with a function outside of an interface, so I couldn't test it separately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5458

4 7

[PATCH v6 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) May 28, 2024

May 28, 2024

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v6: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 2

[PATCH 0/6] MR5470: win32u: Get rid of the window surface recursive mutex.
by Rémi Bernon May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5470

2 8

[PATCH v2 0/2] MR5460: mfmediaengine: Allow decoders to be resolved before optional effect nodes.
by Rémi Bernon May 28, 2024

May 28, 2024

Otherwise pipelines fail to resolve when media source outputs compressed samples and applications have inserted optional effects (such as VRChat with AVPro player). Note that the topology loader doesn't currently support MF_CONNECT_AS_OPTIONAL, although the connection succeeds in the the cases I've seen. -- v2: mfmediaengine: Allow decoder / converter to be resolved between topology nodes. mfmediaengine/tests: Test that effects allow converters between them. https://gitlab.winehq.org/wine/wine/-/merge_requests/5460

2 4

[PATCH v2 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- v2: msvcrt: Let stderr be always be unbuffered. ucrtbase/tests: Add tests for checking buffering state of standard streams. msvcrt/tests: Add tests for check buffering state of standard streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

2 4