April 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

6 15

[PATCH v6 0/1] MR5369: winegstreamer: Refactor wg_format.
by Ziqing Hui (＠zhui) May 28, 2024

May 28, 2024

Since we are adding more and more media formats to wg_format, the current wg_format struct is getting ugly. Everytime we add a video format, we need to duplicate width, height, fps. Everytime we add a audio format, we need to duplicate channels, rate. So it would be better if we could share width, height, fps fields between different video formats, also share channels and rate fields between different audio formats. What makes me found the current wg_format is not in a good shape is when I was writting code for Proton, I found that I need to write some code like this if want to get width/height/fps from a wg_format: ``` static bool get_video_info_from_wg_format(struct wg_format *format, int32_t *width, int32_t *height, uint32_t *fps_n, uint32_t *fps_d) { switch (format->major_type) { case WG_MAJOR_TYPE_VIDEO: *width = format->u.video.width; *height = format->u.video.height; *fps_n = format->u.video.fps_n; *fps_d = format->u.video.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_CINEPAK: *width = format->u.video_cinepak.width; *height = format->u.video_cinepak.height; *fps_n = format->u.video_cinepak.fps_n; *fps_d = format->u.video_cinepak.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_H264: *width = format->u.video_h264.width; *height = format->u.video_h264.height; *fps_n = format->u.video_h264.fps_n; *fps_d = format->u.video_h264.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_WMV: *width = format->u.video_wmv.width; *height = format->u.video_wmv.height; *fps_n = format->u.video_wmv.fps_n; *fps_d = format->u.video_wmv.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_INDEO: *width = format->u.video_indeo.width; *height = format->u.video_indeo.height; *fps_n = format->u.video_indeo.fps_n; *fps_d = format->u.video_indeo.fps_d; return true; case WG_MAJOR_TYPE_VIDEO_MPEG1: *width = format->u.video_mpeg1.width; *height = format->u.video_mpeg1.height; *fps_n = format->u.video_mpeg1.fps_n; *fps_d = format->u.video_mpeg1.fps_d; return true; default: GST_ERROR("Type %d is not a video format.\n", format->major_type); return false; } } ``` Apparently, the code above is ugly. By refactoring wg_format, we can avoid code like this. This patch is a draft now, it only contains unixlib.h code. Zeb, I'd like to confirm that if this refactoring would be acceptable for you. If do, I'll continue finishing the remaining parts. -- v6: winegstreamer: Refactor wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/5369

4 8

[PATCH v2 0/1] MR5426: user32/tests: Mark test todo only on Mac and X11 drivers.
by Esme Povirk (＠madewokherd) May 28, 2024

May 28, 2024

-- v2: user32/tests: Mark test todo only on Mac and X11 drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/5426

4 4

[PATCH v4 0/5] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- v4: ntdll: Store exception reporting flags for debug events. ntdll: Store exception reporting flags on suspend. ntdll: Store exception reporting flags in server context. ntdll: Set exception reporting flags in NtGetContextThread(). ntdll/tests: Add tests for CONTEXT_EXCEPTION_REQUEST. https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

3 9

[PATCH v2 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu May 28, 2024

May 28, 2024

-- v2: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

3 22

[PATCH v2 0/2] MR5502: notepad: Use wide character string literals
by Isaac Marovitz (＠IsaacMarovitz) May 28, 2024

May 28, 2024

-- v2: notepad: Use wide character string literals in dialog.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/5502

3 3

[PATCH 0/1] MR5495: explorer: Fix font handle leaks in virtual desktop.
by Alex Henrie (＠alexhenrie) May 28, 2024

May 28, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56133 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5495

3 2

[PATCH v2 0/4] MR5471: wined3d: Dynamic pipeline state, part 3: EXT_extended_dynamic_state3.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

-- v2: wined3d: Use dynamic state for rasterizer state if possible. wined3d: Use dynamic state for blend state if possible. wined3d: Use dynamic state for multisample state if possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/5471

4 6

[PATCH v2 0/1] MR5454: winegstreamer: Ensure stream format change notification on size change in h264 decoder.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- v2: winegstreamer: Destroy wg_transform in video_decoder/transform_SetInputType(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5454

4 4

[PATCH 0/4] MR5476: winegstreamer: Introduce new wg_transform buffer copy helpers.
by Rémi Bernon May 28, 2024

May 28, 2024

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5055. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5476

2 5