May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Stefan Dösinger May 28, 2024

May 28, 2024

> At the same time, I haven't seen any evidence that a modern GPU will ever perform better with a vertex buffer not in sysmem unless it's using the streaming pattern I guess it should perform better with a vidmem buffer if the buffer is holding static data and not locked after the initial upload. Can you check D3DDEVICEDESC.dwMaxVertexCount on these cards? Regardless of what we do with these two patches I think we should reduce it to whatever Windows reports. (1024 in my case on Windows 11) Conceptually the two patches have my blessing though, regardless of specifics of what PoP3D is doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68141

1 0

Re: [PATCH v4 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Aida Jonikienė May 28, 2024

May 28, 2024

On Thu Apr 18 23:08:03 2024 +0000, Jinoh Kang wrote: > @rbernon Thanks for your review! Right now I'm tentatively putting this > MR on hold until I find a solution for a memory leak: a new (redundant) > dependency edge is added every time the application calls > `GetProcAddress()` on a forwarded ref. Has the memory leak been fixed? 🫗️ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7#note_68140

1 0

[PATCH 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585)
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

5 11

Re: [PATCH v2 0/3] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Henri Verbeet (＠hverbeet) May 28, 2024

May 28, 2024

It may be worth including a call to GetVertexBufferDesc() in the tests. As Matteo mentioned in an earlier comment, the docs seem to suggest that omitting D3DVBCAPS_SYSTEMMEMORY allows the driver/runtime to place the buffer as it sees fit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404#note_68109

1 0

Re: [PATCH v8 0/1] MR5188: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. - approved
by Sven Baars (＠sbaars) May 28, 2024

May 28, 2024

This merge request was approved by Sven Baars. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

1 0

Re: [PATCH v3 0/3] MR5484: dxgi: Add IDXGISwapChain{2,3,4} stubs for D3D11. - approved
by Jan Sikorski (＠jsikorski) May 28, 2024

May 28, 2024

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5484

1 0

[PATCH 0/2] MR2404: ddraw: Two improvements for Prince of Persia 3D.
by Zebediah Figura (＠zfigura) May 28, 2024

May 28, 2024

This fixes a regression introduced by 15d53761a5fbfc12fc5f9974c029dace00eab33d. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2404

6 15

Re: [PATCH v6 0/1] MR5497: ntdll: Implement NtQueueApcThreadEx() - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

1 0

Re: [PATCH v6 0/1] MR5380: netapi32: Add NetRemoteTOD stub. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5380

1 0

Re: [PATCH v2 0/1] MR5506: gdiplus: Fix IWICBitmapFrameDecode reference leak in decode_frame_wic. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5506

1 0