May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

Calling write_current_mode() in add_gpu seems weird. Not to mention write_current_mode() actually writes the current mode for the last source. write_current_mode() is also called at multiple places. It just seems that it should be called at one appropriate place and that's it. Also, why is this patch necessary? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67593

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

'add_physical_source' here just doesn't look consistent with other functions in device_manager. Maybe add a "BOOL is_physical" or something in struct device_manager_ctx so that when both is_physical and is_virtual_desktop() are TRUE we report sources as detached. Then we set is_physical to FALSE and start adding sources for the virtual desktop. Use your best judgment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67592

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

What's the point of writing these modes for physical sources/monitors? We are not going to use them anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67591

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

Put this to where the old update_display_devices() was so the diff is clearer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67590

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

I don't think These physical sources should be visible in EnumDisplayDevices(). If you report a physical source, doesn't that mean I can attach it? by calling ChangeDisplaySettings() with a valid mode? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67589

1 0

Re: [PATCH v5 0/4] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Zhiyi Zhang (＠zhiyi) May 28, 2024

May 28, 2024

What is this fake source supposed to do now? Virtual desktop has its own virtual source. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422#note_67588

1 0

Re: [PATCH v3 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Jacek Caban (＠jacek) May 28, 2024

May 28, 2024

> It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. I think it would be nicer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482#note_67565

1 0

[PATCH 0/7] MR5482: winevulkan: Move swapchain wrappers out of the user drivers.
by Rémi Bernon May 28, 2024

May 28, 2024

This introduces a custom `VkPresentSurfacesInfoWine` struct to the driver queue present. It could very well be a separate vkQueuePresent parameter, now that the driver interface is manually written. For now it provides the swapchains HWND, for vulkan_surface_presented, which is mostly just for winewayland purposes. Later I intend to change it to pass win32u surfaces wrappers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5482

1 9

[PATCH v3 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon May 28, 2024

May 28, 2024

-- v3: win32u: Split virtual desktop modes to a add_virtual_modes helper. win32u: Delay writing current display settings to the registry. winex11: Let win32u decide when to force update the display cache. win32u: Don't force refresh the display cache on thread desktop change. winex11: Report all sources as detached in virtual desktop mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

2 9

[PATCH 0/1] MR5418: winewayland: Move wayland_surface_ensure_contents to wayland_vkCreateWin32SurfaceKHR.
by Rémi Bernon May 28, 2024

May 28, 2024

I would like to get rid of the driver-specific swapchain code and this is getting in the way. Any reason not to do that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5418

2 11