May 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/10] MR4652: wined3d: A few more old-GL fixes.
by Matteo Bruni (＠Mystral) May 28, 2024

May 28, 2024

Here are 5 more patches on top of !4624, mostly along the same lines. I realize it's super late, no need to rush reviewing :slight_smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4652

4 16

[PATCH 0/1] MR5494: ntdll: Implement NtQuerySystemInformation( SystemProcessIdInformation ).
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

Should help with Overwatch 2 random crashes after some time of playing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5494

3 4

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Robin Kertels (＠K0bin) May 28, 2024

May 28, 2024

Thanks for the review. > They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. Interesting. I'd be perfectly fine with dropping the separate alpha test entirely. I also meant to mask out the alpha but I guess I forgot it there or lost it during rebase/cleanup. > if (foo) { something(); } > Please put the { on a new line consistently. Ah, I'm trying. I thought I got it right but I guess old habits die hard. I use the same line { in every other project, so not surprised that I slipped up a couple of times. I'll fix that. > test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters > In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? Oops, that's a leftover of my original approach. I originally meant to create a new device for each test case and pass the required presentation params but later changed it to just use a single device created using `create_device` and reset that as needed. I meant to get rid of the second device that's created manually. I will also look into using the current monitor resolution for the fullscreen tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67838

1 0

[PATCH 0/2] MR5501: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub.
by Vijay Kiran Kamuju (＠infyquest) May 28, 2024

May 28, 2024

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Refer to !5269 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5501

4 9

Re: [PATCH v3 0/3] MR5500: d3d9: Add a few swapchain tests
by Stefan Dösinger May 28, 2024

May 28, 2024

The tests pass on my Windows 11 machine with a Radeon 560 GPU. They fail on my Windows XP box, r250 GPU, see the attached log file. It seems that It doesn't follow the alpha = 0xff behavior of newer GPUs and just returns alpha 0x0 in either case. The window positioning test needlessly depends on it. If I mask out the alpha channel in test_get_front_buffer_data_windowed_positioning() it passes. I haven't looked closely at the code yet - I see some style inconsistencies, like if (foo) { something(); } Please put the { on a new line consistently. Rather than hardcoding the positions to check in the windowed mode tests please call GetWindowRect after creating the device and calculate the checked positions relative to it. There are window managers on the Linux side that don't allow applications to decide their placement and will break this kind of test. I suspect fvwm2 will cause you trouble otherwise. test_swapchain_buffer_swapping() and test_get_front_buffer_data_alpha() leak your initial device, the one you use to populate present_parameters. The other unfortunate side effect of initializing present_parameters like that is that you switch the screen to 640x480 fullscreen mode. I recommend to use EnumDisplaySettingsW(ENUM_CURRENT_SETTINGS) to retrieve the current mode and use it to create a fullscreen device that doesn't change the mode. Changing the mode moves around Windows on Windows 10/11 and most Linux desktops. In the case of test_swapchain_buffer_swapping I don't see why you need to call IDirect3D9::CreateDevice yourself - what prevents you from using the device returned by create_device? [r200-xp.txt](/uploads/5f577583ec5703e2a040077de884faf3/r200-xp.txt) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5500#note_67826

1 0

[PATCH v2 0/1] MR5499: mscms: Add stub for WcsGetDefaultColorProfile.
by Vijay Kiran Kamuju (＠infyquest) May 28, 2024

May 28, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56554 -- v2: mscms: Add stub for WcsGetDefaultColorProfile. https://gitlab.winehq.org/wine/wine/-/merge_requests/5499

3 2

[PATCH v3 0/4] MR5488: win32u: Add display device cache modes all at once.
by Rémi Bernon May 28, 2024

May 28, 2024

To make https://gitlab.winehq.org/wine/wine/-/merge_requests/5422 simpler. This will also make it easier to write the mode list to the registry as a single binary blob, although it is a larger change that could be done later. -- v3: win32u: Add all display device source modes at once. win32u: Keep the primary current mode in the device manager context. win32u: Remove fake source creation when adding display mode. win32u: Close device manager source key in write_source_to_registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/5488

2 5

[PATCH 0/6] MR5480: ntdll: Support exception reporting flags in contexts.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5480

4 9

[PATCH v4 0/2] MR5269: Add NtQueryInformationProcess(ProcessQuotaLimits) stub
by Gijs Vermeulen (＠gverm) May 28, 2024

May 28, 2024

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 -- v4: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) tests. ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5269

5 8

[PATCH v5 0/2] MR5497: ntdll: Implement NtQueueApcThreadEx()
by Isaac Marovitz (＠IsaacMarovitz) May 28, 2024

May 28, 2024

Should resolve a crash in `libogg` in the game "Cabal Online" -- v5: wow64: Add NtQueueApcThreadEx() https://gitlab.winehq.org/wine/wine/-/merge_requests/5497

2 3