June 2024 - Wine-GitLab - list.winehq.org

[PATCH v4 0/2] MR5222: kernelbase: Allow WriteProcessMemory to succeed on PAGE_EXECUTE_READ.
by Marc-Aurel Zent (＠mzent) June 19, 2024

June 19, 2024

More details here: https://devblogs.microsoft.com/oldnewthing/20181206-00/?p=100415 However it does not mention that `PAGE_NOACCESS` and `PAGE_READONLY` still result in an error on Windows, which is properly implemented in this MR. Only `WriteProcessMemory` offers this "service", `NtWriteVirtualMemory` will fail on non-writeable and executable regions (and already does so, except for the the mach server backend, which needs https://gitlab.winehq.org/wine/wine/-/merge_requests/4826 to also behave correctly here). -- v4: kernelbase: Flush instruction cache in WriteProcessMemory. kernelbase: Allow WriteProcessMemory to succeed on PAGE_EXECUTE and PAGE_EXECUTE_READ. https://gitlab.winehq.org/wine/wine/-/merge_requests/5222

3 6

[PATCH 0/1] MR5880: msado15: Use the correct version when loading the typelib
by Alistair Leslie-Hughes (＠alesliehughes) June 19, 2024

June 19, 2024

Since 1,0 was passed it never found the Typelib in the register. Changing to the actual version allows the typelib to be loaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5880

2 1

[PATCH v4 0/3] MR4826: Mach vm operations improvements
by Marc-Aurel Zent (＠mzent) June 19, 2024

June 19, 2024

For all mach vm operations this removes the task suspend and resume, which are not needed. This uses `mach_vm_read_overwrite` to read into a caller-specified buffer, saving the `mach_vm_deallocate` call (bringing all read operations down to 1 syscall from 4). The only alignment restriction on `mach_vm_write` according to the original CMU documentation is that data is > [pointer to page aligned in array of bytes] An array of data to be written. (In practice it also works with arbitrary addresses on macOS, but it probably doesn't hurt to follow the original specifications here). The only other reference that these read/writes should be page-aligned is from the GNU Hurd documentation > The current implementation requires that address, data and data_count all be page-aligned. Otherwise, KERN_INVALID_ARGUMENT is returned. which I assume was the reason why this was originally done (plus it sounds to me like they will fix that in the future and 4fe19777 already broke GNU Hurd support anyways, if that was supposed to be working). Also this includes the missing mach part of 5b1f3b14, which was only applied to the ptrace backend, and together with the `write_process_memory` rework, this gets rid of all fixmes in mach.c -- v4: server: Simplify mach write_process_memory. server: Use mach_vm_read_overwrite in get_selector_entry. server: Use mach_vm_read_overwrite in read_process_memory. https://gitlab.winehq.org/wine/wine/-/merge_requests/4826

2 4

[PATCH v4 0/7] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) June 19, 2024

June 19, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v4: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

2 7

[PATCH v8 0/7] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) June 19, 2024

June 19, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v8: quartz/tests: Test that avi_decompressor_source_qc_Notify does not deadlock if called from a foreign thread during IMemInput_Receive. quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. msvfw32/tests: Test that Cinepak rejects unsupported output types. iccvid: Reject unsupported output types. quartz/tests: Add Cinepak test to avi splitter. winegstreamer: Make AVI splitter use end of previous frame if the current frame doesn't have a timestamp. winegstreamer: Implement AM_MEDIA_TYPE to wg_format converter for Cinepak video. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 10

Re: [PATCH v5 0/7] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) June 19, 2024

June 19, 2024

Rebased against master, but is still good as is. The French (and most likely other layouts) will require a more nuanced mapping, which would probably make this MR too big, but is also already done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5319#note_73698

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon June 19, 2024

June 19, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > - { > - gst_caps_unref(parsed_caps); > - parsed_caps = gst_caps_ref(src_caps); > - } > - > - if (!(element = find_element(GST_ELEMENT_FACTORY_TYPE_DECODER, parsed_caps, sink_caps)) > - || !append_element(transform->container, element, &first, &last)) > - goto out; > - break; > - > - case WG_MAJOR_TYPE_AUDIO: > - case WG_MAJOR_TYPE_VIDEO: > - break; > - case WG_MAJOR_TYPE_UNKNOWN: > - GST_FIXME("Format %u not implemented!", input_format.major_type); > + if (!transform_create_transcoder(transform, src_caps, &input_format, &first, &last)) Can we add an encoder element without changing all this code? It doesn't look like you need all the complicated converter sequence, maybe only a videoconvert (do you even need one?). I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73696

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon June 19, 2024

June 19, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/video_encoder.c: > + TRACE("iface %p increasing refcount to %lu.\n", encoder, refcount); > + > + return refcount; > +} > + > +static ULONG WINAPI transform_Release(IMFTransform *iface) > +{ > + struct video_encoder *encoder = impl_from_IMFTransform(iface); > + ULONG refcount = InterlockedDecrement(&encoder->refcount); > + > + TRACE("iface %p decreasing refcount to %lu.\n", encoder, refcount); > + > + if (!refcount) > + { > + if (encoder->attributes) > + IMFAttributes_Release(encoder->attributes); You can remove the if. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73695

1 0

[PATCH 0/1] MR5871: ntdll: Fix macOS build errors with Xcode 16.
by Brendan Shanks (＠bshanks) June 19, 2024

June 19, 2024

LLVM 17 or 18 no longer allow non-private labels to appear between .cfi_startproc/endproc when targeting Mach-O. Similar fixes as in commit 295d521b11644fb76c36854336b13c2155bb7d79. Since this is needed for 2 out of 4 architectures, would it be better to do it for all 4 and then modify the shared `__wine_syscall_dispatcher_return()` prototype? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5871

3 2

[PATCH v3 0/1] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) June 19, 2024

June 19, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v3: quartz: Implement AMT/WMT differences for WMV media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

3 4