June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR5835: win32u, winex11: Avoid using the win32u vulkan driver interface.
by Rémi Bernon June 19, 2024

June 19, 2024

On Tue Jun 18 16:34:50 2024 +0000, Emil Velikov wrote: > Does the wine (pre)loader unload things on `exit()` or perhaps the > dependency on ntdll.so and(?) win32u.so, makes that impossible? > Either way, as you said there are bigger concerns than this one dlhandle. Well for instance the user driver is never unloaded, and it links and uses symbols from win32u directly, so neither of them will be unloaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5835#note_73682

1 0

[PATCH v4 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) June 19, 2024

June 19, 2024

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v4: winewayland.drv: Add mouse rawinput support server: Add send_hardware_message flags for rawinput translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

4 13

[PATCH v2 0/5] MR5844: opengl32: Add default implementations for wglGetPixelFormatAttrib{i,f}vARB.
by Alexandros Frantzis (＠afrantzis) June 19, 2024

June 19, 2024

This MR extends the `wgl_pixel_format` struct with extra fields required to implement `wglGetPixelFormatAttribivARB` in opengl32.dll. I have added only fields that are relevant to the current needs of the drivers. The default implementation will be used automatically if the driver populates the extra fields, which this MR does for the winex11 driver. The new winex11 implementation tries to remain faithful to the previous behavior in terms of error handling and fallbacks. To achieve this the `wgl_pixel_format` extra fields can be marked as invalid in order for the default implementation to return errors accordingly. Note, however, that error handling around `glXGetFBConfigAttrib` is not very consistent (e.g., the parts of `describe_pixel_format` dealing with PIXELFORMATDESCRIPTOR generally disregard errors). The MR also adds a default implementation for `wglGetPixelFormatAttribfvARB` which piggy-backs on the integer variant of this function, and removes the need for the corresponding code in the drivers. Note that we could potentially remove this function completely from `struct opengl_funcs` (i.e., place it in `manual_win_functions` in `make_opengl`), but it seems the pattern is to maintain a complete list of extension functions (and wined3d also populates the field internally, although it doesn't seem to do anything with it). Finally, the `winex11.drv/opengl.c` file contains a mix of coding styles. I chose to be consistent with the style of the closest context (e.g., the function) I was making changes/additions in. -- v2: winex11: Use default wglGetPixelFormatAttribivARB implementation. winex11: Pass wgl_pixel_format to describe_pixel_format. winex11: Update describe_pixel_format coding style. opengl32: Add default implementation for wglGetPixelFormatAttribfvARB. opengl32: Add default implementation for wglGetPixelFormatAttribivARB. https://gitlab.winehq.org/wine/wine/-/merge_requests/5844

3 16

[PATCH v2 0/1] MR5852: win32u: Implement EVENT_OBJECT_DESTROY.
by Esme Povirk (＠madewokherd) June 19, 2024

June 19, 2024

-- v2: win32u: Implement EVENT_OBJECT_DESTROY. https://gitlab.winehq.org/wine/wine/-/merge_requests/5852

4 5

[PATCH 0/9] MR5876: winegstreamer: Implement more Media Foundation compressed format mappings.
by Elizabeth Figura (＠zfigura) June 19, 2024

June 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5876

3 10

[PATCH 0/3] MR5874: ntdll/tests: Add more tests for WoW64 IOSB handling.
by Elizabeth Figura (＠zfigura) June 18, 2024

June 18, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5874

2 3

[PATCH v23 0/7] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) June 18, 2024

June 18, 2024

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v23: ntdll: Use PAGEMAP_SCAN to implement get_working_set_ex, if available. kernel32: Add tests for large page mapping support. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 8

[PATCH 0/1] MR5873: dbghelp: Add ARM/ARM64 machine types for Mach-O.
by Brendan Shanks (＠bshanks) June 18, 2024

June 18, 2024

When launching winedbg (emulated through Rosetta), avoids warnings like: ``` 0110:fixme:dbghelp_macho:macho_cpu_to_machine Untranslated Mach-O CPU 100000c 0110:fixme:dbghelp_macho:macho_cpu_to_machine Untranslated Mach-O CPU 100000c ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5873

2 1

Re: [PATCH v8 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Jacek Caban (＠jacek) June 18, 2024

June 18, 2024

On Fri Jun 7 14:39:29 2024 +0000, Gabriel Ivăncescu wrote: > I see, if you look at it that way it makes sense to use IID, yeah (I was > thinking of the functions as complete separate entities rather than > interface implementations). > I still think it's slightly better to just pass/store func_info_t as a > container though—it's not just the args but everywhere else we need to > store it (like in ProxyFunction as I mentioned), now it's one less field > to worry about. And besides, if we ever do need to change it at some > point later, it will be much easier without affecting call sites. Current func info is more than (id,iid) carrier, it would only make things more confusing to reuse it as an opaque with constrains like that. We could introduce a new struct, if needed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5444#note_73651

1 0

Re: [PATCH v2 0/2] MR5835: win32u, winex11: Avoid using the win32u vulkan driver interface. - approved
by Alexandre Julliard (＠julliard) June 18, 2024

June 18, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5835

1 0