June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon June 19, 2024

June 19, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > - { > - gst_caps_unref(parsed_caps); > - parsed_caps = gst_caps_ref(src_caps); > - } > - > - if (!(element = find_element(GST_ELEMENT_FACTORY_TYPE_DECODER, parsed_caps, sink_caps)) > - || !append_element(transform->container, element, &first, &last)) > - goto out; > - break; > - > - case WG_MAJOR_TYPE_AUDIO: > - case WG_MAJOR_TYPE_VIDEO: > - break; > - case WG_MAJOR_TYPE_UNKNOWN: > - GST_FIXME("Format %u not implemented!", input_format.major_type); > + if (!transform_create_transcoder(transform, src_caps, &input_format, &first, &last)) Can we add an encoder element without changing all this code? It doesn't look like you need all the complicated converter sequence, maybe only a videoconvert (do you even need one?). I don't want to be a blocker but to be honest I'm a bit annoyed with the idea of having to rewrite the patches I am trying to upstream with transform media types. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73696

1 0

Re: [PATCH v2 0/5] MR5879: winegstreamer: Implement stubs for h264 encoder.
by Rémi Bernon June 19, 2024

June 19, 2024

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/video_encoder.c: > + TRACE("iface %p increasing refcount to %lu.\n", encoder, refcount); > + > + return refcount; > +} > + > +static ULONG WINAPI transform_Release(IMFTransform *iface) > +{ > + struct video_encoder *encoder = impl_from_IMFTransform(iface); > + ULONG refcount = InterlockedDecrement(&encoder->refcount); > + > + TRACE("iface %p decreasing refcount to %lu.\n", encoder, refcount); > + > + if (!refcount) > + { > + if (encoder->attributes) > + IMFAttributes_Release(encoder->attributes); You can remove the if. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5879#note_73695

1 0

[PATCH 0/1] MR5871: ntdll: Fix macOS build errors with Xcode 16.
by Brendan Shanks (＠bshanks) June 19, 2024

June 19, 2024

LLVM 17 or 18 no longer allow non-private labels to appear between .cfi_startproc/endproc when targeting Mach-O. Similar fixes as in commit 295d521b11644fb76c36854336b13c2155bb7d79. Since this is needed for 2 out of 4 architectures, would it be better to do it for all 4 and then modify the shared `__wine_syscall_dispatcher_return()` prototype? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5871

3 2

[PATCH v3 0/1] MR5846: quartz: Set biSizeImage for WMV media type.
by Alfred Agrell (＠Alcaro) June 19, 2024

June 19, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56769 -- v3: quartz: Implement AMT/WMT differences for WMV media type. https://gitlab.winehq.org/wine/wine/-/merge_requests/5846

3 4

[PATCH 0/2] MR5872: ddraw: Preserve d3d device state in ddraw_surface_create().
by Paul Gofman (＠gofman) June 19, 2024

June 19, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5872

4 5

[PATCH 0/2] MR5877: winex11: Create a global vulkan instance for xrandr.
by Rémi Bernon June 19, 2024

June 19, 2024

And the other cleanup suggested in https://gitlab.winehq.org/wine/wine/-/merge_requests/5835. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5877

2 3

Re: [PATCH v2 0/2] MR5835: win32u, winex11: Avoid using the win32u vulkan driver interface.
by Rémi Bernon June 19, 2024

June 19, 2024

On Tue Jun 18 16:34:50 2024 +0000, Emil Velikov wrote: > Does the wine (pre)loader unload things on `exit()` or perhaps the > dependency on ntdll.so and(?) win32u.so, makes that impossible? > Either way, as you said there are bigger concerns than this one dlhandle. Well for instance the user driver is never unloaded, and it links and uses symbols from win32u directly, so neither of them will be unloaded. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5835#note_73682

1 0

[PATCH v4 0/2] MR5869: winewayland.drv: Add mouse rawinput support
by Grigory Vasilyev (＠h0tc0d3) June 19, 2024

June 19, 2024

Adds the registry key HKEY_CURRENT_USER\\Software\\Wine\\Wayland Driver\\rawinput witch allows mouse raw input. This makes it easier to calculate the same sensitivity in different games, use sensitivity calculators, and easily change values when changing mouse DPI and do not depend on the compositor or OS. For example, you want to set the sensitivity to half as much, but sensitivity curves in libinput are more difficult to calculate than mouse sensitivity in the games. Implementation of ideas written in the comments: https://gitlab.winehq.org/wine/wine/-/merge_requests/4698 -- v4: winewayland.drv: Add mouse rawinput support server: Add send_hardware_message flags for rawinput translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5869

4 13

[PATCH v2 0/5] MR5844: opengl32: Add default implementations for wglGetPixelFormatAttrib{i,f}vARB.
by Alexandros Frantzis (＠afrantzis) June 19, 2024

June 19, 2024

This MR extends the `wgl_pixel_format` struct with extra fields required to implement `wglGetPixelFormatAttribivARB` in opengl32.dll. I have added only fields that are relevant to the current needs of the drivers. The default implementation will be used automatically if the driver populates the extra fields, which this MR does for the winex11 driver. The new winex11 implementation tries to remain faithful to the previous behavior in terms of error handling and fallbacks. To achieve this the `wgl_pixel_format` extra fields can be marked as invalid in order for the default implementation to return errors accordingly. Note, however, that error handling around `glXGetFBConfigAttrib` is not very consistent (e.g., the parts of `describe_pixel_format` dealing with PIXELFORMATDESCRIPTOR generally disregard errors). The MR also adds a default implementation for `wglGetPixelFormatAttribfvARB` which piggy-backs on the integer variant of this function, and removes the need for the corresponding code in the drivers. Note that we could potentially remove this function completely from `struct opengl_funcs` (i.e., place it in `manual_win_functions` in `make_opengl`), but it seems the pattern is to maintain a complete list of extension functions (and wined3d also populates the field internally, although it doesn't seem to do anything with it). Finally, the `winex11.drv/opengl.c` file contains a mix of coding styles. I chose to be consistent with the style of the closest context (e.g., the function) I was making changes/additions in. -- v2: winex11: Use default wglGetPixelFormatAttribivARB implementation. winex11: Pass wgl_pixel_format to describe_pixel_format. winex11: Update describe_pixel_format coding style. opengl32: Add default implementation for wglGetPixelFormatAttribfvARB. opengl32: Add default implementation for wglGetPixelFormatAttribivARB. https://gitlab.winehq.org/wine/wine/-/merge_requests/5844

3 16

[PATCH v2 0/1] MR5852: win32u: Implement EVENT_OBJECT_DESTROY.
by Esme Povirk (＠madewokherd) June 19, 2024

June 19, 2024

-- v2: win32u: Implement EVENT_OBJECT_DESTROY. https://gitlab.winehq.org/wine/wine/-/merge_requests/5852

4 5