June 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Tue Jun 4 22:57:24 2024 +0000, cqwrteur wrote: > It was always different in layout. This is a bug for years. UCRT does > not have the same layout of FILE compared to msvcrt. However wine just > assumes they are the same, which is wrong. MSVC allows you to pass FILE* > from a statically linked ucrt to a dynamic linked ucrt provided by the > operating system and that is of course causing abi break. https://github.com/cppfastio/fast_io/blob/next/include/fast_io_legacy_impl/… I have changed my code to make it clearer. msvcrt and ucrt always use different layouts. This should be clearer for you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72402

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Fri May 31 21:05:42 2024 +0000, cqwrteur wrote: > Done :) hi. Can you merge the code? @alexhenrie I desperately need this. Please do not break my library. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72401

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

@piotr @alexhenrie, it is time to merge the code. Ty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72400

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

@piotr Any more issues? If no, then merge it ty. I desperately need this working -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72399

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Tue Jun 4 22:57:24 2024 +0000, Piotr Caban wrote: > Please move the test to `dlls/ucrtbase/tests/file.c`. Also please add > tests in separate patch. What do you mean by a separate patch? Test Moved. Is it ok for you now? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72398

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Sun Jun 2 22:51:59 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3173_3164) It should be fixed. Please review it again -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72397

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Sun Jun 2 22:59:20 2024 +0000, cqwrteur wrote: > changed this line in [version 22 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116244&start_sha=f9ce09a15be1de01f4b8f3f2c25cf9c722a4b2d8#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3144_3149) It was always different in layout. This is a bug for years. UCRT does not have the same layout of FILE compared to msvcrt. However wine just assumes they are the same, which is wrong. MSVC allows you to pass FILE* from a statically linked ucrt to a dynamic linked ucrt provided by the operating system and that is of course causing abi break. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72396

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Sun Jun 2 22:51:59 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3171_3164) It is not. The problem is that ucrt can be statically linked from Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. And fast_io library is exploiting that to gain huge performance. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72395

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

On Sun Jun 2 22:51:57 2024 +0000, cqwrteur wrote: > changed this line in [version 21 of the diff](/wine/wine/-/merge_requests/5752/diffs?diff_id=116242&start_sha=0ed3968e5c80f1068a89193deb4b3309a69d8e27#1a28d67ae45bfb1e18198f92ca618b484c4e5a63_3153_3158) Of course, there is. The problem is that ucrt can be statically linked from Microsoft UCRT static ucrt can be put back to FILE* in dynamic linking. And fast_io library is using that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72394

1 0

Re: [PATCH v32 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 4, 2024

June 4, 2024

Please merge it. Ty. This ABI issue is a big issue for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_72393

1 0