July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Alfred Agrell (＠Alcaro) July 26, 2024

July 26, 2024

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > test-linux-32 always failed, can you see the reason for the failure? Just open [it](https://gitlab.winehq.org/fanwenjie/wine/-/jobs/89772) and scroll around until you find a colored block, then look for red lines in that block. If it has nothing to do with your changes (for example because it's about sockets or batch files), then it's broken on master too, and is someone else's problem. Just ignore it, it won't block merging. Don't rerun it, it'll just fail again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77150

1 0

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > OK test-linux-32 always failed, can you see the reason for the failure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77149

1 0

[PATCH 0/1] MR3047: ntdll: hook mmap for force allocate low 32-bit memory on wow64
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3047

5 5

[PATCH v3 0/1] MR4984: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v3: wineandroid.drv: fix incorrent path of device and init device in ANDROID_CreateDesktop https://gitlab.winehq.org/wine/wine/-/merge_requests/4984

2 2

[PATCH v6 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v6: win32u: fix a regression bug that virtual desktop not effective. https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

3 2

[PATCH v7 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

fix: https://bugs.winehq.org/show_bug.cgi?id=56993 Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- v7: win32u: fix a regression bug that virtual desktop not effective. https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

2 3

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

On Fri Jul 26 10:09:51 2024 +0000, Rémi Bernon wrote: > Fwiw, on Windows, all desktops are of the same size, which only depends > on the set of monitors which are plugged in. > IMO we should implement support for multiple virtual monitors, rather > than going back to the old virtual desktop logic. desktop is not equals to monitor, currently wine supports multiply desktops (mutiply host window) on a virtual monitor. only need one virtual monitor because it is only a virtual device. In virtual desktop mode desktop = host platform window virtual monitor=dummy host monitor device -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77129

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Rémi Bernon July 26, 2024

July 26, 2024

Fwiw, on Windows, all desktops are of the same size, which only depends on the set of monitors which are plugged in. IMO we should implement support for multiple virtual monitors, rather than going back to the old virtual desktop logic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77123

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) July 26, 2024

July 26, 2024

You can add Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56993 at the end of your commit message body. Also, the wrong commit is b86cc9e6, not fecfb442 ``` (b86cc9e6589...)|BISECTING:wine/win32-build$ git bisect bad b86cc9e658959cee47e6e587fec4f7c26350ed76 is the first bad commit commit b86cc9e658959cee47e6e587fec4f7c26350ed76 Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Tue Feb 13 15:05:37 2024 +0100 winex11: Let win32u decide when to force update the display cache. dlls/winex11.drv/window.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77120

1 0

Re: [PATCH v5 0/1] MR6150: win32u: virtual desktop for explorer.exe support different resolutions
by Zhiyi Zhang (＠zhiyi) July 26, 2024

July 26, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/win32u/sysparams.c: > struct monitor *monitor; > struct gpu *gpu; > > - if (list_head( &monitors ) == &virtual_monitor.entry) Please don't add irrelevant changes in the same commit. If you want to fix explorer.exe not starting up with a user-specified resolution, focus on that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77119

1 0