July 2024 - Wine-GitLab - list.winehq.org

[PATCH v6 0/7] MR4045: kernelbase: Rewrite ExpandEnvironmentStringsA to return ansi string size
by Fabian Maurer (＠DarkShadow44) July 27, 2024

July 27, 2024

We can't return the unicode string size, this returns sizes to small for multi-byte characters. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54295 -- v6: kernel32: Rework ExpandEnvironmentStringsA to return ansi size and fix corner cases. https://gitlab.winehq.org/wine/wine/-/merge_requests/4045

3 9

Re: [PATCH v3 0/1] MR5957: win32u: fix random crash without libfreetype
by Fabian Maurer (＠DarkShadow44) July 27, 2024

July 27, 2024

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/sysparams.c: > 'r','s','t','u','v','w','x','y','z','A','B','C','D','E','F','G','H', > 'I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z'}; > > - if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) return 0; > + if (metric && !NtGdiGetTextMetricsW( hdc, metric, 0 )) goto fail; > > if (!NtGdiGetTextExtentExW( hdc, abcdW, ARRAYSIZE(abcdW), 0, NULL, NULL, &sz, 0 )) > - return 0; > + goto fail; > > if (height) *height = sz.cy; > return (sz.cx / 26 + 1) / 2; > +fail: > + if (height) *height = 1; > + return 0; Just curious, but why `1`? Also, wouldn't it be easier to have `if (height) *height = 1;` at the beginning of the function? Then you could keep the rest the same. And maybe that function could zero the `metrics` as well? Not sure where it would be required, I find a setup without freetype strange to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5957#note_77190

1 0

[PATCH v3 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) July 27, 2024

July 27, 2024

-- v3: shell32: Fix FO_MOVE when destination has conflicting directory. shell32/tests: Add tests for moving dir(s) to destination(s) with conflicting dir. https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

3 3

[PATCH v4 0/1] MR5586: configure: Test PE compilers after setting their target argument.
by Billy Laws (＠bylaws) July 27, 2024

July 27, 2024

clang will default to the host if no target is specified, which causes compile test failures if arch-specific CFLAGS are used for a non-host arch. -- v4: configure: Test PE compilers after setting their target argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/5586

3 4

[PATCH 0/1] MR6161: gdiplus: fixed order adding offset and result ternary operator
by Herman Semenov (＠GermanAizek) July 27, 2024

July 27, 2024

Reference: https://en.cppreference.com/w/c/language/operator_precedence -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6161

3 2

[PATCH 0/2] MR6163: shell32: Fix FO_MOVE when destination has conflicting directory.
by Spencer Wallace (＠spencerwallace) July 26, 2024

July 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6163

2 2

Re: [PATCH v8 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS. - approved
by Huw Davies (＠huw) July 26, 2024

July 26, 2024

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

1 0

[PATCH v6 0/2] MR6021: nsiproxy.sys: Use pcblist64 sysctl to enumerate TCP & UDP connections on macOS.
by Tim Clem (＠tclem) July 26, 2024

July 26, 2024

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for the pcblist64 sysctls, so I'm caching the result of sysctlnametomib. -- v6: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

2 2

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Alfred Agrell (＠Alcaro) July 26, 2024

July 26, 2024

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > test-linux-32 always failed, can you see the reason for the failure? Just open [it](https://gitlab.winehq.org/fanwenjie/wine/-/jobs/89772) and scroll around until you find a colored block, then look for red lines in that block. If it has nothing to do with your changes (for example because it's about sockets or batch files), then it's broken on master too, and is someone else's problem. Just ignore it, it won't block merging. Don't rerun it, it'll just fail again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77150

1 0

Re: [PATCH v9 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Fan WenJie (＠fanwenjie) July 26, 2024

July 26, 2024

On Fri Jul 26 15:36:35 2024 +0000, Fan WenJie wrote: > OK test-linux-32 always failed, can you see the reason for the failure? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77149

1 0