July 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR5987: ddraw/tests: Workaround some X11 ConfigureNotify event race condition. - approved
by Alexandre Julliard (＠julliard) July 9, 2024

July 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5987

1 0

Re: [PATCH v6 0/9] MR6012: Support Windows ODBC drivers - approved
by Alexandre Julliard (＠julliard) July 9, 2024

July 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6012

1 0

Re: [PATCH v11 0/2] MR5969: kernelbase: Ensure null termination in RegGetValue[AW]. - approved
by Alexandre Julliard (＠julliard) July 9, 2024

July 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5969

1 0

[PATCH v5 0/5] MR5559: include: Fix another 8 typoed GUIDs
by Alfred Agrell (＠Alcaro) July 9, 2024

July 9, 2024

Same bug class as https://gitlab.winehq.org/wine/wine/-/merge_requests/5550. None of them are referenced by anything (not counting mfplat/main.c's debugstr_attr(), which names the two in mfapi.h - better debug output, yay I guess). -- v5: include: Fix typoed value of CLSID_WICXMPMetadataReader. include: Fix typoed value of MEDIASUBTYPE_P408. include: Fix typoed values of IID_IPropertyEnumType2 and CLSID_PropertySystem. include: Fix typoed values of IID_IMimeWebDocument and IID_IMimeMessageCallback. include: Fix typoed values of MF_MT_VIDEO_3D and MF_MT_AUDIO_FOLDDOWN_MATRIX. https://gitlab.winehq.org/wine/wine/-/merge_requests/5559

4 9

[PATCH 0/5] MR6033: include: Fix another 5 typoed GUIDs
by Alfred Agrell (＠Alcaro) July 9, 2024

July 9, 2024

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5559 because The Process™ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6033

4 8

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Davide Beatrici (＠davidebeatrici) July 9, 2024

July 9, 2024

Davide Beatrici (@davidebeatrici) commented about dlls/winepulse.drv/pulse.c: > + > + stream->clock_lastpos = stream->clock_written = 0; > + stream->pa_offs_bytes = stream->lcl_offs_bytes = 0; > + stream->held_bytes = stream->pa_held_bytes = 0; > + stream->period_bytes = pa_frame_size(&new_ss) * muldiv(stream->mmdev_period_usec, new_ss.rate, 1000000); > + stream->real_bufsize_bytes = size; > + stream->bufsize_frames = new_bufsize_frames; > + stream->ss = new_ss; > + > + size = 0; > + NtFreeVirtualMemory(GetCurrentProcess(), (void **)&stream->local_buffer, &size, MEM_RELEASE); > + > + silence_buffer(new_ss.format, new_buffer, size); > + stream->local_buffer = new_buffer; > + } > + } Since the operations are more or less the same as in `pulse_create_stream()`, could you create a helper function in a separate commit (that will be first in the list), please? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75624

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) July 9, 2024

July 9, 2024

On Tue Jul 9 18:18:30 2024 +0000, Dmitry Timoshkov wrote: > Hans is correct. I have a computer that is part of the AD domain, and > before logging into the domain GetUserNameEx(3) returns error 1332 > (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns > name that is equal to the displayName field in the LDAP database. > Behaviour is the same for Windows 7 and Windows 10. Hm, interesting. I'll experiment with this and make changes to my branch accordingly. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75599

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) July 9, 2024

July 9, 2024

On Tue Jul 9 18:14:36 2024 +0000, Hans Leidekker wrote: > Can you add a test case for this in dlls/secur32/tests/secur32.c? Yes, I can. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75598

1 0

[PATCH v2 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) July 9, 2024

July 9, 2024

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- v2: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

3 3

Re: [PATCH v3 0/2] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) July 9, 2024

July 9, 2024

On Tue Jul 9 16:44:32 2024 +0000, Tim Clem wrote: > Whoa, whoops. Thanks, missed that when I was cleaning up the patch. I'm > now caching the mib, which cleans things up a bit as well. Also added the UDP version while I'm at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021#note_75586

1 0