July 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR6033: include: Fix another 5 typoed GUIDs
by Alfred Agrell (＠Alcaro) July 9, 2024

July 9, 2024

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/5559 because The Process™ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6033

4 8

Re: [PATCH v5 0/3] MR5585: mmdevapi: Implement AudioClockAdjustment_SetSampleRate.
by Davide Beatrici (＠davidebeatrici) July 9, 2024

July 9, 2024

Davide Beatrici (@davidebeatrici) commented about dlls/winepulse.drv/pulse.c: > + > + stream->clock_lastpos = stream->clock_written = 0; > + stream->pa_offs_bytes = stream->lcl_offs_bytes = 0; > + stream->held_bytes = stream->pa_held_bytes = 0; > + stream->period_bytes = pa_frame_size(&new_ss) * muldiv(stream->mmdev_period_usec, new_ss.rate, 1000000); > + stream->real_bufsize_bytes = size; > + stream->bufsize_frames = new_bufsize_frames; > + stream->ss = new_ss; > + > + size = 0; > + NtFreeVirtualMemory(GetCurrentProcess(), (void **)&stream->local_buffer, &size, MEM_RELEASE); > + > + silence_buffer(new_ss.format, new_buffer, size); > + stream->local_buffer = new_buffer; > + } > + } Since the operations are more or less the same as in `pulse_create_stream()`, could you create a helper function in a separate commit (that will be first in the list), please? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5585#note_75624

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) July 9, 2024

July 9, 2024

On Tue Jul 9 18:18:30 2024 +0000, Dmitry Timoshkov wrote: > Hans is correct. I have a computer that is part of the AD domain, and > before logging into the domain GetUserNameEx(3) returns error 1332 > (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns > name that is equal to the displayName field in the LDAP database. > Behaviour is the same for Windows 7 and Windows 10. Hm, interesting. I'll experiment with this and make changes to my branch accordingly. Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75599

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) July 9, 2024

July 9, 2024

On Tue Jul 9 18:14:36 2024 +0000, Hans Leidekker wrote: > Can you add a test case for this in dlls/secur32/tests/secur32.c? Yes, I can. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75598

1 0

[PATCH v2 0/1] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) July 9, 2024

July 9, 2024

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- v2: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

3 3

Re: [PATCH v3 0/2] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) July 9, 2024

July 9, 2024

On Tue Jul 9 16:44:32 2024 +0000, Tim Clem wrote: > Whoa, whoops. Thanks, missed that when I was cleaning up the patch. I'm > now caching the mib, which cleans things up a bit as well. Also added the UDP version while I'm at it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6021#note_75586

1 0

[PATCH v2 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) July 9, 2024

July 9, 2024

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- v2: mshtml: Use IWineJSDispatch for screen object script bindings. mshtml: Support using IWineJSDispatch for DispatchEx implementation. mshtml: Pass an optional script global window to init_dispatch. mshtml: Implement jscript IWineJSDispatchHost. jscript: Use jsdisp_t internally for host objects that support it. jscript: Support host objects in disp_cmp. jscript: Support converting host objects to string. https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 13

[PATCH 0/2] MR6030: msi: Handle failure from MSI_RecordGetInteger().
by Hans Leidekker (＠hans) July 9, 2024

July 9, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56952 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6030

2 2

[PATCH 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) July 9, 2024

July 9, 2024

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 12

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) July 9, 2024

July 9, 2024

Hans is correct. I have a computer that is part of the AD domain, and before logging into the domain GetUserNameEx(3) returns error 1332 (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns name that is equal to the displayName field in the LDAP database. Behaviour is the same for Windows 7 and Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75556

1 0