July 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) July 9, 2024

July 9, 2024

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- v2: mshtml: Use IWineJSDispatch for screen object script bindings. mshtml: Support using IWineJSDispatch for DispatchEx implementation. mshtml: Pass an optional script global window to init_dispatch. mshtml: Implement jscript IWineJSDispatchHost. jscript: Use jsdisp_t internally for host objects that support it. jscript: Support host objects in disp_cmp. jscript: Support converting host objects to string. https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 13

[PATCH 0/2] MR6030: msi: Handle failure from MSI_RecordGetInteger().
by Hans Leidekker (＠hans) July 9, 2024

July 9, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56952 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6030

2 2

[PATCH 0/11] MR6029: jscript: Introduce new MSHTML bindings.
by Jacek Caban (＠jacek) July 9, 2024

July 9, 2024

This MR adds a very minimal support for new MSHTML objects bindings that will ultimately allow implementing IE9+ behavior. The plan is to have something testable that we can increment on. It's enabled only for the `Screen` object for now (which is an example of an object without custom properties with no functions). The next step is to work incrementally on enabling it for all MSHTML objects. A few comments on the approach: - The object and its jscript representation share reference counter. This may not be optimal, but it essentially preserves the current behavior where MSHTML is responsible for tracking it. I expect that we will want to revisit that when integrating cycle collector with jscript. - Deleting properties is not yet supported; this will need another function in the interface, but it's not yet needed as we currently don't allow deleting builtin properties anyway (and custom properties are skipped in this MR as they are not needed for the `Screen` object). - Functions are not yet supported, only old-style properties (not accessor properties yet). They are straightforward to support on top of it by extending `property_info` struct to pass iid and implementing them as jscript function. - This does not yet allow host properties to appear and disappear without notifications. This is a limitation of jscript's `dispex.c` (not the interface), which will need to be tweaked before we use new bindings for objects that require it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6029

3 12

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) July 9, 2024

July 9, 2024

Hans is correct. I have a computer that is part of the AD domain, and before logging into the domain GetUserNameEx(3) returns error 1332 (ERROR_NONE_MAPPED). After entering the domain GetUserNameEx(3) returns name that is equal to the displayName field in the LDAP database. Behaviour is the same for Windows 7 and Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75556

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Hans Leidekker (＠hans) July 9, 2024

July 9, 2024

Can you add a test case for this in dlls/secur32/tests/secur32.c? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75555

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) July 9, 2024

July 9, 2024

> It seems that the Windows machine needs to be joined to a Windows domain for this call to return something sensible. That's... weird, because it doesn't seem to be the case with my Windows installations, nor do Microsoft's docs specify this. (See [https://learn.microsoft.com/en-us/windows/win32/api/secext/nf-secext-getuse…) > Do you have an application that depends [on] this? Yes, I do. It's a game modification called "[OneShot: Fading Memory](https://store.steampowered.com/app/1569440/OneShot_Fading_Memory/)", which I am one of the developers of. It has been released two years ago and has always relied on the GetUserNameEx method. We've received no bug reports related to the game querying the player's name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75551

1 0

[PATCH 0/8] MR6028: Cmd engine rewrite (part XVIII)
by eric pouech (＠epo) July 9, 2024

July 9, 2024

This is part XVIII of cmd engine rewrite. It mainly focuses on setting the expected return code for some builtin functions. Includes also a fix for pipe inside a redirection (spotted by the added tests). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6028

2 8

[PATCH v2 0/2] MR6014: winhttp/tests: Add some tests for querying string options with NULL buffer.
by Nikolay Sivov (＠nsivov) July 9, 2024

July 9, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: winhttp: Fix error handling when returning string options. winhttp/tests: Add some tests for querying string options with NULL buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6014

4 4

[PATCH v35 0/9] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) July 9, 2024

July 9, 2024

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v35: advapi32: Fake the SeLockMemoryPrivilege right in LsaEnumerateAccountRights. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 10

[PATCH 0/2] MR5987: ddraw/tests: Workaround some X11 ConfigureNotify event race condition.
by Rémi Bernon July 9, 2024

July 9, 2024

Somehow more likely to be triggered with https://gitlab.winehq.org/wine/wine/-/merge_requests/5970. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5987

3 4