August 2024 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR6169: comctl32: fixed first we check index then array access by index is safe
by Herman Semenov (＠GermanAizek) Oct. 21, 2024

Oct. 21, 2024

I think this PR changes will protect against situation if out-of-bounds access array. -- v2: comctl32: fixed first we check index then array access by index is safe https://gitlab.winehq.org/wine/wine/-/merge_requests/6169

6 8

[PATCH 0/1] MR6238: comdlg32: Add `const' qualifier
by Ruslan Garipov (＠ruslangaripov) Oct. 16, 2024

Oct. 16, 2024

No functional changes intended. Please, review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6238

4 5

[PATCH 0/1] MR5276: musl: Fix limiting the float precision in intermediates.
by Martin Storsjö Oct. 15, 2024

Oct. 15, 2024

musl itself expects to be configured to compile with either -ffloat-store or -fexcess-precision=standard - but when imported into Wine, those flags aren't used. This seems to be essential for getting reasonable precision from some math functions such as exp2() - without the expected precision truncation, the output value of exp2() can be off by as much as 0.2% in some cases. As Wine doesn't build the musl sources with those flags, use volatile to force storing/reloading floats in order to limit their intermediate precision, as musl expects. Only do this on i386 where this is known be required. This fixes https://bugs.winehq.org/show_bug.cgi?id=56372. Apparently this issue only appears when compiled with GCC; with Clang, this already works as expected. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5276

3 6

[PATCH v6 0/5] MR498: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. (#52105)
by Jinoh Kang (＠iamahuman) Oct. 3, 2024

Oct. 3, 2024

On Windows, \Device\NamedPipe\ is the root directory of the named pipe file system (NPFS), and can be used as RootDirectory to skip its path when accessing the NPFS namespace. --- **Note**: `subpath->str` may look hacky, but it's used to indicate trailing `\\`[^bks] and existing code already does it too: - `server/directory.c` checks `name->str`[^dir] to test if this is the last component. This is evident by the fact that changing it to `name->len` will lead to major regression. - `server/registry.c` has similar lookup logic.[^reg1][^reg2] [^bks]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^dir]: https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1… [^reg1]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> [^reg2]: <https://gitlab.winehq.org/wine/wine/-/blob/c64aa0006e4a33d755a57a693cd81dc1…> -- v6: server: Allow creating named pipes using \Device\NamedPipe\ as RootDirectory. server: Add stub lookup_name implementation for named_pipe_device_file_ops. server: Pass the object subpath to open_file instead of rejecting it. server: Inline open_named_object() call in open_file_object handler. ntdll/tests: Test opening a named pipe with \Device\NamedPipe\ as RootDirectory. https://gitlab.winehq.org/wine/wine/-/merge_requests/498

4 11

[PATCH 0/2] MR3421: win32u: Fix clip_fullscreen_window for Deus Ex
by Zsolt Vadász Oct. 3, 2024

Oct. 3, 2024

These changes fix the camera rotation for Deus Ex. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3421

2 7

[PATCH v4 0/9] MR6107: winewayland: Support GL/VK rendering in child windows
by Alexandros Frantzis (＠afrantzis) Sept. 25, 2024

Sept. 25, 2024

At the moment GL/VK content can only be presented in top-level windows, since child windows are not backed by Wayland surfaces. This MR adds support for such scenarios, in a few gradual steps: 1. Create Wayland (sub)surfaces for all child windows, anchoring them to their parent surface, which may also be a child window surface (i.e., we support GL/VK in nested child windows). This approach works, but it pollutes the compositor with mostly unused, and possibly nested (sub)surfaces. We will deal with this later in the MR. 2. Ensure that the child window (sub)surfaces are properly updated and reconfigured, and support WS_POPUP <-> WS_CHILD style changes (reparenting etc). 3. In the second to last commit, improve efficiency by creating (sub)surfaces only for the child windows needed by GL/VK, and anchor them directly to the parent toplevel. This removes (sub)surface bloat and unnecessary nesting, the trade-off being some extra complexity when dealing with updates. 4. Finally improve the display of GDI content along with accelerated content. Note that this MR doesn't clip GL/VK child window contents at the moment. The subsurface mechanism introduced in this MR could also handle other kinds of windows in the future, for example display and properly position transient windows, menus etc. -- v4: winewayland: Create Wayland surfaces for child windows on demand. winewayland: Ensure parent surface contents for accelerated windows. winewayland: Support Wayland surface role changes. win32u: Update children window state when the parent state changes. winewayland: Post WM_WAYLAND_CONFIGURE outside of the surface lock. winewayland: Use weak references for parent wayland_surfaces. winewayland: Handle subsurface reconfiguration. winewayland: Create subsurfaces for child windows. winewayland: Store all window rects in wayland_win_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/6107

4 20

[PATCH 0/1] MR6373: mfplat: Seek byte stream to the start for URL hint detection.
by Rémi Bernon Sept. 18, 2024

Sept. 18, 2024

Some tests reuse the same MP4 stream and are currently passing only because we have the generic byte stream handler fallback. They pass on Windows too, so I'm assuming the stream is seeked before looking for the hints. We could also very well remove the position restore because the media sources are rewinding the stream later too, but I've kept it like it was. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6373

2 6

[PATCH v9 0/2] MR2875: shell32: add support for balloon icon copying
by Sergei Chernyadyev (＠Cherser-s) Sept. 16, 2024

Sept. 16, 2024

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v9: shell32: add support for balloon icon copying shell32: refactor notify_icon to allow copying multiple icons https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

3 12

[PATCH 0/1] MR5787: winevulkan: Use an internal NtUser call to retrieve a GPU LUID.
by Rémi Bernon Sept. 13, 2024

Sept. 13, 2024

Avoid taking the display_device_init mutex outside of win32u. Similar to https://gitlab.winehq.org/wine/wine/-/merge_requests/5786, although this one doesn't cause any problems as far as I know. Still makes things simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5787

2 6

[PATCH 0/10] MR4201: widl: Cleanup and simplify expressions.
by Rémi Bernon Sept. 13, 2024

Sept. 13, 2024

Some cleanup for expressions, sanitizing the structure a bit especially for abstract operations with multiple args. I also found out about named bison variables, implicit (as `$token` referring to `token`), or explicit (as `$name` referring to `token[name]`). I think it would make the rules much more readable so I started using them here. My plan is to add them progressively to the rules, unless there's some good reason not to (like idk how portable they are, if that's something we should be worried about). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4201

2 21