August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

On Sat Aug 31 16:30:43 2024 +0000, Elizabeth Figura wrote: > Sorry it's taken me so long to get to this, but 3/4 seems suspicious. > I'd think BroadcastDeviceNotification() [or SendMessageNotify() or > whatever it calls internally] should be making a copy of the message > data itself. Are we not doing that? Should we be doing that instead? Yeah, I might be wrong here. A quick inspection of the code does suggest that we do make copies in `(un)pack_message`. MSDN's documentation for `SendNotifyMessageW`\[1\] warned that messages containing pointers could not be sent as they would result in access to a dangling reference, which is what prompted me to write 3/4. However, `DEV_BROADCAST_DEVICEINTERFACE` messages don't contain any pointers, so this doesn't apply here. \[1\] https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-send… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80621

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

> I don't think adding custom structs is justified at this point, especially as it requires rewriting large parts of the code in multiple modules at the same time. `wine/dbt.h` doesn't really _add_ a new struct. It merely makes `struct device_notification_details` a common public declaration. The struct is currently [a private def in `dlls/sechost/service.c`](https://gitlab.winehq.org/wine/wine/-/blob/055bddab4f14a1f73e887b88b86408d654382c2b/dlls/sechost/service.c?page=2#L1976), and needs to be defined again for any component that utilizes `I_ScRegisterDeviceNotification`. [`dlls/user32/input.c` seems to be the only place where it gets used ATM](https://gitlab.winehq.org/wine/wine/-/blob/055bddab4f14a1f73e887b88b86…, and the motivation behind shifting the definition to a common header was to preempt the possibility of the struct's definition accidentally diverging in the future. > However, passing process-private handles around ~~to other processes~~ and later getting them back looks wrong. What happens if you register for notification on a handle then close it right away? Does the notification keep firing with the old handle value? It seem surprising and it would be a nice thing to test for instance. Yeah, this is something I've been curious about as well. I suppose one way to test this would be to also add an implementation for`IoReportTargetDeviceChange` (thanks @zfigura!) to this MR, and test `RegisterDeviceNotification`'s behavior in `dlls/ntoskrnl.exe/tests/driver_pnp.c`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80620

1 0

[PATCH 0/1] MR6422: include: Add ISelectionProvider2 definition in uiautomationcore.idl
by Biswapriyo Nath (＠Biswa96) Aug. 31, 2024

Aug. 31, 2024

Required for https://github.com/juce-framework/JUCE/blob/8.0.1/modules/juce_gui_basics/n… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6422

3 2

[PATCH v12 0/6] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v12: bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes and BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add unit tests for BluetoothSdpGetContainerElementData and BluetoothSdpGetElementData. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 6

[PATCH 0/6] MR6360: d3dx9: Beginning of pixel format handling changes.
by Connor McAdams (＠cmcadams) Aug. 30, 2024

Aug. 30, 2024

This is the initial set of patches for handling new pixel format types. I've pushed a branch [here](https://gitlab.winehq.org/cmcadams/wine/-/commits/WIP/d3dx-shared-sou… containing the rest of my current patches if additional context would be useful, the new format handling patches end with `ed7022a0838b346f4fa2b229ce7e8e6b8ebc2244`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6360

3 24

Re: [PATCH v2 0/3] MR6407: include: Updated a few gdiplus types. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2024

Aug. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6407

1 0

Re: [PATCH v2 0/1] MR6412: winecoreaudio: Set the synth volume to the greater of the left and right channels. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2024

Aug. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6412

1 0

Re: [PATCH v2 0/1] MR6415: mscoree: Update Wine Mono to 9.3.0. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2024

Aug. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6415

1 0

Re: [PATCH v2 0/1] MR6416: secur32: Ensure unixlib function tables and enum stay in sync. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2024

Aug. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6416

1 0

Re: [PATCH v2 0/1] MR6414: secur32: Simplify the cred_enabled_protocols logic slightly. - approved
by Alexandre Julliard (＠julliard) Aug. 30, 2024

Aug. 30, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6414

1 0