August 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR5756: comdlg32: Fix a few issues with color dialog
by Fabian Maurer (＠DarkShadow44) Sept. 2, 2024

Sept. 2, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5756

3 14

[PATCH 0/2] MR6421: d3d10/effect: Rename some variable array fields to better reflect their meaning.
by Nikolay Sivov (＠nsivov) Sept. 2, 2024

Sept. 2, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6421

3 3

[PATCH v2 0/1] MR6409: vkd3d: Import upstream release 1.13.
by Alexandre Julliard (＠julliard) Sept. 2, 2024

Sept. 2, 2024

-- v2: vkd3d: Import upstream release 1.13. https://gitlab.winehq.org/wine/wine/-/merge_requests/6409

3 2

[PATCH 0/6] MR6396: win32u: Stop setting DPI_PER_MONITOR_AWARE by default.
by Rémi Bernon Sept. 2, 2024

Sept. 2, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6396

3 10

[PATCH v12 0/2] MR5761: comclt32: Allow ctrl-tab and tab hotkeys for propsheets
by Fabian Maurer (＠DarkShadow44) Sept. 2, 2024

Sept. 2, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56103 -- v12: comclt32: Allow hotkeys for propsheet navigation. comctl32/tests: Add test for propsheet hotkey navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5761

3 4

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Rémi Bernon Aug. 31, 2024

Aug. 31, 2024

> If you're referring to the new RPC structs, I understand. That being said, my one concern is whether stuffing the file path into `dbch_data` could potentially break some code out there that uses `dbch_size` to guess which event is being sent (something like `if (n->dbch_size == (sizeof(DEV_BROADCAST_HANDLE) + sizeof(BTH_RADIO_IN_RANGE)`). It is an extremely stupid way to check for the event, but I'm not sure whether someone doing this can be safely discounted. I'll write some test code to see if this can be done on Windows to begin with. But as far as I understand, as `plugplay_send_event` is completely non-standard, these structs are only ever sent internally? So you don't really need to bother about abusing some fields or size for the internal notification, you even considered using custom structs which you would convert back and forth on both sides. Simply put whatever you need in the DEV_BROADCAST_HANDLE struct you send, using any unused field, or some other way, to put the device path in it if you need that, and just make sure you fix it up to a correct DEV_BROADCAST_HANDLE struct before calling the notification callback? Although I don't feel like it's even worth it you could even use a custom DEV_BROADCAST_HDR based struct, or extend DEV_BROADCAST_HANDLE with a custom derived struct which has an explicit device path, for the internal messages. I just don't think you need to change the DEV_BROADCAST_HDR base, or change the DEV_BROADCAST_DEVICEINTERFACE code in any significant way for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80622

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

On Sat Aug 31 16:30:43 2024 +0000, Elizabeth Figura wrote: > Sorry it's taken me so long to get to this, but 3/4 seems suspicious. > I'd think BroadcastDeviceNotification() [or SendMessageNotify() or > whatever it calls internally] should be making a copy of the message > data itself. Are we not doing that? Should we be doing that instead? Yeah, I might be wrong here. A quick inspection of the code does suggest that we do make copies in `(un)pack_message`. MSDN's documentation for `SendNotifyMessageW`\[1\] warned that messages containing pointers could not be sent as they would result in access to a dangling reference, which is what prompted me to write 3/4. However, `DEV_BROADCAST_DEVICEINTERFACE` messages don't contain any pointers, so this doesn't apply here. \[1\] https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-send… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80621

1 0

Re: [PATCH v32 0/4] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

> I don't think adding custom structs is justified at this point, especially as it requires rewriting large parts of the code in multiple modules at the same time. `wine/dbt.h` doesn't really _add_ a new struct. It merely makes `struct device_notification_details` a common public declaration. The struct is currently [a private def in `dlls/sechost/service.c`](https://gitlab.winehq.org/wine/wine/-/blob/055bddab4f14a1f73e887b88b86408d654382c2b/dlls/sechost/service.c?page=2#L1976), and needs to be defined again for any component that utilizes `I_ScRegisterDeviceNotification`. [`dlls/user32/input.c` seems to be the only place where it gets used ATM](https://gitlab.winehq.org/wine/wine/-/blob/055bddab4f14a1f73e887b88b86…, and the motivation behind shifting the definition to a common header was to preempt the possibility of the struct's definition accidentally diverging in the future. > However, passing process-private handles around ~~to other processes~~ and later getting them back looks wrong. What happens if you register for notification on a handle then close it right away? Does the notification keep firing with the old handle value? It seem surprising and it would be a nice thing to test for instance. Yeah, this is something I've been curious about as well. I suppose one way to test this would be to also add an implementation for`IoReportTargetDeviceChange` (thanks @zfigura!) to this MR, and test `RegisterDeviceNotification`'s behavior in `dlls/ntoskrnl.exe/tests/driver_pnp.c`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315#note_80620

1 0

[PATCH 0/1] MR6422: include: Add ISelectionProvider2 definition in uiautomationcore.idl
by Biswapriyo Nath (＠Biswa96) Aug. 31, 2024

Aug. 31, 2024

Required for https://github.com/juce-framework/JUCE/blob/8.0.1/modules/juce_gui_basics/n… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6422

3 2

[PATCH v12 0/6] MR6402: bluetoothapis: Implement basic SDP methods.
by Vibhav Pant (＠vibhavp) Aug. 31, 2024

Aug. 31, 2024

The MR adds implementations (+ a few tests) for the following methods in `bluetoothapis.h`: * `BluetoothSdpEnumAttributes` * `BluetoothSdpGetContainerElementData` * `BluetoothSdpGetElementData` * `BluetoothSdpGetAttributeValue` -- v12: bluetoothapis/tests: Add tests for BluetoothSdpEnumAttributes and BluetoothSdpGetAttributeValue. bluetoothapis: Implement BluetoothSdpGetAttributeValue. bluetoothapis/tests: Add unit tests for BluetoothSdpGetContainerElementData and BluetoothSdpGetElementData. bluetoothapis: Implement BluetoothSdpEnumAttributes. bluetoothapis: Implement BluetoothSdpGetContainerElementData. bluetoothapis: Implement BluetoothSdpGetElementData. https://gitlab.winehq.org/wine/wine/-/merge_requests/6402

2 6