August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate.
by Huw Davies (＠huw) Aug. 15, 2024

Aug. 15, 2024

Looks like Windows' `NdrInterfacePointerBufferSize()` was buggy. Sure, let's live with this workaround. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117#note_78832

1 0

[PATCH 0/5] MR6287: mshtml: Add support for remaining node prototype objects.
by Jacek Caban (＠jacek) Aug. 15, 2024

Aug. 15, 2024

This gets prototype/constructor hierarchy right, but there is more work needed to get it fully right (the same is true for some other objects as well, to lesser extend). Comment and document fragment nodes should not expose element/document properties, attribute nodes should be actual nodes and legacy unknown elements seem to be some parser quirk (so `use_generic` is not exactly right even in legacy modes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6287

3 6

[PATCH 0/2] MR6225: ntdll: Populate the ARM64 processor ID register registry keys.
by Billy Laws (＠bylaws) Aug. 15, 2024

Aug. 15, 2024

Takes advantage of linux's ID register emulation. The msr instruction is manually assembled to support older compilers and those that disallow reading e.g. SVE ID registers if unsupported by the target, even though they RAZ if unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

5 17

Re: [PATCH v3 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Huw Davies (＠huw) Aug. 15, 2024

Aug. 15, 2024

Huw Davies (@huw) commented about dlls/wineoss.drv/ossmidi.c: > BOOL bEnabled; > MIDIOPENDESC midiDesc; > BYTE runningStatus; > + BYTE dev; /* OSS dev id. */ ```suggestion:-0+0 int dev; /* OSS device */ ``` Also, please change the commit message to something like: ``` wineoss: Store the OSS device in midi_dest. This avoids having to calculate the OSS device from the Windows dev_id. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251#note_78829

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } Please rename the patch subject to " comctl32/tests: Add LVM_GETNEXTITEM test." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78828

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ > + > + HWND hwnd; > + DWORD r; > + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0); > + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0); > + > + hwnd = create_listview_control(LVS_REPORT); > + insert_item(hwnd, 0); > + insert_item(hwnd, 1); I don't think you need three items. Try one or two. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78827

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ Let's remove this comment. The test function name already indicates that it's for LVM_GETNEXTITEM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78826

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > + rbi.cyMinChild = rbi.cxMinChild; > + rbi.hwndChild = build_toolbar(1, hRebar); > + rbi.fStyle = RBBS_USECHEVRON | RBBS_NOGRIPPER; > + SendMessageA(hRebar, RB_INSERTBANDA, 0, (LPARAM)&rbi); > + SendMessageA(hRebar, RB_INSERTBANDA, 1, (LPARAM)&rbi); > + > + SetRectEmpty(&g_chevron_rect); > + SendMessageA(hRebar, RB_PUSHCHEVRON, 0, 0); > + ok(!IsRectEmpty(&g_chevron_rect), "Unexpected empty chevron rect\n"); > + > + /* increase band width to make it more then ideal value to hide chevron */ > + rbi.fMask = RBBIM_SIZE; > + rbi.cx = rbi.cx + 1; > + SendMessageA(hRebar, RB_SETBANDINFOA, 0, (LPARAM)&rbi); > + > + g_chevron_rect.left = g_chevron_rect.right = g_chevron_rect.top = g_chevron_rect.bottom = 1; You can use SetRect(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78825

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > #undef X > } > > +static void test_chevron(void) > +{ > + HWND hRebar; > + REBARBANDINFOA rbi; > + /* the gap between the child and the next band */ > + enum { REBAR_POST_CHILD = 4 }; > + > + hRebar = create_rebar_control(0); > + rbi.cbSize = REBARBANDINFOA_V6_SIZE; > + rbi.fMask = RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_IDEALSIZE | RBBIM_SIZE | RBBIM_STYLE; > + rbi.cxIdeal = 128; > + rbi.cx = rbi.cxIdeal + REBAR_POST_CHILD - 1; Is REBAR_POST_CHILD needed? Even if you do, it shouldn't be an enum. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78824

1 0

[PATCH v2 0/1] MR6248: winewayland: Add missing default surface fallback in WindowPosChanging().
by Aida Jonikienė Aug. 15, 2024

Aug. 15, 2024

This fixes a blank window content issue that happens even with basic Wine programs. Fixes: b9879d5adc1 ("winewayland: Remove now unnecessary WindowPosChanging checks.") -- v2: winewayland: Add missing default surface fallback in WindowPosChanging(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6248

3 11