August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Ivan Rozhuk (＠Ivan_83) Aug. 15, 2024

Aug. 15, 2024

On Thu Aug 15 10:21:21 2024 +0000, Huw Davies wrote: > ```suggestion:-0+0 > int dev; /* OSS device */ > ``` > Also, please change the commit message to something like: > ``` > wineoss: Store the OSS device in midi_dest. > This avoids having to calculate the OSS device from the Windows dev_id. > ``` Is is `int` only on query synth/midi info, and it is always `uint8_t` in synth/midi message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251#note_78852

1 0

[PATCH v12 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) Aug. 15, 2024

Aug. 15, 2024

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v12: comctl32/tests: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

3 2

[PATCH v10 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) Aug. 15, 2024

Aug. 15, 2024

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v10: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 11

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) Aug. 15, 2024

Aug. 15, 2024

On Thu Aug 15 10:05:31 2024 +0000, Zhiyi Zhang wrote: > You can use SetRect(). Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78837

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) Aug. 15, 2024

Aug. 15, 2024

On Thu Aug 15 10:05:31 2024 +0000, Zhiyi Zhang wrote: > Is REBAR_POST_CHILD needed? Even if you do, it shouldn't be an enum. Yes, sure. It's involved in child rect calculation just before showing or hiding chevron. The desicion depends on comparing child rect width and cxIdeal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78836

1 0

Re: [PATCH v3 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate. - approved
by Huw Davies (＠huw) Aug. 15, 2024

Aug. 15, 2024

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117

1 0

Re: [PATCH v3 0/3] MR5117: rpcrt4/tests: Allocate stub buffers with NdrOleAllocate.
by Huw Davies (＠huw) Aug. 15, 2024

Aug. 15, 2024

Looks like Windows' `NdrInterfacePointerBufferSize()` was buggy. Sure, let's live with this workaround. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5117#note_78832

1 0

[PATCH 0/5] MR6287: mshtml: Add support for remaining node prototype objects.
by Jacek Caban (＠jacek) Aug. 15, 2024

Aug. 15, 2024

This gets prototype/constructor hierarchy right, but there is more work needed to get it fully right (the same is true for some other objects as well, to lesser extend). Comment and document fragment nodes should not expose element/document properties, attribute nodes should be actual nodes and legacy unknown elements seem to be some parser quirk (so `use_generic` is not exactly right even in legacy modes). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6287

3 6

[PATCH 0/2] MR6225: ntdll: Populate the ARM64 processor ID register registry keys.
by Billy Laws (＠bylaws) Aug. 15, 2024

Aug. 15, 2024

Takes advantage of linux's ID register emulation. The msr instruction is manually assembled to support older compilers and those that disallow reading e.g. SVE ID registers if unsupported by the target, even though they RAZ if unsupported. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6225

5 17

Re: [PATCH v3 0/1] MR6251: wineoss.drv: Fix work with synth devices
by Huw Davies (＠huw) Aug. 15, 2024

Aug. 15, 2024

Huw Davies (@huw) commented about dlls/wineoss.drv/ossmidi.c: > BOOL bEnabled; > MIDIOPENDESC midiDesc; > BYTE runningStatus; > + BYTE dev; /* OSS dev id. */ ```suggestion:-0+0 int dev; /* OSS device */ ``` Also, please change the commit message to something like: ``` wineoss: Store the OSS device in midi_dest. This avoids having to calculate the OSS device from the Windows dev_id. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6251#note_78829

1 0