August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } Please rename the patch subject to " comctl32/tests: Add LVM_GETNEXTITEM test." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78828

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ > + > + HWND hwnd; > + DWORD r; > + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0); > + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0); > + > + hwnd = create_listview_control(LVS_REPORT); > + insert_item(hwnd, 0); > + insert_item(hwnd, 1); I don't think you need three items. Try one or two. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78827

1 0

Re: [PATCH v16 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > CoUninitialize(); > } > > +static void test_LVM_GETNEXTITEM(void) > +{ > + /* LVM_GETNEXTITEM */ Let's remove this comment. The test function name already indicates that it's for LVM_GETNEXTITEM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_78826

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > + rbi.cyMinChild = rbi.cxMinChild; > + rbi.hwndChild = build_toolbar(1, hRebar); > + rbi.fStyle = RBBS_USECHEVRON | RBBS_NOGRIPPER; > + SendMessageA(hRebar, RB_INSERTBANDA, 0, (LPARAM)&rbi); > + SendMessageA(hRebar, RB_INSERTBANDA, 1, (LPARAM)&rbi); > + > + SetRectEmpty(&g_chevron_rect); > + SendMessageA(hRebar, RB_PUSHCHEVRON, 0, 0); > + ok(!IsRectEmpty(&g_chevron_rect), "Unexpected empty chevron rect\n"); > + > + /* increase band width to make it more then ideal value to hide chevron */ > + rbi.fMask = RBBIM_SIZE; > + rbi.cx = rbi.cx + 1; > + SendMessageA(hRebar, RB_SETBANDINFOA, 0, (LPARAM)&rbi); > + > + g_chevron_rect.left = g_chevron_rect.right = g_chevron_rect.top = g_chevron_rect.bottom = 1; You can use SetRect(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78825

1 0

Re: [PATCH v11 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Zhiyi Zhang (＠zhiyi) Aug. 15, 2024

Aug. 15, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/rebar.c: > #undef X > } > > +static void test_chevron(void) > +{ > + HWND hRebar; > + REBARBANDINFOA rbi; > + /* the gap between the child and the next band */ > + enum { REBAR_POST_CHILD = 4 }; > + > + hRebar = create_rebar_control(0); > + rbi.cbSize = REBARBANDINFOA_V6_SIZE; > + rbi.fMask = RBBIM_CHILD | RBBIM_CHILDSIZE | RBBIM_IDEALSIZE | RBBIM_SIZE | RBBIM_STYLE; > + rbi.cxIdeal = 128; > + rbi.cx = rbi.cxIdeal + REBAR_POST_CHILD - 1; Is REBAR_POST_CHILD needed? Even if you do, it shouldn't be an enum. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6075#note_78824

1 0

[PATCH v2 0/1] MR6248: winewayland: Add missing default surface fallback in WindowPosChanging().
by Aida Jonikienė Aug. 15, 2024

Aug. 15, 2024

This fixes a blank window content issue that happens even with basic Wine programs. Fixes: b9879d5adc1 ("winewayland: Remove now unnecessary WindowPosChanging checks.") -- v2: winewayland: Add missing default surface fallback in WindowPosChanging(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6248

3 11

[PATCH v2 0/4] MR6278: odbccp32: Respect config mode in SQLGet/WritePrivateProfileString().
by Hans Leidekker (＠hans) Aug. 15, 2024

Aug. 15, 2024

-- v2: odbccp32: Handle NULL DSN in SQLValidDSN(). odbccp32/tests: Get rid of a workaround for XP. odbccp32: Use wide character string literals. odbccp32: Respect config mode in SQLGet/WritePrivateProfileString(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6278

2 4

[PATCH 0/3] MR6278: odbccp32: Respect config mode in SQLGet/WritePrivateProfileString().
by Hans Leidekker (＠hans) Aug. 15, 2024

Aug. 15, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6278

3 14

[PATCH 0/1] MR6285: shell32: Allow FindExecutables to find unix files.
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 15, 2024

Aug. 15, 2024

This fixes one of the regression with ShellExecute when using a full patch and an executable without an extension. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6285

3 2

[PATCH 0/1] MR6284: odbc32: Connection string keywords are case insensitive.
by Hans Leidekker (＠hans) Aug. 15, 2024

Aug. 15, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6284

2 1