August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Alfred Agrell (＠Alcaro) Aug. 14, 2024

Aug. 14, 2024

On Wed Aug 14 17:21:18 2024 +0000, Elizabeth Figura wrote: > 3/3 still needs to be fixed up to 1/3 where the class is introduced, > including the actxprxy parts. > There's also a whitespace error introduced in 2/3. > Also, I'm just now noticing... > > ``` > > +HRESULT __RPC_STUB IEnumObjects_Next_Stub(IEnumObjects *This, ULONG > celt, REFIID riid, void **rgelt, ULONG *pceltFetched) > > +{ > > + HRESULT hr; > > + TRACE("(%p)->(%ld, %p, %p, %p)\n", This, celt, > debugstr_guid(riid), rgelt, pceltFetched); > > + *pceltFetched = 0; > > + hr = IEnumObjects_Next(This, celt, riid, rgelt, pceltFetched); > > + if (hr == S_OK) *pceltFetched = celt; > > + return hr; > > +} > > ``` > The "*pceltFetched = celt" line looks very wrong, and I don't think that > line should be necessary at all. It was copied from IEnumShellItems, but > that also looks wrong. I can't see anything obviously wrong in v8 3/3(*). Do you want 3/3 merged into 1/3? And yeah, that looks strange. Not exactly wrong - S_OK means it fetched as many items as it asked for, so that'll just write the value that's already there (unless the Next impl is buggy or something) - but certainly strange. Yeah, better remove it until and unless proven necessary. (*) actually 3/4, but that last one's a merge commit so let's pretend it doesn't exist. Rebase and remove it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78711

1 0

[PATCH v4 0/5] MR6260: mshtml: Misc improvements and fixes.
by Gabriel Ivăncescu Aug. 14, 2024

Aug. 14, 2024

-- v4: mshtml/tests: Accept rare return value from ReportResult on native. mshtml: Don't process tasks in message loop during parse complete mshtml: Implement EmulateIE* modes for X-UA-Compatible. mshtml: Don't return default ports from location.host in IE10+ modes. mshtml: Avoid calling remove_target_tasks needlessly. https://gitlab.winehq.org/wine/wine/-/merge_requests/6260

2 8

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) Aug. 14, 2024

Aug. 14, 2024

On Wed Aug 14 16:29:53 2024 +0000, Kevin Martinez wrote: > Ok, was just following the example of other entries. Yeah, it's unfortunately one of those things that's been cargo-culted, but I think it's better to avoid it going forward. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78697

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) Aug. 14, 2024

Aug. 14, 2024

> Also, what version of Windows are you seeing vend this class from shell32? My Windows 10 vends it from windows.storage.dll. FWIW, I do see this vended from shell32 in Windows 7. It's probably better to match more recent Windows here, though I'm not sure if it's worth caring. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78695

1 0

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) Aug. 14, 2024

Aug. 14, 2024

3/3 still needs to be fixed up to 1/3 where the class is introduced, including the actxprxy parts. There's also a whitespace error introduced in 2/3. Also, I'm just now noticing... > ``` > +HRESULT __RPC_STUB IEnumObjects_Next_Stub(IEnumObjects *This, ULONG celt, REFIID riid, void **rgelt, ULONG *pceltFetched) > +{ > + HRESULT hr; > + TRACE("(%p)->(%ld, %p, %p, %p)\n", This, celt, debugstr_guid(riid), rgelt, pceltFetched); > + *pceltFetched = 0; > + hr = IEnumObjects_Next(This, celt, riid, rgelt, pceltFetched); > + if (hr == S_OK) *pceltFetched = celt; > + return hr; > +} > ``` The "*pceltFetched = celt" line looks very wrong, and I don't think that line should be necessary at all. It was copied from IEnumShellItems, but that also looks wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78694

1 0

[PATCH v2 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon Aug. 14, 2024

Aug. 14, 2024

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- v2: winebus.sys: Read vendor/product/serial strings from the usb subsystem. winebus.sys: Always parse uevent PRODUCT= line on input subsystem. winebus.sys: Add devtype parameter to get_device_subsystem_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

3 4

[PATCH 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon Aug. 14, 2024

Aug. 14, 2024

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

4 10

[PATCH v7 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) Aug. 14, 2024

Aug. 14, 2024

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v7: actxprxy: Added IEnumObjects_Next_Proxy shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

2 7

[PATCH 0/1] MR6272: riched20: Release IME input context when done using it.
by Zhiyi Zhang (＠zhiyi) Aug. 14, 2024

Aug. 14, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6272

3 2

[PATCH v2 0/10] MR6273: win32u: Use window rects structs in more functions.
by Rémi Bernon Aug. 14, 2024

Aug. 14, 2024

-- v2: win32u: Keep a window_rects struct in the WND structure. win32u: Pass a window_rects struct to calc_ncsize helper. win32u: Pass a window_rects struct from get_window_rects helper. win32u: Introduce new get_(client|window)_rect_rel helpers. win32u: Pass a window_rects struct to MoveWindowBits driver entry. win32u: Pass a window_rects struct to WindowPosChanging driver entry. win32u: Pass a window_rects struct to WindowPosChanged driver entry. win32u: Pass window_rects structs to create_window_surface. win32u: Use window_rects structs in apply_window_pos. win32u: Split driver side window bits move to a separate entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/6273

2 12