August 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR6226: mmdevapi: Implement control_GetSessionIdentifier / control_GetSessionInstanceIdentifier. - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2024

Aug. 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6226

1 0

Re: [PATCH v2 0/1] MR6224: mmdevapi: Unlock session in create_session_enumerator(). - approved
by Alexandre Julliard (＠julliard) Aug. 8, 2024

Aug. 8, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6224

1 0

[PATCH v2 0/1] MR2657: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth..
by Aleksey Komarov (＠q4a) Aug. 8, 2024

Aug. 8, 2024

General idea of this test is to show that a lot of factors influence the fog when transformed and untransformed vertex format was used: - Directly changing z and w (which is not equal in the corners). - Changing projection matrix that change z and w. - Using different programmable/ff vs/ps shader. - Using different depth bias. - Chaging depth in pixel shader (oDepth) may or may not affect to colors depending on the vendor implementation. - And various combinations of above. This gives `succ` in all cases on this configs: - Windows 10 with Radeon HD 8400 or Ivy Bridge GT1 (Intel HD Graphics). - Windows 7 with Radeon HD 6450. - Windows XP with GeForce Go 7300. -- v2: d3d9/tests: test table fog z vs rhw with shaders, depth bias, oDepth.. https://gitlab.winehq.org/wine/wine/-/merge_requests/2657

8 17

[PATCH 0/1] MR6234: win32u: Always use the dummy surface if a surface isn't needed.
by Rémi Bernon Aug. 8, 2024

Aug. 8, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57033 We don't need a surface when the drawing rect is empty, and it can even FPE if we use one. Release any previously created surface in this case and use the dummy surface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6234

1 1

[PATCH 0/5] MR6233: winex11: Fix systray docked icons display.
by Rémi Bernon Aug. 8, 2024

Aug. 8, 2024

And avoid triggering X11 errors with foreign windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6233

1 5

[PATCH 0/1] MR6232: ntdll: Use the module debug channel in virtual_map_builtin_module().
by Sven Baars (＠sbaars) Aug. 8, 2024

Aug. 8, 2024

Not sure if this is useful for anyone else, but this is the second time this warn would have saved me at least an hour. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6232

3 2

[PATCH 0/1] MR6205: d3dx9/effect: Return creator string from GetDesc().
by Nikolay Sivov (＠nsivov) Aug. 8, 2024

Aug. 8, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6205

4 3

[PATCH v3 0/9] MR6157: d3dx9: More miscellaneous fixes.
by Connor McAdams (＠cmcadams) Aug. 8, 2024

Aug. 8, 2024

-- v3: d3dx9: Validate filter argument in texture from file functions. d3dx9: Validate filter argument in D3DXLoadSurfaceFrom{Surface,FileInMemory,Memory}(). d3dx9: Validate filter argument in D3DXLoadVolumeFrom{Volume,FileInMemory,Memory}(). d3dx9: Further validate filter argument passed to D3DXFilterTexture(). d3dx9: Introduce helper function for retrieving the mip filter value in texture from file functions. d3dx9/tests: Add d3dx filter argument value tests. d3dx9: Return failure from D3DXLoadSurfaceFromMemory() if d3dx_load_pixels_from_pixels() fails. d3dx9: Return success in D3DXLoadSurfaceFromMemory() for multisampled destination surfaces. d3dx9/tests: Add tests for D3DXLoadSurfaceFromMemory() with a multisampled surface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6157

4 16

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) Aug. 8, 2024

Aug. 8, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) Let's change TREEVIEW_SendExpanding to return the return value from TREEVIEW_SendTreeviewNotify() so we don't to need negate the return value twice and it's more intuitive this way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78098

1 0

Re: [PATCH v4 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Zhiyi Zhang (＠zhiyi) Aug. 8, 2024

Aug. 8, 2024

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/treeview.c: > !(item->state & TVIS_EXPANDEDONCE)); > if (sendsNotifications) > { > - if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > - { > - TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > - return FALSE; > - } > + if (!TREEVIEW_SendExpanding(infoPtr, item, TVE_EXPAND)) > + { > + TRACE(" TVN_ITEMEXPANDING returned TRUE, exiting...\n"); > + return TRUE; This is the only changed line. Please avoid whitespace changes for other lines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6218#note_78097

1 0