September 2024 - Wine-GitLab

[PATCH v6 0/1] MR6300: Draft: wined3d: Don't reject blits coming from older CS thread.
by Aida Jonikienė Sept. 11, 2024

Sept. 11, 2024

I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures would be better like stated in the original change?) -- v6: wined3d: Don't reject blits coming from older command stream. https://gitlab.winehq.org/wine/wine/-/merge_requests/6300

2 2

Re: [PATCH v13 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by Jacek Caban (＠jacek) Sept. 11, 2024

Sept. 11, 2024

Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c: > { > blit_dc = *hdc; > blit_bitmap = *bitmap; > + > + if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) > + goto err; You could just return 0 here, which would allow you to simplify the code some more. Then you don't need the assignment above. And without that assignment, we could remove `blit_dc != *hdc` check from error handling path. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81916

1 0

[PATCH v3 0/5] MR6375: mshtml: Don't process tasks recursively.
by Gabriel Ivăncescu Sept. 11, 2024

Sept. 11, 2024

I kept the first patch (`Remember if timer was blocked.`) to avoid SetTimer on timers that weren't killed, mostly because it would apply on every task (which is likely to execute way faster than the ms granularity), not sure if it would skew the timer in such case. The other patches are split, with tests now showing why they're needed. Some places where wine-gecko callbacks into us and in which we call into external code need to be treated the same as a recursive task since it can end up in a message loop. I haven't supplied all of them from the previous MR, mostly because I didn't find a way to test those (e.g. show context menu, and the gecko async navigation). -- v3: mshtml: Don't process tasks recursively from Gecko events. mshtml: Don't process tasks recursively from script runners. mshtml: Don't process tasks recursively. mshtml: Remember if timer was blocked. mshtml: Don't cast to int to bound the timer. https://gitlab.winehq.org/wine/wine/-/merge_requests/6375

1 6

[PATCH 0/1] MR6476: sc: Return error value rather than 1 on failure.
by Owen Rudge (＠orudge) Sept. 11, 2024

Sept. 11, 2024

The Windows version of `sc.exe` returns the appropriate error value, which some applications rely on if programmatically executing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6476

2 1

[PATCH v2 0/5] MR6375: mshtml: Don't process tasks recursively.
by Gabriel Ivăncescu Sept. 11, 2024

Sept. 11, 2024

I kept the first patch (`Remember if timer was blocked.`) to avoid SetTimer on timers that weren't killed, mostly because it would apply on every task (which is likely to execute way faster than the ms granularity), not sure if it would skew the timer in such case. The other patches are split, with tests now showing why they're needed. Some places where wine-gecko callbacks into us and in which we call into external code need to be treated the same as a recursive task since it can end up in a message loop. I haven't supplied all of them from the previous MR, mostly because I didn't find a way to test those (e.g. show context menu, and the gecko async navigation). -- v2: mshtml: Don't send the notification from SuperNavigate if we're in nested mshtml: Don't process tasks recursively from handle_load. mshtml: Don't process tasks recursively from run_end_load. mshtml: Don't process tasks recursively. mshtml: Remember if timer was blocked. https://gitlab.winehq.org/wine/wine/-/merge_requests/6375

2 9

[PATCH 0/8] MR6475: Cmd engine rewrite (part XXIV)
by eric pouech (＠epo) Sept. 11, 2024

Sept. 11, 2024

This is part XXIV of cmd engine rewrite. This MR mainly tackles discrimination between builtin commands and external commands. For example: - 'echo foo' will always execute internal command 'ECHO', whereas 'echo.bat foo' will search of a runnable echo.bat in the %PATH%, and if no file is found run internal command 'ECHO' with '.bat foo' as parameters. - not to mention that 'CALL foo' and 'foo' have slightly different semantics wrt. searching. This MR: - adds a couple of more tests - cleans up the code: + introduce a couple of helpers to reduce function size + factorize in helpers common code, + let entry point functions for regular vs CALL case implement their own logic on top of common code, - added optimisation in search for external commands -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6475

3 9

[PATCH 0/1] MR6473: winex11: Get rid of the foreign parent window.
by Rémi Bernon Sept. 11, 2024

Sept. 11, 2024

I don't think it's useful anymore. Since fba938fa965a6ffd39d1a5e229c7f75b093a1a59 we don't try to move the embedded windows anymore, so they are always positioned where the host wants them to be. Then winex11 only has to deal with toplevel windows everywhere, and it makes the code simpler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6473

2 3

[PATCH 0/3] MR6474: dplayx: Merge DPLobby interfaces togther
by Alistair Leslie-Hughes (＠alesliehughes) Sept. 11, 2024

Sept. 11, 2024

This is the first pass in simplifying the Lobby interfaces together. The only real difference is some functions return Unicode vs Ascii data via a void pointer parameter. The next step will be merge these together. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6474

2 3

[PATCH v5 0/1] MR6300: Draft: wined3d: Don't reject cross-device blits.
by Aida Jonikienė Sept. 11, 2024

Sept. 11, 2024

I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures would be better like stated in the original change?) -- v5: wined3d: Don't reject blits coming from older CS thread. https://gitlab.winehq.org/wine/wine/-/merge_requests/6300

1 2

[PATCH v3 0/5] MR6468: dplayx, dpwsockx: EnumSessions() part 1
by Anton Baskanov (＠baskanov) Sept. 11, 2024

Sept. 11, 2024

-- v3: dpwsockx: Broadcast enumeration request in EnumSessions(). dpwsockx: Start listening for incoming TCP connections in EnumSessions(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6468

4 8