September 2024 - Wine-GitLab

[PATCH 0/1] MR6469: odbc32: Only call process_detach() if the unixlib was successfully loaded.
by Hans Leidekker (＠hans) Sept. 10, 2024

Sept. 10, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6469

2 1

Re: [PATCH v10 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info
by Jacek Caban (＠jacek) Sept. 10, 2024

Sept. 10, 2024

Jacek Caban (@jacek) commented about dlls/gdi32/emfdc.c: > if (!SelectObject( blit_dc, blit_bitmap )) goto err; > if (!BitBlt( blit_dc, 0, 0, bmp.bmWidth, bmp.bmHeight, *hdc, 0, 0, SRCCOPY )) > goto err; > + > + *hdc = blit_dc; > + *bitmap = blit_bitmap; > } > if (!GetDIBits( blit_dc, blit_bitmap, 0, INT_MAX, NULL, info, DIB_RGB_COLORS )) > goto err; We'd still leak if `GetDIBits` fails. We could move setting it after `GetDIBits` call, but it's maybe easier to just duplicate `GetDIBits` call inside if-else statement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81769

1 0

[PATCH v3 0/5] MR6452: winewayland: Move client surface to wayland_win_data.
by Rémi Bernon Sept. 10, 2024

Sept. 10, 2024

Preparation for https://gitlab.winehq.org/wine/wine/-/merge_requests/6323 -- v3: winewayland: Detach client surfaces when they are not visible. winewayland: Move client surface to wayland_win_data struct. winewayland: Pass hwnd to and return client rect from wayland_surface_get_client. winewayland: Introduce a new wayland_client_surface_attach helper. winewayland: Move wayland_surface_get_client to window.c. https://gitlab.winehq.org/wine/wine/-/merge_requests/6452

2 7

Re: [PATCH v2 0/3] MR6379: wined3d: Fixes for Vulkan device extensions.
by Jan Sikorski (＠jsikorski) Sept. 10, 2024

Sept. 10, 2024

Slight nit, I don't really like the 'append_structure' name - to me it suggests that the new element goes to the tail end of the list. Maybe 'push', 'add' or 'prepend' fits better? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6379#note_81760

1 0

[PATCH 0/5] MR6468: dplayx, dpwsockx: EnumSessions() part 1
by Anton Baskanov (＠baskanov) Sept. 10, 2024

Sept. 10, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6468

4 8

Re: [PATCH v2 0/4] MR6378: wined3d: Move FFP shader invalidation to wined3d_device_apply_stateblock(), part 2. - approved
by Jan Sikorski (＠jsikorski) Sept. 10, 2024

Sept. 10, 2024

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6378

1 0

[PATCH v4 0/10] MR5573: win32u: Implement vulkan child / other process surface rendering for winex11.
by Rémi Bernon Sept. 10, 2024

Sept. 10, 2024

I'm not completely sure about the mechanism, but I think it's simple enough to consider having that upstream now. This shows at least how we can leverage win32u surface changes to decide to switch surfaces on/off-screen and fallback to manual blitting. Having the surfaces on-screen makes sure they are presented as efficiently as possible, having them off-screen we use GDI blit to indirectly call XCopyArea and this will be suboptimal, probably with visible tearing, but hopefully not too common. -- v4: win32u: Use GDI blit to implement partial or other process presentation. winex11: Return an offscreen HDC from vulkan_surface_detach. win32u: Pass a HDC parameter to vulkan_surface_detach. winex11: Create a window surface even when there is client window. winex11: Also attach child client windows to their toplevel window. win32u: Make sure vulkan windows have a pixel format selected. win32u: Detach vulkan surfaces that aren't fully visible. win32u: Detach offscreen, child or vulkan surfaces for another process. win32u: Move vulkan surfaces to their new parent when reparenting. win32u: Introduce a new vulkan offscreen surfaces list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5573

6 20

[PATCH v4 0/5] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend.
by Rémi Bernon Sept. 10, 2024

Sept. 10, 2024

This introduces a new alternative FFmpeg-based implementation for the MF byte stream handlers, while keeping the current GStreamer-based as default. The new implementation can be enabled by setting the DWORD value: DisableGstByteStreamHandler = 1 in the HKCU\Software\Wine\MediaFoundation registry key. -- v4: mfsrcsnk: Stub byte stream handlers if demuxing is supported. winedmo: Export a new winedmo_demuxer_check function. winedmo: Link and initialize FFmpeg on load. winedmo: Load a unixlib on process attach. winedmo: Introduce a new internal DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/6442

1 6

[PATCH 0/1] MR6457: user32: Add CreateSyntheticPointerDevice stub.
by Gijs Vermeulen (＠gverm) Sept. 10, 2024

Sept. 10, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57141 Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6457

4 3

[PATCH v3 0/5] MR6442: winedmo: Introduce a new DLL as a MF FFmpeg backend.
by Rémi Bernon Sept. 10, 2024

Sept. 10, 2024

This introduces a new alternative FFmpeg-based implementation for the MF byte stream handlers, while keeping the current GStreamer-based as default. The new implementation can be enabled by setting the DWORD value: DisableGstByteStreamHandler = 1 in the HKCU\Software\Wine\MediaFoundation registry key. -- v3: mfsrcsnk: Stub byte stream handlers if demuxing is supported. winedmo: Export a new winedmo_demuxer_check function. winedmo: Link and initialize FFmpeg on load. winedmo: Load a unixlib on process attach. winedmo: Introduce a new internal DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/6442

2 9