September 2024 - Wine-GitLab

Re: [PATCH v2 0/8] MR6427: winevulkan: Introduce a vulkan object structure.
by Jacek Caban (＠jacek) Sept. 4, 2024

Sept. 4, 2024

On Wed Sep 4 17:57:07 2024 +0000, Jacek Caban wrote: > > being able to register wrappers from win32u makes things simpler > because we then don't need a manual function in winevulkan to register > the objects, and the winevulkan thunks can call directly into win32u functions. > So you plan to manage some of rbtree handling in winevulkan while others > in win32u? That doesn't sound like a clean separation if the only > benefit is avoiding a few manual thunks in winevulkan. It seems cleaner > to have all of that on one side (probably winevulkan, but win32u is also > a possibility). > win32u doesn't need client handles for anything else, unless I'm missing > something. It means that if we'd keep that in winevulkan, the only thing > from `vulkan_object` struct that's needed by win32u would be a handle > and a parent. The handle requires an unpleasant union and the parent > needs casting to be useful. That makes me question if `vulkan_object` is > really all that useful... Having a dedicated per-type structs would > avoid both of those. You needs it for both the device and instance, why > not have two or so more? Actually, depending on other design details, win32u may sometimes need client handle, but then the same concerns apply as against the host handle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6427#note_81106

1 0

Re: [PATCH v2 0/8] MR6427: winevulkan: Introduce a vulkan object structure.
by Jacek Caban (＠jacek) Sept. 4, 2024

Sept. 4, 2024

> being able to register wrappers from win32u makes things simpler because we then don't need a manual function in winevulkan to register the objects, and the winevulkan thunks can call directly into win32u functions. So you plan to manage some of rbtree handling in winevulkan while others in win32u? That doesn't sound like a clean separation if the only benefit is avoiding a few manual thunks in winevulkan. It seems cleaner to have all of that on one side (probably winevulkan, but win32u is also a possibility). win32u doesn't need client handles for anything else, unless I'm missing something. It means that if we'd keep that in winevulkan, the only thing from `vulkan_object` struct that's needed by win32u would be a handle and a parent. The handle requires an unpleasant union and the parent needs casting to be useful. That makes me question if `vulkan_object` is really all that useful... Having a dedicated per-type structs would avoid both of those. You needs it for both the device and instance, why not have two or so more? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6427#note_81105

1 0

[PATCH v8 0/1] MR6440: win32u: Implement NtGdiDdDDIEnumAdapters.
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 4, 2024

Sept. 4, 2024

used by native amd ags -- v8: win32u: Implement NtGdiDdDDIEnumAdapters. https://gitlab.winehq.org/wine/wine/-/merge_requests/6440

2 1

[PATCH 0/1] MR6444: winegstreamer: Append HEAACWAVEINFO extra bytes to AAC user data.
by Elizabeth Figura (＠zfigura) Sept. 4, 2024

Sept. 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6444

2 1

[PATCH 0/2] MR6436: d3d10/tests: Fully check matrix types.
by Nikolay Sivov (＠nsivov) Sept. 4, 2024

Sept. 4, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6436

3 3

[PATCH v10 0/1] MR6131: Extend bcp47langs.dll with GetUserLanguages
by Marius Schiffer (＠MariusSchiffer) Sept. 4, 2024

Sept. 4, 2024

This is an undocumented API used by some programs to fetch the user's selected languages. Example is Fusion360 (during its login process). Signature currently taken from here: https://stackoverflow.com/questions/63877075/what-is-the-right-way-to-get-t… (Maybe that stackoverflow answer is also why Fusion has implemented this...) -- v10: bcp47langs: Implement GetUserLanguages https://gitlab.winehq.org/wine/wine/-/merge_requests/6131

4 14

[PATCH v13 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect.
by Jacob Czekalla (＠JacobCzekalla) Sept. 4, 2024

Sept. 4, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- v13: comctl32/edit: Fix incorrect size for format rect when it is smaller than text. comctl32/tests: Add test for edit control format rect size. user32/edit: Fix incorrect size for format rect when it is smaller than text. user32/tests: Add test for edit control format rect size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

4 6

[PATCH v2 0/2] MR6401: uxtheme: Optimize drawing by avoiding unneeded TransparentBlt().
by Paul Gofman (＠gofman) Sept. 4, 2024

Sept. 4, 2024

-- v2: uxtheme: Try to avoid TransparentBlt() when possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/6401

4 7

[PATCH v5 0/10] MR6374: winewayland: Get rid of the wayland surface lock.
by Rémi Bernon Sept. 4, 2024

Sept. 4, 2024

(From https://gitlab.winehq.org/wine/wine/-/merge_requests/6323) -- v5: winewayland: Get rid of the window surface individual locks. winewayland: Introduce a new wayland_client_surface_create helper. winewayland: Get rid of window_surface reference from wayland_win_data. winewayland: Get rid of wayland_surface reference from window_surface. winewayland: Move window contents buffer to wayland_win_data struct. winewayland: Reset the buffer damage region immediately after copy. winewayland: Introduce a new get_window_surface_contents helper. winewayland: Introduce a new set_window_surface_contents helper. winewayland: Introduce a new ensure_window_surface_contents helper. winewayland: Post WM_WAYLAND_CONFIGURE outside of the surface lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/6374

1 11

[PATCH v4 0/10] MR6374: winewayland: Get rid of the wayland surface lock.
by Rémi Bernon Sept. 4, 2024

Sept. 4, 2024

(From https://gitlab.winehq.org/wine/wine/-/merge_requests/6323) -- v4: winewayland: Get rid of the window surface individual locks. winewayland: Introduce a new wayland_client_surface_create helper. winewayland: Get rid of window_surface reference from wayland_win_data. winewayland: Get rid of wayland_surface reference from window_surface. winewayland: Move window contents buffer to wayland_win_data struct. winewayland: Reset the buffer damage region immediately after copy. winewayland: Introduce a new get_window_surface_contents helper. winewayland: Introduce a new set_window_surface_contents helper. winewayland: Introduce a new ensure_window_surface_contents helper. winewayland: Post WM_WAYLAND_CONFIGURE outside of the surface lock. https://gitlab.winehq.org/wine/wine/-/merge_requests/6374

2 13