September 2024 - Wine-GitLab

[PATCH v3 0/1] MR6440: win32u: Implement NtGdiDdDDIEnumAdapters.
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 3, 2024

Sept. 3, 2024

used by native amd ags -- v3: win32u: Implement NtGdiDdDDIEnumAdapters. https://gitlab.winehq.org/wine/wine/-/merge_requests/6440

3 2

[PATCH 0/1] MR6439: include: Add UIA_TextAttributeIds constants in uiautomationclient.idl
by Biswapriyo Nath (＠Biswa96) Sept. 3, 2024

Sept. 3, 2024

Required for https://github.com/juce-framework/JUCE/blob/8.0.1/modules/juce_gui_basics/n… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6439

3 2

[PATCH v7 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Ostap Brehin (＠osbre) Sept. 3, 2024

Sept. 3, 2024

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppr… -- v7: include: Name parameters in LPPROGRESS_ROUTINE typedef https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

3 2

[PATCH v4 0/1] MR6440: win32u: Implement NtGdiDdDDIEnumAdapters.
by Etaash Mathamsetty (＠etaash.mathamsetty) Sept. 3, 2024

Sept. 3, 2024

used by native amd ags -- v4: win32u: Implement NtGdiDdDDIEnumAdapters. https://gitlab.winehq.org/wine/wine/-/merge_requests/6440

3 3

[PATCH v6 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Ostap Brehin (＠osbre) Sept. 3, 2024

Sept. 3, 2024

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppr… -- v6: include: Name parameters in LPPROGRESS_ROUTINE typedef https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

3 2

[PATCH v5 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Ostap Brehin (＠osbre) Sept. 3, 2024

Sept. 3, 2024

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppr… -- v5: include: Name parameters in LPPROGRESS_ROUTINE typedef https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

3 2

[PATCH v4 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Ostap Brehin (＠osbre) Sept. 3, 2024

Sept. 3, 2024

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppr… -- v4: include: Name parameters in LPPROGRESS_ROUTINE typedef https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

3 2

Re: [PATCH v3 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Alfred Agrell (＠Alcaro) Sept. 3, 2024

Sept. 3, 2024

On Tue Sep 3 17:43:38 2024 +0000, Ostap Brehin wrote: > Thank you! will update. > Regarding not devoting an entire line for each parameter - not sure if > that's possible due to enforced `max_line_length = 100` in > [.editorconfig](https://gitlab.winehq.org/wine/wine/-/blob/master/.editorconfig), > as then the new line size would be about 300 characters if that's the case. Or you can put 2-4 params per line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80919

1 0

Re: [PATCH v3 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Ostap Brehin (＠osbre) Sept. 3, 2024

Sept. 3, 2024

On Tue Sep 3 17:29:39 2024 +0000, Alex Henrie wrote: > If we're going to do this, can we please use `void *` instead of > `LPVOID`, name each parameter in snake_case, and not devote an entire > line to each parameter? Thank you! will update. Regarding not devoting an entire line for each parameter - not sure if that's possible due to enforced `max_line_length = 100` in [.editorconfig](https://gitlab.winehq.org/wine/wine/-/blob/master/.editorconfig), as then the new line size would be about 300 characters if that's the case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80917

1 0

Re: [PATCH v3 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef
by Alex Henrie (＠alexhenrie) Sept. 3, 2024

Sept. 3, 2024

Alex Henrie (@alexhenrie) commented about include/winbase.h: > * This one seems to be a Win32 only definition. It also is defined with > * WINAPI instead of CALLBACK in the windows headers. > */ > -typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE_INTEGER, > - LARGE_INTEGER, DWORD, DWORD, HANDLE, > - HANDLE, LPVOID); > +typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)( > + LARGE_INTEGER TotalFileSize, > + LARGE_INTEGER TotalBytesTransferred, > + LARGE_INTEGER StreamSize, > + LARGE_INTEGER StreamBytesTransferred, > + DWORD dwStreamNumber, > + DWORD dwCallbackReason, > + HANDLE hSourceFile, > + HANDLE hDestinationFile, > + LPVOID lpData If we're going to do this, can we please use `void *` instead of `LPVOID`, name each parameter in snake_case, and not devote an entire line to each parameter? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80916

1 0