January 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Akihiro Sagawa (＠sgwaki) Jan. 25, 2025

Jan. 25, 2025

@huw, I have been waiting for your review for several months. Do you have any concerns? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_92848

1 0

[PATCH v5 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) Jan. 25, 2025

Jan. 25, 2025

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: STATUS_SUCCESS or STATUS_USER_APC -- v5: ntdll: Fix the return value of NtDelayExecution. ntdll/tests: Add tests for NtDelayExecution and Sleep(Ex). https://gitlab.winehq.org/wine/wine/-/merge_requests/7169

2 2

[PATCH v4 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) Jan. 25, 2025

Jan. 25, 2025

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: STATUS_SUCCESS or STATUS_USER_APC -- v4: ntdll: Fix the return value of NtDelayExecution. ntdll/tests: Add tests for NtDelayExecution and Sleep(Ex). https://gitlab.winehq.org/wine/wine/-/merge_requests/7169

2 4

[PATCH v3 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) Jan. 25, 2025

Jan. 25, 2025

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: STATUS_SUCCESS or STATUS_USER_APC -- v3: ntdll: Fix the return value of NtDelayExecution. ntdll/tests: Add tests for NtDelayExecution and Sleep(Ex). https://gitlab.winehq.org/wine/wine/-/merge_requests/7169

4 25

[PATCH v3 0/7] MR7193: crypt32: A refcount fix and cert enumeraton improvement.
by Paul Gofman (＠gofman) Jan. 24, 2025

Jan. 24, 2025

-- v3: crypt32: Don't assert in Context_Release() on invalid refcount. crypt32/tests: Add a test for deleting and adding certs during enumeration. crypt32: Only remove cert from mem store list when deleting it. crypt32: Release existing cert context in add_cert_to_store(). crypt32: Don't try to release zero-refcount context in MemStore_addContext(). crypt32: Factor out memstore_free_context() function. crypt32: Release cert context in CertDeleteCertificateFromStore(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7193

3 10

Re: [PATCH v4 0/7] MR7193: crypt32: A refcount fix and cert enumeraton improvement.
by Paul Gofman (＠gofman) Jan. 24, 2025

Jan. 24, 2025

v4: - fix a bug in "crypt32: Only remove cert from mem store list when deleting it." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7193#note_92796

1 0

[PATCH v2 0/6] MR7193: crypt32: A refcount fix and cert enumeraton improvement.
by Paul Gofman (＠gofman) Jan. 24, 2025

Jan. 24, 2025

-- v2: crypt32: Don't assert in Context_Release() on invalid refcount. crypt32/tests: Add a test for deleting and adding certs during enumeration. crypt32: Only remove cert from mem store list when deleting it. crypt32: Don't try to release zero-refcount context in MemStore_addContext(). crypt32: Factor out memstore_free_context() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7193

3 8

[PATCH v2 0/2] MR7169: ntdll: Fix the return value of NtDelayExecution.
by William Horvath (＠whrvth) Jan. 24, 2025

Jan. 24, 2025

The key change is to never return STATUS_TIMEOUT, and to instead return the result of NtYieldExecution() if zero timeout was passed, or STATUS_SUCCESS otherwise. An overview of the correct values for each combination, copied from the test commit: - Non-alertable, zero timeout: STATUS_SUCCESS or STATUS_NO_YIELD_PERFORMED - Non-alertable, non-zero timeout: STATUS_SUCCESS - Alertable, zero timeout: STATUS_SUCCESS, STATUS_NO_YIELD_PERFORMED, or STATUS_USER_APC - Alertable, non-zero timeout: STATUS_SUCCESS or STATUS_USER_APC -- v2: ntdll: Fix the return value of NtDelayExecution. ntdll/tests: Add tests for NtDelayExecution and Sleep(Ex). https://gitlab.winehq.org/wine/wine/-/merge_requests/7169

4 9

[PATCH 0/5] MR7193: crypt32: A refcount fix and cert enumeraton improvement.
by Paul Gofman (＠gofman) Jan. 24, 2025

Jan. 24, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7193

2 7

[PATCH v3 0/7] MR7152: dxgi: Fix the frame latency waitable implementation.
by Giovanni Mascellani (＠giomasce) Jan. 24, 2025

Jan. 24, 2025

This is an alternative proposal to !5830. It fixes the same glitches in Horizon Zero Dawn, but attempts to do that by implementing the proper behavior expected from the swapchain. More precisely, it fixes a few mistakes I had made the last time I touched this code, it implements the frame latency waitable with a semaphore instead of an event (as it should be) and at last it uses the frame latency waitable to implement an appropriate wait after presentation when the client didn't request to manage the waitable directly. This implementation is not yet complete, because the semaphore should be released when the frame is presented. Knowing when this is the case would require using `VK_KHR_present_wait`. We currently approximate that with the moment in which the frame is submitted for presentation to Vulkan, which as far as I can tell is good enough. Eventually I'll try to write the proper thing. This MR depends on https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/1343, which has been submitted in the meantime to vkd3d. The vkd3d change is included in the first commit, so this MR is already functional. -- v3: dxgi: Wait on the frame latency semaphore when the client doesn't do it. dxgi: Make the frame latency waitable a semaphore. dxgi: Remove the frame latency fence. dxgi: Directly signal the frame latency fence. dxgi: Do not bias the frame latency fence. dxgi: Set the frame latency even when increasing the frame latency. dxgi: Submit Vulkan presentation as soon as possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/7152

3 10