October 2025 - Wine-GitLab - list.winehq.org

[PATCH v2 0/9] MR9206: d3dx11: Import more tests from d3dx10 and implement D3DX11CreateTextureFromMemory() using shared code.
by Connor McAdams (＠cmcadams) Nov. 4, 2025

Nov. 4, 2025

The test code here is pulled in from the d3dx10 tests, with some variable name changes to work around existing d3dx11 test definitions and a removal of a few `broken()`s for Windows Vista since we no longer test on it. -- v2: d3dx11: Implement D3DX11CreateTextureFromMemory() using shared code. d3dx11/tests: Import test_create_texture() from d3dx10. d3dx11/tests: Import test_get_image_info() from d3dx10. d3dx11/tests: Rearrange and reformat tests to more closely match d3dx10 tests. d3dx11: Add stubs for D3DX11CreateTextureFromResource{A,W}(). d3dx11: Add stubs for D3DX11GetImageInfoFromResource{A,W}(). d3dx10/tests: Cleanup test image definitions. d3dx10/tests: Get rid of broken() workarounds for Vista. d3dx10: Downgrade invalid filter trace from an ERR to a WARN. https://gitlab.winehq.org/wine/wine/-/merge_requests/9206

3 14

[PATCH 0/3] MR9278: xaudio2: XAudio2CreateWithVersionInfo, better error handling.
by Paul Gofman (＠gofman) Nov. 4, 2025

Nov. 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9278

3 5

[PATCH v2 0/2] MR9215: iphlpapi/tests: Give GetBestRoute2 a SOCKETADDR_INET. (ASan)
by Bernhard Übelacker Nov. 4, 2025

Nov. 4, 2025

The test also calls GetBestRoute2 with only the smaller sockaddr_in but reads inside the whole SOCKADDR_INET type. Therefore I recived this ASan report, reading 28 bytes from variable with only 16 bytes. The second patch removes a few unneeded casts to SOCKADDR_INET. But there are more which ASan does not complain about here, should they also be changed to a SOCKADDR_INET type? CC: @yshui , @gofman Followup to 93a3d8bf9f (!9085) / ada093a6d2 (!8991). <details> <summary>ASan details:</summary> https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-10-04_wine-10.… ``` ================================================================= ==iphlpapi_test.exe==560==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ff440 at pc 0x6ffffe86c02b bp 0x7ffffe1fe630 sp 0x7ffffe1fe678 READ of size 28 at 0x7ffffe1ff440 thread T0 #0 0x6ffffe86c02a in __asan_memcpy /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_interceptors_memintrinsics.cpp:65:3 #1 0x6ffffb1b869a in GetBestRoute2 .../wine/dlls/iphlpapi/iphlpapi_main.c:4851:20 #2 0x00014000e0b2 in test_best_routes .../wine/dlls/iphlpapi/tests/iphlpapi.c:3908:11 #3 0x00014000123f in func_iphlpapi .../wine/dlls/iphlpapi/tests/iphlpapi.c:4017:5 #4 0x000140022bb2 in run_test .../wine/include/wine/test.h:765:5 #5 0x00014002262c in main .../wine/include/wine/test.h #6 0x0001400247ba in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62:11 #7 0x6fffffc377b0 in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #8 0x6fffffdc05b6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700505b6) Address 0x7ffffe1ff440 is located in stack of thread T0 at offset 384 in frame #0 0x00014000b3cf in test_best_routes .../wine/dlls/iphlpapi/tests/iphlpapi.c:3503 This frame has 17 object(s): [32, 36) 'index' (line 3506) [48, 76) 'dst6' (line 3507) [112, 140) 'src6' (line 3507) [176, 204) 'best6' (line 3507) [240, 268) 'link_local_addr6' (line 3507) [304, 332) 'global_addr6' (line 3507) [368, 384) 'dst4' (line 3508) [400, 416) 'src4' (line 3508) <== Memory access at offset 384 partially underflows this variable [432, 448) 'global_addr4' (line 3508) [464, 472) 'link_local_luid' (line 3509) [496, 504) 'luid' (line 3509) [528, 608) 'uni_row' (line 3510) [640, 744) 'fwd_row' (line 3511) [784, 792) 'table' (line 3512) [816, 1072) 's' (line 3513) [1136, 1392) 's2' (line 3513) [1456, 1484) 'best4' (line 3514) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/iphlpapi/iphlpapi_main.c:4851:20 in GetBestRoute2 Shadow bytes around the buggy address: 0x7ffffe1ff180: f2 f2 f2 f2 04 f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ff200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff280: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 04 f2 00 00 0x7ffffe1ff300: 00 04 f2 f2 f2 f2 00 00 00 04 f2 f2 f2 f2 00 00 0x7ffffe1ff380: 00 04 f2 f2 f2 f2 00 00 00 04 f2 f2 f2 f2 00 00 =>0x7ffffe1ff400: 00 04 f2 f2 f2 f2 00 00[f2]f2 00 00 f2 f2 00 00 0x7ffffe1ff480: f2 f2 00 f2 f2 f2 00 f2 f2 f2 00 00 00 00 00 00 0x7ffffe1ff500: 00 00 00 00 f2 f2 f2 f2 00 00 00 00 00 00 00 00 0x7ffffe1ff580: 00 00 00 00 00 f2 f2 f2 f2 f2 00 f2 f2 f2 00 00 0x7ffffe1ff600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff680: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Thread 1 "0204" hit Breakpoint 5, GetBestRoute2 (luid=<optimized out>, luid(a)entry=0x0, index=index(a)entry=2, src=src(a)entry=0x0, dst=dst(a)entry=0x7ffffe2ff7b0, options=<optimized out>, options(a)entry=0, bestroute=<optimized out>, bestroute(a)entry=0x7ffffe2ff8f0, bestaddress=<optimized out>, bestaddress(a)entry=0x7ffffe2ff880) at .../wine/dlls/iphlpapi/iphlpapi_main.c:4851 4851 dst_addr = *dst; Wine-gdb> bt #0 GetBestRoute2 (luid=<optimized out>, luid(a)entry=0x0, index=index(a)entry=2, src=src(a)entry=0x0, dst=dst(a)entry=0x7ffffe2ff7b0, options=<optimized out>, options(a)entry=0, bestroute=<optimized out>, bestroute(a)entry=0x7ffffe2ff8f0, bestaddress=<optimized out>, bestaddress(a)entry=0x7ffffe2ff880) at .../wine/dlls/iphlpapi/iphlpapi_main.c:4851 #1 0x0000000140004e57 in test_best_routes () at .../wine/dlls/iphlpapi/tests/iphlpapi.c:3908 #2 func_iphlpapi () at .../wine/dlls/iphlpapi/tests/iphlpapi.c:4017 #3 0x00000001400061dd in run_test (name=name(a)entry=0x14001b21b <winetest_color_reset+189> "iphlpapi") at .../wine/include/wine/test.h:765 #4 0x0000000140005ec4 in main (argc=<optimized out>, argv=<optimized out>) at .../wine/include/wine/test.h:877 Wine-gdb> print dst $1 = (const SOCKADDR_INET *) 0x7ffffe2ff7b0 Wine-gdb> print sizeof(*dst) $2 = 28 Wine-gdb> up #1 0x0000000140004e57 in test_best_routes () at .../wine/dlls/iphlpapi/tests/iphlpapi.c:3908 3908 ret = GetBestRoute2( NULL, default_route_index, NULL, (SOCKADDR_INET *)&dst4, 0, &fwd_row, (SOCKADDR_INET *)&best4 ); Wine-gdb> print &dst4 $3 = (struct sockaddr_in *) 0x7ffffe2ff7b0 Wine-gdb> print sizeof(dst4) $4 = 16 Wine-gdb> ``` </details> -- v2: iphlpapi/tests: Remove some unneeded casts to SOCKADDR_INET. iphlpapi/tests: Give GetBestRoute2 a SOCKETADDR_INET. (ASan) https://gitlab.winehq.org/wine/wine/-/merge_requests/9215

2 5

[PATCH 0/6] MR9310: wintab32: Call display drivers through win32u.
by Jacek Caban (＠jacek) Nov. 4, 2025

Nov. 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9310

6 11

[PATCH 0/5] MR9307: Use AUTOCONVERTPCM in a few APIs depending on mmdevapi.
by Giovanni Mascellani (＠giomasce) Nov. 4, 2025

Nov. 4, 2025

Initializing the audio client without AUTOCONVERTPCM is expected to fail when the requested sampling rate or channel count does not match the mixing format. Such behavior is not currently modeled on Wine, but it should be introduced, and since in many cases we expect automatic format conversion to work we add the flag. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9307

3 7

[PATCH v2 0/2] MR9276: ntdll: Implement and use NtAlertMultipleThreadByThreadId().
by Paul Gofman (＠gofman) Nov. 3, 2025

Nov. 3, 2025

-- v2: ntdll: Use NtAlertMultipleThreadByThreadId() in RtlWakeAddressAll(). ntdll: Implement NtAlertMultipleThreadByThreadId(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9276

3 10

[PATCH v2 0/5] MR9325: jscript: Add stub implementations for typed array constructors.
by Jacek Caban (＠jacek) Nov. 3, 2025

Nov. 3, 2025

-- v2: jscript: Add stub implementations for typed array constructors. jscript: Don't expose DataView and ArrayBuffer objects in IE9 mode. jscript: Move SCRIPTLANGUAGEVERSION_ declarations to jsdisp.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/9325

3 9

[PATCH v3 0/1] MR8933: mf: Update the stream sink input type when a transform output type changes.
by Conor McCarthy (＠cmccarthy) Nov. 3, 2025

Nov. 3, 2025

-- v3: mf: Update the stream sink input type when handling an output node format change. https://gitlab.winehq.org/wine/wine/-/merge_requests/8933

3 2

[PATCH v4 0/9] MR8812: winegstreamer: Support 2D sample buffer.
by Conor McCarthy (＠cmccarthy) Nov. 3, 2025

Nov. 3, 2025

Performance issues can occur when a video output sample has a 2D buffer, because winegstreamer currently outputs only to a linear buffer, which must then be copied into the 2D buffer. Worse, a linear lock of the 2D buffer requires the current contents to be copied to a linear buffer, even when we intend to overwrite it, because MF linear buffers do not support write-only locking. -- v4: mf/tests: Test H.264 sink media type height alignment. winegstreamer: Support 2D sample buffer. mf: Test color convert 2D buffers. mf: Test WMV decoder 2D buffers. mf: Test H.264 decoder 2D buffers. mf: Test sample copier 2D buffers. mfplat/tests: Test NV12 negative stride in MFCreateMediaBufferFromMediaType(). mf/tests: Remove todo for an H.264 decoder test. mf/tests: Stop checking samples at the end of the expected array. https://gitlab.winehq.org/wine/wine/-/merge_requests/8812

3 13

[PATCH v3 0/5] MR9271: Implement group affinity support in CreateRemoteThreadEx.
by eric pouech (＠epo) Nov. 3, 2025

Nov. 3, 2025

This MR implements group affinity support in attributes list passed to CreateRemoteThreadEx(). (up to the current Wine limit of 64 logical cores). It also adds a couple of missing APIs definitions related to group affinity support. Notes: - duplicating for the Nth time struct \_PROC\_THREAD\_ATTRIBUTE\_LIST definition isn't very nice... perhaps we should define it somewhere? - it's very likely that CreateRemoteThreadEx() should call into NtCreateThreadEx() (instead of the Rtl counter part), but I opted for the simpler approach to set thread affinity after thread creation (this could be changed if needed). -- v3: kernelbase: Support group affinity attributes. kernel32/tests: Test thread creation with group affinity attributes. include: Add missing process group related definitions. kernelbase: Support affinity group in process/thread attributes list. kernel32: Test adding group affinity to proc/thread attributes list. https://gitlab.winehq.org/wine/wine/-/merge_requests/9271

3 6