October 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR9298: ntdll: Remove unused parameter from linux_query_event_obj().
by Marc-Aurel Zent (＠mzent) Oct. 28, 2025

Oct. 28, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9298

2 1

[PATCH 0/1] MR3228: Update heap.c removed return NULL at line 985. Prevents Wing Commander...
by James Carthew (＠dmjc) Oct. 28, 2025

Oct. 28, 2025

Update heap.c removed return NULL at line 985. Prevents Wing Commander Prophecy and Secret Ops for loading/playing. Fixes WINE bug 55176. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3228

5 4

Re: [PATCH v8 0/5] MR9209: vccorlib140: Implement Platform::Exceptions.
by Piotr Caban (＠piotr) Oct. 28, 2025

Oct. 28, 2025

I'm going to move some patches from this MR to a new one to make future reviews easier (this comment is mainly to make sure there's no work duplication). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_119861

1 0

[PATCH 0/4] MR9297: ntdll: Add wow64 support for IOCTL_SCSI_PASS_THROUGH_DIRECT.
by Akihiro Sagawa (＠sgwaki) Oct. 28, 2025

Oct. 28, 2025

This is the second part intended to replace !8120. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58257 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9297

2 4

Re: [PATCH v8 0/5] MR9209: vccorlib140: Implement Platform::Exceptions.
by Piotr Caban (＠piotr) Oct. 28, 2025

Oct. 28, 2025

Some of the recent fixes where added to wrong patches (first patch has base set incorrectly, it's fixed in second patch). Another problem is that there's something wrong with how the WinRT exceptions are handled/implemented. With code from this MR it's not possible to mix native and builtin ucrtbase and vccorlib140 (we're getting ACCESS_VIOLATION while using exception throwing functions). While it might be not critical I would like to understand what's going on. I'm planning to look into it more. I guess it might be some kind of side-effect of trying to make these exceptions working with older exception handlers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_119856

1 0

[PATCH v3 0/6] MR9032: opengl32: Support wow64 buffer storage and persistent memory mapping using Vulkan.
by Jacek Caban (＠jacek) Oct. 28, 2025

Oct. 28, 2025

I'm opening this MR as an RFC. It's an initial attempt to support OpenGL persistent memory mapping in the new wow64. The implementation is not complete yet (details below), but it's intentionally kept as simple as possible for a proof of concept. Since we can't control where OpenGL maps memory, the idea is to use the available Vulkan extension with enough glue between them. Because of how GL–VK interop works, this requires creating a memory object on the Vulkan side and importing it into OpenGL. Once that's done, all operations on such buffers are performed through GL, except for mapping, which is handled by Vulkan. This is achieved by hooking `gl*BufferStorage` and reimplementing it on top of `glImportMemoryFdEXT` for mappable buffers. Recently introduced buffer wrappers make further tracking of these buffers straightforward. If we move forward with this, the feature will need to be enabled based on available driver capabilities (for now, it's force-enabled). Some parts might also be worth moving into win32u. This alone seems enough to claim persistent memory support and thus expose OpenGL 4.6 on the new wow64. Performance looks good in my limited testing, although that hasn't been a focus yet. Possible improvements include: - Currently only GL buffers created with `gl*BufferStorage` are affected. Other cases still fall back to the slow memcpy path. - The draft just picks the first host-visible coherent memory type exposed by Vulkan. We could try harder to pick an optimal type taking into account GL flags. - The draft allocates a new Vulkan memory and fd for each mapped buffer. This is inefficient for small buffers, for which a suballocator could help. - The draft always picks the first GPU reported by Vulkan. We may need to ensure that the selected device matches the one OpenGL actually uses. An alternative would be a new OpenGL extension. A driver-level solution could be more efficient, and it would certainly be nice to have. However, since such an extension doesn't exist yet, and even if we have it soon, I think it's still valuable to have a fallback solution that works with existing drivers. -- v3: opengl32: Support wow64 buffer storage and persistent memory mapping using Vulkan. opengl32: Wrap buffer storage functions. opengl32: Use stored extensions in filter_extensions. opengl32: Use stored extension list in is_extension_supported. opengl32: Compute supported extensions in make_context_current. opengl32: Split extensions by null bytes in the registry. https://gitlab.winehq.org/wine/wine/-/merge_requests/9032

2 7

[PATCH 0/6] MR9295: mmdevapi: Add a SW synth MIDI device.
by Anton Baskanov (＠baskanov) Oct. 28, 2025

Oct. 28, 2025

This is an alternative approach to !7233: instead of creating an actual driver, just add a SW synth device in `mmdevapi`. Other differences from !7233: - Get rid of `struct swmidi` and put everything in global variables. - Use static initialization for `cs`, remove `swmidi_init()` and `swmidi_exit()`. Whole series for reference: https://gitlab.winehq.org/baskanov/wine/-/tree/mmdevapi-swmidi?ref_type=hea… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9295

2 6

[PATCH v9 0/7] MR6783: winegstreamer: Fix memory/resource leaks in media sources.
by Conor McCarthy (＠cmccarthy) Oct. 28, 2025

Oct. 28, 2025

Streams hold a reference to the source, but this reference should not be taken until `Start()` is called because freeing the media source depends on release in `Shutdown()` of the stream's reference to the source. We could create the streams in `media_source_create()` and take source refs for them in `Start()`, but that's potentially confusing and fragile. Streams can persist after the media source is destroyed. In that case, they cannot access the source object and it should be released and set to null. Windows behaviour is to release references to the source in `Shutdown()`. If we don't do this and a buggy app were to leak a stream object, the media source object would also leak and `wg_parser_destroy()` would not be called. -- v9: mf/tests: Fix object leaks caused by the test source and stream. mf/session: Shut down both the sink activate object and the media sink if present. winegstreamer: Release stream references to the media source in Shutdown(). winegstreamer: Do not create MF stream objects until the media source is started. mf/tests: Add some checks for session object leakage. mfplat/tests: Test video stream release after media source release. mfplat/tests: Add more media source refcount checks. https://gitlab.winehq.org/wine/wine/-/merge_requests/6783

2 8

Re: [PATCH v3 0/1] MR9151: winevulkan: Update to VK spec version 1.4.329
by Oscar Barenys (＠oscarbg) Oct. 28, 2025

Oct. 28, 2025

sorry to ask here: VK 1.4.330 includes a "bunch" of extensions.. an update would be nice, if possible :-) thanks.. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9151#note_119830

1 0

[PATCH 0/1] MR9256: kernel32: Don't rename GetCurrentThreadId.
by Alex Henrie (＠alexhenrie) Oct. 27, 2025

Oct. 27, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58837 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9256

5 12