October 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v11 0/6] MR9147: rometadata: Implement CIL assembly/metadata reader + some IMetaDataTables methods. - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9147

1 0

Re: [PATCH v3 0/1] MR9187: Fix native TWAIN transfer mode for 64-Bit wine: pData points to a HGLOBAL,... - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9187

1 0

Re: [PATCH v2 0/1] MR9064: wineboot: Ensure that the ProxyEnable value is created. - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9064

1 0

Re: [PATCH v4 0/1] MR9291: tdh: Add semi-stub for TdhEnumerateProviders(). - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9291

1 0

Re: [PATCH v5 0/2] MR9249: winegstreamer: Return NS_E_NO_MORE_SAMPLES from WMSyncReader if sample fails to read. - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9249

1 0

Re: [PATCH v2 0/2] MR9292: msado15: Mark recordset open in ADORecordsetConstruction:put_Rowset. - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9292

1 0

Re: [PATCH v4 0/1] MR9247: server: fix incorrect key modification in rename_key function - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9247

1 0

Re: [PATCH v5 0/3] MR9282: wbemprox: Implement more MSSMBios_RawSMBiosTables properties - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9282

1 0

Re: [PATCH v5 0/1] MR9126: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC. - approved
by Alexandre Julliard (＠julliard) Oct. 27, 2025

Oct. 27, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9126

1 0

[PATCH v4 0/1] MR9126: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC.
by Brendan Shanks (＠bshanks) Oct. 27, 2025

Oct. 27, 2025

Starting with macOS 10.15, `mmap()` for a file with `PROT_EXEC` fails with `EPERM`. But for some reason, doing separate `mmap()` and then `mprotect()` calls works. This fixes `NtUserRegisterClassExWOW: Failed to get shared session object for window class` errors seen when running a 32-bit EXE lacking the NX compat bit. The shared memory object being used for window classes was being mapped executable, this was failing because of the above, and then `map_file_into_view()` was falling back to `pread()` which doesn't make sense for a shared memory region. (It seems like a bug to use `pread()` in this scenario rather than return an error, although I'm not sure how that could be detected). `map_file_into_view()` uses the `mac_mmap()` wrapper which does the separate `mmap()` and `mprotect()` calls when needed. `map_pe_header()` was also using `PROT_EXEC`, but my understanding is that was only done to detect a noexec filesystem. I did some testing and found that macOS does not restrict executable mapping of files on noexec filesystems like Linux and FreeBSD do, which should remove the need to map `PROT_EXEC` on macOS. CrossOver has used a similar hack for `map_file_into_view()` and `map_pe_header()` for years. -- v4: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC. https://gitlab.winehq.org/wine/wine/-/merge_requests/9126

2 1