October 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/3] MR8946: widl: Add metadata support for imported types.
by Hans Leidekker (＠hans) Oct. 3, 2025

Oct. 3, 2025

On Fri Oct 3 09:41:20 2025 +0000, Rémi Bernon wrote: > Same here, it just moves lines around? Right, I failed to fix that up in the patch split. These lines are removed in the next patch so I hope that's okay. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8946#note_117514

1 0

[PATCH 0/1] MR9092: wbemprox: Implement Win32_LocalTime.
by Hans Leidekker (＠hans) Oct. 3, 2025

Oct. 3, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9092

2 1

Re: [PATCH v2 0/3] MR8946: widl: Add metadata support for imported types. - approved
by Rémi Bernon Oct. 3, 2025

Oct. 3, 2025

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8946

1 0

Re: [PATCH v2 0/3] MR8946: widl: Add metadata support for imported types.
by Rémi Bernon Oct. 3, 2025

Oct. 3, 2025

Rémi Bernon (@rbernon) commented about tools/widl/metadata.c: > > add_constructor_overload( type ); > > - scope = resolution_scope( TABLE_ASSEMBLYREF, MSCORLIB_ROW ); > - typeref = add_typeref_row( scope, add_string("Object"), add_string("System") ); > - extends = typedef_or_ref( TABLE_TYPEREF, typeref ); > - > flags = TYPE_ATTR_PUBLIC | TYPE_ATTR_UNKNOWN; > if (!is_attr( type->attrs, ATTR_COMPOSABLE )) flags |= TYPE_ATTR_SEALED; > if (!iface_list) flags |= TYPE_ATTR_ABSTRACT; > > + scope = resolution_scope( TABLE_ASSEMBLYREF, MSCORLIB_ROW ); > + typeref = add_typeref_row( scope, add_string("Object"), add_string("System") ); > + extends = typedef_or_ref( TABLE_TYPEREF, typeref ); > + > type->md.def = add_typedef_row( flags, name, namespace, extends, 0, 0 ); Same here, it just moves lines around? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8946#note_117511

1 0

Re: [PATCH v2 0/3] MR8946: widl: Add metadata support for imported types.
by Rémi Bernon Oct. 3, 2025

Oct. 3, 2025

Rémi Bernon (@rbernon) commented about tools/widl/metadata.c: > static void add_runtimeclass_type_step2( type_t *type ) > { > const typeref_list_t *iface_list = type_runtimeclass_get_ifaces( type ); > - UINT name, namespace, scope, extends, typeref, flags; > + UINT name, namespace, scope, typeref, extends, flags; This looks unnecessary? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8946#note_117510

1 0

[PATCH v2 0/2] MR9003: Draft: makedep: Add support for generating winmd files.
by Hans Leidekker (＠hans) Oct. 3, 2025

Oct. 3, 2025

-- v2: wine.inf: Install windows.networking.winmd. makedep: Add support for generating winmd files. https://gitlab.winehq.org/wine/wine/-/merge_requests/9003

4 8

Re: [PATCH v2 0/4] MR9081: ddraw: Fill dwZBufferBitDepths.
by Rémi Bernon Oct. 3, 2025

Oct. 3, 2025

I think the tests are failing/crashing on Windows: https://test.winehq.org/data/patterns.html#ddraw:ddraw2 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9081#note_117503

1 0

[PATCH v5 0/5] MR8976: server: Move more class info to the shared memory.
by Rémi Bernon Oct. 3, 2025

Oct. 3, 2025

-- v5: win32u: Read extra class info from the shared memory object. server: Move extra class info to the shared memory object. server: Allocate shared memory objects with dynamic size. win32u: Read class info from the shared memory object. server: Move class info to the shared memory object. https://gitlab.winehq.org/wine/wine/-/merge_requests/8976

1 5

[PATCH v3 0/1] MR8722: mf: Add a SUBMITTED command state to avoid multiple submission of the same op.
by Yuxuan Shui (＠yshui) Oct. 3, 2025

Oct. 3, 2025

If a session is shutdown when its command_state is already COMPLETE, session_handle_source_shutdown calls session_set_stopped, which calls session_command_complete which will submit the op at the head of commands again, despite it having already been submitted. Given that only the op at the head of commands can be in the submitted state, tracking it as a command state makes more sense to me. And if the command state is SUBMITTED we know not to submit the op again. * * * Superceded !8270 -- v3: mf: Add a SUBMITTED command state to avoid multiple submission of the same op. https://gitlab.winehq.org/wine/wine/-/merge_requests/8722

4 8

[PATCH 0/4] MR8925: winemac.drv: Add EDID support.
by Jactry Zeng (＠jactry) Oct. 2, 2025

Oct. 2, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8925

3 9