October 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/6] MR9086: server: Continuously poll on queue fd for driver events.
by Rémi Bernon Oct. 2, 2025

Oct. 2, 2025

Allowing to use a simple event-like sync for the message queues. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9086

1 6

Re: [PATCH v2 0/1] MR9085: iphlpapi: Give GetBestRoute2 a SOCKETADDR_INET.
by Yuxuan Shui (＠yshui) Oct. 1, 2025

Oct. 1, 2025

On Wed Oct 1 23:57:24 2025 +0000, Paul Gofman wrote: > I think the bug here is most likely in GetBestInterface() and should be > fixed there (by using SOCKADDR_INET instead of struct sockaddr_in), and > likely no bug in GetBestRoute2. > TL;DL; Note GetBestRoute2 even zeroes output bestaddress in full and > that is backed by the tests. Whether GetBestRoute2 accesses src and dst > in full or shorter part in case of ipv4 is currently not tested, but I > think it more likely does on Windows (and if I didn't have to fixup dst > address in the concerned place I would just do 'connect( s, (struct > sockaddr *)dst, sizeof(*dst) )' and that access would happen in ws2_32 > where it would copy the address for DeviceIoControl). That > 'SOCKADDR_INET *' passed for dst, not a void pointer with explicit > length, so from general sense it is totally valid to access the whole > structure, and the implementation would naturally do it if it would, e. > g., passing the address to nsiproxy or ws2_32 without interpreting here. > Small chance that it doesn't access it on Windows of course, but I'd > suggest we don't overdo it by testing this implementation detail on > Windows in the absense of practical motivation, avoid adding extra code > to GetBestRoute2 and just use the SOCKADDR_INET structure in GetBestInterface(). updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9085#note_117392

1 0

Re: [PATCH v3 0/3] MR9078: More debugging related fixes & enhancements. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9078

1 0

Re: [PATCH v2 0/4] MR9071: server: Introduce an internal queue bits field. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9071

1 0

Re: [PATCH v2 0/6] MR9072: win32u: Implement D3DKMT object sharing through NT handles. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9072

1 0

Re: [PATCH v2 0/5] MR9073: Cmd engine rewrite (part XXXVII) - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9073

1 0

Re: [PATCH v3 0/1] MR9077: imm32: ensure HIMC is unlocked in ImmGenerateMessage - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9077

1 0

Re: [PATCH v3 0/1] MR9014: server: Create an inproc sync for user APC signaling. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9014

1 0

Re: [PATCH v3 0/3] MR9083: xmllite/writer: Remove now unnecessary helper. - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9083

1 0

Re: [PATCH v6 0/1] MR9053: vccorlib140: Emit RTTI for Platform::Type - approved
by Alexandre Julliard (＠julliard) Oct. 1, 2025

Oct. 1, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9053

1 0