November 2025 - Wine-GitLab

[PATCH v2 0/4] MR9541: win32u: Reduce EGL memory usage by skipping some devices initialization.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58833 -- v2: win32u: Skip non-display software EGL devices initialization. win32u: Terminate non-display EGL devices after initialization. win32u: Add the display device first in the EGL device list. win32u: Keep devices EGL platforms in a list. https://gitlab.winehq.org/wine/wine/-/merge_requests/9541

2 6

[PATCH 0/1] MR9544: win32u: Release internal OpenGL drawables outside of the user lock.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

Sometimes windows get destroyed while wined3d still has some internal drawables allocated, and the cached DCs gets removed and destroyed as soon as the window itself is, causing free_dce to be called with the user lock held already. Then opengl_drawable_release grabing the surfaces lock with the user lock held causes deadlocks with other threads creating or presenting surfaces which need to take the locks in the reverse order. Fixes: a085746bbe3594e4ea01ea578823383e6447b6b6 This is visible in several d2d/d3d tests timing out since that change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9544

1 1

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) Nov. 20, 2025

Nov. 20, 2025

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } > + > + *ret_mime = CoTaskMemAlloc((len+1)*sizeof(WCHAR)); > if(!*ret_mime) > return E_OUTOFMEMORY; > > memcpy(*ret_mime, ret, len*sizeof(WCHAR)); > + ((WCHAR*)(*ret_mime))[len] = 0; ```suggestion:-0+0 (*ret_mime)[len] = 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123132

1 0

Re: [PATCH v2 0/1] MR9410: urlmon: FindMimeFromData return only the mime type
by Jacek Caban (＠jacek) Nov. 20, 2025

Nov. 20, 2025

Jacek Caban (@jacek) commented about dlls/urlmon/mimefilter.c: > > TRACE("found %s for %s\n", debugstr_w(ret), debugstr_an((const char*)buf, min(32, size))); > > - len = lstrlenW(ret)+1; > - *ret_mime = CoTaskMemAlloc(len*sizeof(WCHAR)); > + len = lstrlenW(ret); > + for(i = 0; i < len; i++) > + { > + if (ret[i] == ';') > + { > + len = i; > + break; > + } > + } ```suggestion:-8+0 len = wcsspn(ret, L";"); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9410#note_123131

1 0

[PATCH v2 0/1] MR9516: jscript: Do existing prop lookups for external props only on objects with volatile props.
by Gabriel Ivăncescu Nov. 20, 2025

Nov. 20, 2025

-- v2: jscript: Do existing prop lookups for external props only on objects with https://gitlab.winehq.org/wine/wine/-/merge_requests/9516

2 5

[PATCH 0/2] MR9543: msado15: Don't use row index in _Recordset::get_EditMode.
by Piotr Caban (＠piotr) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9543

2 2

[PATCH v3 0/3] MR9526: win32u/tests: Test which Vulkan/GL/D3D graphics objects hold shared resource handles.
by Derek Lesho (＠dlesho) Nov. 20, 2025

Nov. 20, 2025

In prep for my OpenGL shared resource series. The behavior there seems to be heavily driver-specific. -- v3: win32u/tests: Test shared handle lifetime. https://gitlab.winehq.org/wine/wine/-/merge_requests/9526

2 4

[PATCH 0/2] MR9542: win32u, winex11: Fix and workaround crashes in UpdateLayeredWindow calls.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9542

1 2

[PATCH 0/1] MR9532: win32u: Only delete subkeys when clearing DirectX key.
by Paul Gofman (＠gofman) Nov. 20, 2025

Nov. 20, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9532

3 3

[PATCH 0/3] MR9540: win32u/tests: Set GL_DEDICATED_MEMORY_OBJECT_EXT on import.
by Rémi Bernon Nov. 20, 2025

Nov. 20, 2025

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/9526 with stylistic fixups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9540

2 4