December 2025 - Wine-GitLab

Re: [PATCH v2 0/6] MR9814: wined3d: Invalidate less when applying stateblocks.
by Elizabeth Figura (＠zfigura) Dec. 24, 2025

Dec. 24, 2025

On Wed Dec 24 11:05:18 2025 +0000, Alexandre Julliard wrote: > This is breaking the ddraw7 test, could you please have a look? > ``` > ddraw7.c:11539: Test failed: Got unexpected color 0x00808000, case 4. > ``` Thanks for catching that; I sent 9827. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9814#note_126118

1 0

[PATCH 0/1] MR9827: wined3d: Invalidate FFP PS settings when FOGVERTEXMODE changes.
by Elizabeth Figura (＠zfigura) Dec. 24, 2025

Dec. 24, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9827

2 1

[PATCH 0/4] MR9826: winebth.sys: Minor refactors and fixes
by Vibhav Pant (＠vibhavp) Dec. 24, 2025

Dec. 24, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9826

2 4

Re: [PATCH v2 0/6] MR9814: wined3d: Invalidate less when applying stateblocks.
by Alexandre Julliard (＠julliard) Dec. 24, 2025

Dec. 24, 2025

Alexandre Julliard (@julliard) commented about dlls/wined3d/stateblock.c: > return; > } > > + if (stateblock->type == WINED3D_SBT_PRIMARY && value == stateblock->stateblock_state.rs[state]) > + { > + TRACE("Ignoring redundant call on a primary stateblock.\n"); > + return; > + } This is breaking the ddraw7 test, could you please have a look? ``` ddraw7.c:11539: Test failed: Got unexpected color 0x00808000, case 4. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9814#note_126116

1 0

[PATCH 0/4] MR9822: Fix possible EA launcher hangs.
by Zhiyi Zhang (＠zhiyi) Dec. 24, 2025

Dec. 24, 2025

Registering window classes in DllMain() is prone to deadlocks. Tests show that comctl32 window classes should probably be registered in RegisterClassNameW(). Fix possible EA launcher hangs due to deadlocks. A deadlock can happen, like the following, based on Tim Clem's findings. Say there are two threads, T1 and T2. T1: does some COM stuff that results in registering the window class OleMainThreadWndClass. T1: NtUserRegisterClassExWOW() does get_desktop_window(). Because this is not a built-in class. T1: doesn't yet have a desktop window, so it makes one and calls register_builtin_classes(). T1: starts the pthread_once in register_builtin_classes() to actually register the classes. T1: starts calling NtUserRegisterClassExWOW() with its classes. T2: loads comctl32.dll, calls its PROCESS_ATTACH. It grabs the loader lock. T2: comctl32's DllMain starts registering its classes. T2: comctl32's attempts to register classes also call get_desktop_window(). T2: get_desktop_window hits the pthread_once in register_builtin_classes() and starts waiting for T1 to finish it. T1: some built-in class registration results in a LoadImageW call for a class's cursor. T1: LoadImage has to grab a resource, so it tries to grab the loader lock. T1: the loader lock is held by T2. Deadlock; T2 is waiting on T1, which is waiting on T2. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9822

3 8

[PATCH v2 0/1] MR9825: winefile: Successfully get path for shell files.
by tbodt (＠tbodt) Dec. 23, 2025

Dec. 23, 2025

Non-folder entries in the shell namespace have no ->folder, so their this would fail to get the path. Instead always look up the attributes using the parent. -- v2: winefile: Successfully get path for shell files. https://gitlab.winehq.org/wine/wine/-/merge_requests/9825

2 1

Re: [PATCH v3 0/1] MR9811: wined3d/gl: Split UBOs to separate chunks. - approved
by Alexandre Julliard (＠julliard) Dec. 23, 2025

Dec. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9811

1 0

Re: [PATCH v2 0/1] MR9824: mscoree: Update Wine Mono to 10.4.1. - approved
by Alexandre Julliard (＠julliard) Dec. 23, 2025

Dec. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9824

1 0

Re: [PATCH v2 0/1] MR9819: windows.media.speech/tests: Get rid of duplicated hresult. - approved
by Alexandre Julliard (＠julliard) Dec. 23, 2025

Dec. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9819

1 0

Re: [PATCH v2 0/3] MR9821: Avoid crash in gnutls logging when crypt libraries got unloaded. - approved
by Alexandre Julliard (＠julliard) Dec. 23, 2025

Dec. 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9821

1 0