December 2025 - Wine-GitLab

Re: [PATCH 0/1] MR9761: urlmon/tests: Don't test function directly when reporting GetLastError()
by Jacek Caban (＠jacek) Dec. 18, 2025

Dec. 18, 2025

Jacek Caban (@jacek) commented about dlls/urlmon/tests/sec_mgr.c: > ok(hres == S_OK, > "Unexpected Remove result: 0x%08lx, expected result: 0x%08lx\n", hres, S_OK); > > - ok(GetTempPathW(ARRAY_SIZE(tmp_dir), tmp_dir), > - "GetTempPathW failed with: 0x%08lx\n", GetLastError()); > + ret = GetTempPathW(ARRAY_SIZE(tmp_dir), tmp_dir); > + ok(ret, GetTempPathW failed with: 0x%08lx\n", GetLastError()); It doesn't build, the opening quote is missing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9761#note_125800

1 0

Re: [PATCH 0/1] MR9768: include: Disable compiler exceptions for ARM64EC MSVC targets before Clang 21
by Jacek Caban (＠jacek) Dec. 18, 2025

Dec. 18, 2025

The change looks correct to me, but I wonder if we should split the check so that it is handled separately for each target. It is getting complicated, and we will probably want to add i386 there as well once LLVM is able to handle it, which would introduce yet another version check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9768#note_125799

1 0

[PATCH 0/1] MR9793: winex11: Avoid hiding windows between WM_SETREDRAW messages.
by Rémi Bernon Dec. 18, 2025

Dec. 18, 2025

See also f323d75e658fcb4f48c0b762001cee1da09d9398. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59098 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59069 This is different from the Splinter Cell case, as the window processes its messages and the window get shown again, but it is still related to WM_SETREDRAW and this fix here would fix the Splinter Cell case too. I originally decided to try a simpler fix, but as this issue is also present with other applications I think it's better now to try fixing it for all of them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9793

1 1

[PATCH 0/1] MR9792: dbghelp: Don't crash when creating minidump without exception pointers.
by eric pouech (＠epo) Dec. 18, 2025

Dec. 18, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56932 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9792

2 1

Re: [PATCH 0/2] MR9788: opengl: WGL_arb_pixel_format reporting. - approved
by Rémi Bernon Dec. 18, 2025

Dec. 18, 2025

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9788

1 0

Re: [PATCH 0/2] MR9788: opengl: WGL_arb_pixel_format reporting.
by Rémi Bernon Dec. 18, 2025

Dec. 18, 2025

> Then, the extension is now completely missing in GLX backend, and while it is not default probably worth fixing there as well. display_funcs_init calls init_wgl_extensions then adds the extension unconditionally, it should be there with the GLX backend too. The change might be fine still, because it needs to appear before WGL_ARB_pixel_format_float. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9788#note_125779

1 0

Re: [PATCH v2 0/1] MR9778: wined3d: Keep a reference on the swapchain the DC is borrowed from.
by Rémi Bernon Dec. 18, 2025

Dec. 18, 2025

I don't really know the swapchain lifetime details, and while I find it a bit weird that we continue presenting to windows after the swapchains objects have been destroyed, I think it was working more like that before: the DCs were created and owned by the contexts instead, and their lifetime didn't depend on the swapchains. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9778#note_125778

1 0

Re: [PATCH v2 0/1] MR9778: wined3d: Keep a reference on the swapchain the DC is borrowed from.
by Rémi Bernon Dec. 18, 2025

Dec. 18, 2025

It doesn't do the same thing, swapchain DCs are meant to be presented to the window directly (whether this ends up being onscreen or blitted in win32u is up to win32u), while backup DC involves a GDI blit from wined3d side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9778#note_125777

1 0

[PATCH 0/1] MR9791: dbghelp: {dwarf} Skip compilation units with attributes imported from .dwz.
by eric pouech (＠epo) Dec. 18, 2025

Dec. 18, 2025

This is just a workaround for linked bug, and just avoids the crash at the cost of dropping the whole compilation unit from debug information. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58414 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9791

2 1

[PATCH 0/1] MR9790: riched20: Don't crash on WM_COPY without selection.
by eric pouech (＠epo) Dec. 18, 2025

Dec. 18, 2025

Note: actual crash happens within ME_StreamOutRTF, which do/while loop expects a non-zero length to be used. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59005 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9790

2 1