December 2025 - Wine-GitLab

[PATCH 0/1] MR9840: winepulse: A potential solution to audio crackling
by Dzmitry Keremsha (＠Vyrolian) Dec. 30, 2025

Dec. 30, 2025

I have noticed that winepulse leaves too little headroom when draining the buffer, which very often leads to crackling that can't be fully resolved by manipulating latency. Let's check some math: Let's assume that the buffer (tlength) is at 33ms, and minreq is at 13.3ms. If 13.2 ms were drained, the refill would be denied. If the next timer trigger takes 14ms due to jitter, that leaves us with a 6.1ms margin. As such, if we get any jitter longer than that during refill, we get an underflow. I think this is roughly what leads to crackles. My solution increases timer polling to 5x the frequency, so if 13.2ms were drained, the next timer trigger would happen at around 16ms. That would leave us with a 17ms headroom. The math might not be 100% representation of what happens, but I think it's quite close to reality. On practice, this does indeed help to fully get rid of crackling for an indefinite amount of time, when before they were unevitable. I understand that this might be not the most elegant approach, the 5x increase is arbitrary. I also had to remove the adv_bytes logic and use to_write to move pointers within pulse_write instead. I think this problem is quite urgent, because while this does not happen on every system, it's frequent enough that we see "Audio: Crackling" reports on most games in protondb and there are many forum threads about audio crackling. From my experience, the only solution was switching to winealsa, which is very consistent and does not crackle at all. My experience has been very consistent with forum threads when it came to the nature of crackling. I first noticed it in Balatro, which is a very light game and should not be crackling at all on any setup. Some games have very frequent crackling every 20-30 seconds, or a buzzsaw crackling every 10-15 minutes. I hope my idea brings us closer to the ultimate fix, I really look forward to your feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9840

2 1

[PATCH v8 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński Dec. 30, 2025

Dec. 30, 2025

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v8: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

2 10

[PATCH 0/3] MR9839: dcomp: Create stub implementations for DirectComposition
by Jaakko Hannikainen (＠jgke) Dec. 30, 2025

Dec. 30, 2025

These stub implementations enable Dorico to successfully boot. They don't implement any real rendering or linkings to rendering contexts, they just create various interfaces with methods returning E_NOTIMPL. Notably, the `CompositionDevice` family has some interesting inheritance relations: * `IDCompositionDevice` inherits from `IUnknown` * `IDCompositionDevice2` also inherits from `IUnknown`, rather than `IDCompositionDevice` * `IDCompositionDesktopDevice` and `IDCompositionDevice3` both inherit from `IDCompositionDevice2`, rather than one inheriting from the other This means that a implementation of these needs to provide separate interfaces for at least `IDCompositionDevice` , `IDCompositionDesktopDevice` and `IDCompositionDevice3` . This MR also provides an 'implementation' for `IDCompositionDevice2` . The three commits here are: * Implement bare minimum of the `DCompositionCreateDevice` and `DCompositionCreateDevice2` to get Dorico to boot, ie. return the appropriate interfaces from those functions, which do nothing expect for some additional allocation functions, such as `IDCompositionDevice:CreateTargetForHwnd` . * Implement rest of `DCompositionCreateDevice`, `DCompositionCreateDevice2` and `DCompositionCreateDevice3`, and use shared 1implementations' for all of the related interfaces * Return fake S_OK responses from `IDCompositionDevice:Commit`, `IDCompositionTarget:SetRoot` and `IDCompositionVisual:SetContent` -- Dorico has one tool window where the software actually checks the response codes from all of these, and if any of these return E_NOTIMPL the entire software crashes. These prevent the crash, but the window in question will be rendered completely white. This is my first contribution for Wine, if there's some weird code it's most likely because of me, and not Microsoft. I don't have a bug for Dorico because the installer seems to require half of the internet through winetricks, but I believe this Cubase bug is caused by the same code: https://bugs.winehq.org/show_bug.cgi?id=57680 -- which I couldn't verify because the installers for Cubase currently don't seem work under Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9839

3 7

[PATCH v2 0/1] MR9834: user32: Test DlgDirList in a temp directory.
by James Hawkins (＠truiken) Dec. 29, 2025

Dec. 29, 2025

DlgDirList can fail to enumerate files for the ListBox in some scenarios, e.g., when the current directory is a UNC mount provided by the WSL 2 9P server. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=2948wq -- v2: user32: Test DlgDirList in a temp directory. https://gitlab.winehq.org/wine/wine/-/merge_requests/9834

2 1

[PATCH 0/1] MR9836: wow64: Only compare the valid segment selector part
by André Zwing Dec. 29, 2025

Dec. 29, 2025

VARA.exe (Visual Basic 6 application) needs this on ARM64, as there can be garbage in the upper words of the segments. The garbage seems to get there through calls to NtRaiseException. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9836

1 1

Re: [PATCH v2 0/1] MR9762: msvcrt: Rename __C_specific_handler to avoid a clang20 crash - closed
by André Zwing Dec. 29, 2025

Dec. 29, 2025

This merge request was closed by André Zwing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9762

1 0

[PATCH v4 0/2] MR9835: Server: Add wrapper for debug and error output
by Ralf Habacker (＠rhabacker) Dec. 29, 2025

Dec. 29, 2025

While working on !7650, it turned out that the logs generated by wineserver do not use a prefix, which makes it difficult to distinguish the corresponding entries in combined logs e.g. `WINEDEBUG=+file,+winsock,+server` from the other debug channels. This is fixed by this merge request. Here is an example: ``` 0024:trace:file:WriteFile 00000010 00490545 9 0122E230 00000000 0024:trace:file:NtWriteFile (0x10,(nil),(nil),(nil),0x122e1e8,0x490545,0x00000009,(nil),(nil)) 0024:trace:server:get_handle_fd( handle=0010 ) 0024:trace:server:get_handle_fd() = BAD_DEVICE_TYPE { type=0, cacheable=0, access=00000000, options=00000000 } 0024:trace:server:write( async={handle=0010,event=0000,iosb=0122e1e8,user=7e4c0020,apc=00000000,apc_context=00000000}, pos=00000000, data={57,69,6e,65,2d,64,62,67,3e} ) trace:server:wake_thread 00d0: *wakeup* signaled=0 0024:trace:server:write() = PENDING { wait=003c, options=00000020, size=0 } 00d0:trace:server:get_next_console_request( handle=0010, signal=0, read=0, status=00000000, out_data={} ) 00d0:trace:server:get_next_console_request() = 0 { code=0050807c, output=00000001, out_size=0, in_data={57,69,6e,65,2d,64,62,67,3e} } 0024:trace:server:select( flags=2, cookie=0021eae4, timeout=infinite, size=8, prev_apc=0000, result={}, data={WAIT,handles={003c}}, contexts={} ) 0024:trace:server:select() = PENDING { apc_handle=0000, signaled=0, call={}, contexts={} } ``` -- v4: server: use TRACE* macros instead of fprintf(stderr) https://gitlab.winehq.org/wine/wine/-/merge_requests/9835

2 2

[PATCH v3 0/2] MR9835: Server: Add wrapper for debug and error output
by Ralf Habacker (＠rhabacker) Dec. 29, 2025

Dec. 29, 2025

While working on !7650, it turned out that the logs generated by wineserver do not use a prefix, which makes it difficult to distinguish the corresponding entries in combined logs e.g. `WINEDEBUG=+file,+winsock,+server` from the other debug channels. This is fixed by this merge request. -- v3: server: use TRACE* macros instead of fprintf(stderr) https://gitlab.winehq.org/wine/wine/-/merge_requests/9835

2 2

[PATCH v2 0/2] MR9835: Server: Add wrapper for debug and error output
by Ralf Habacker (＠rhabacker) Dec. 29, 2025

Dec. 29, 2025

While working on !7650, it turned out that the logs generated by wineserver do not use a prefix, which makes it difficult to distinguish the corresponding entries in combined logs e.g. `WINEDEBUG=+file,+winsock,+server` from the other debug channels. This is fixed by this merge request. -- v2: server: use TRACE* macros instead of fprintf(stderr) server: Add wrapper for debug and error output https://gitlab.winehq.org/wine/wine/-/merge_requests/9835

2 2

[PATCH 0/2] MR9835: Server: Add wrapper for debug and error output
by Ralf Habacker (＠rhabacker) Dec. 29, 2025

Dec. 29, 2025

While working on !7650, it turned out that the logs generated by wineserver do not use a prefix, which makes it difficult to distinguish the corresponding entries in combined logs e.g. `WINEDEBUG=+file,+winsock,+server` from the other debug channels. This is fixed by this merge request. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9835

2 2