February 2025 - Wine-GitLab

Re: [PATCH v2 0/1] MR7314: configure: macOS is always darwin*. - approved
by Alexandre Julliard (＠julliard) Feb. 12, 2025

Feb. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7314

1 0

Re: [PATCH v2 0/1] MR7309: windowscodecs: Simplify a bit FlipRotator_CopyPixels() implementation. - approved
by Alexandre Julliard (＠julliard) Feb. 12, 2025

Feb. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7309

1 0

Re: [PATCH v2 0/8] MR7305: windowscodecs/tests: Add some tests for handler objects enumerator. - approved
by Alexandre Julliard (＠julliard) Feb. 12, 2025

Feb. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7305

1 0

Re: [PATCH v2 0/2] MR7311: mshtml: Clear the documents list when detaching inner window. - approved
by Alexandre Julliard (＠julliard) Feb. 12, 2025

Feb. 12, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7311

1 0

[PATCH 0/2] MR7318: gdiplus: Use correct format guid for .ico files.
by Fabian Maurer (＠DarkShadow44) Feb. 12, 2025

Feb. 12, 2025

Adapted from https://github.com/reactos/reactos/pull/7714 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7318

3 3

[PATCH v5 0/10] MR6966: windows.web: Partially implement IJsonValueStatics::Parse().
by Mohamad Al-Jaf (＠maljaf) Feb. 12, 2025

Feb. 12, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56914 A full implementation should ideally use a JSON library. -- v5: windows.web/tests: Add IJsonValueStatics::Parse() tests. windows.web: Implement IJsonValue::GetBoolean(). windows.web: Implement IJsonValue::GetNumber(). windows.web: Implement IJsonValue::GetString(). windows.web: Add error handling in IJsonValue::GetObject(). windows.web: Add error handling in IJsonValue::GetArray(). windows.web: Partially implement IJsonValueStatics::Parse(). windows.web: Implement IJsonValue::get_ValueType(). windows.web/tests: Add IJsonValue::get_ValueType() tests. windows.web/tests: Remove superfluous cast. https://gitlab.winehq.org/wine/wine/-/merge_requests/6966

3 12

[PATCH v3 0/2] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet.
by Jacek Caban (＠jacek) Feb. 12, 2025

Feb. 12, 2025

Based on Piotr's findings. On MSVC i386 targets, structs requiring alignment greater than 4 are never passed by value. Clang follows the same behavior in MSVC mode (see [1] for details and [2] for a follow-up that applies this logic when fields, not necessarily the entire struct, are aligned). A number of ios functions take fpos_mbstatet as an argument and expect it to be passed by value. [1] https://reviews.llvm.org/D72114 [2] https://github.com/llvm/llvm-project/issues/63257 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57817 -- v3: msvcp60: Avoid explicitly aligning structs passed by value. msvcp: Avoid explicitly aligning structs passed by value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

3 4

[PATCH v4 0/4] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) Feb. 12, 2025

Feb. 12, 2025

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- v4: ntdll: Replace '0' with 'NULL' in gettimeofday() calls. ntdll: Use gettimeofday in system_time_precise on macOS. ntdll: Use __commpage_gettimeofday in NtQuerySystemTime on macOS. ntdll: Always use mach_continuous_approximate_time on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

2 5

[PATCH v3 0/1] MR7154: dlls/mshtml/mshtml.inf: add registry associations for .log files
by Austin English (＠austin987) Feb. 12, 2025

Feb. 12, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=25872 -- v3: mshtml: Add registry association for .log files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7154

3 2

[PATCH v2 0/4] MR7312: msvcp: Avoid explicitly aligning fpos_mbstatet.
by Jacek Caban (＠jacek) Feb. 12, 2025

Feb. 12, 2025

Based on Piotr's findings. On MSVC i386 targets, structs requiring alignment greater than 4 are never passed by value. Clang follows the same behavior in MSVC mode (see [1] for details and [2] for a follow-up that applies this logic when fields, not necessarily the entire struct, are aligned). A number of ios functions take fpos_mbstatet as an argument and expect it to be passed by value. [1] https://reviews.llvm.org/D72114 [2] https://github.com/llvm/llvm-project/issues/63257 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57817 -- v2: msvcp60/tests: Avoid explicitly aligning structs passed by value. msvcp60: Avoid explicitly aligning structs passed by value. msvcp90/tests: Avoid explicitly aligning structs passed by value. msvcp: Avoid explicitly aligning structs passed by value. https://gitlab.winehq.org/wine/wine/-/merge_requests/7312

2 5