February 2025 - Wine-GitLab

Re: [PATCH v2 0/1] MR7310: server: Don't fail SetThreadPriority() on terminated threads - approved
by Alexandre Julliard (＠julliard) Feb. 11, 2025

Feb. 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7310

1 0

Re: [PATCH v2 0/4] MR7307: Implement NtGdiDdDDIQueryAdapterInfo() - approved
by Alexandre Julliard (＠julliard) Feb. 11, 2025

Feb. 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7307

1 0

Re: [PATCH v5 0/1] MR7252: cmd: add support for right-to-left handle redirection (2<&1) - approved
by Alexandre Julliard (＠julliard) Feb. 11, 2025

Feb. 11, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7252

1 0

[PATCH v18 0/2] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) Feb. 11, 2025

Feb. 11, 2025

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v18: shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

2 2

[PATCH v4 0/7] MR7287: ntdll: Avoid using current_modref.
by Jacek Caban (＠jacek) Feb. 11, 2025

Feb. 11, 2025

This is a cleanup in preparation for !7. Originally, !7 extended the use of `current_modref`, but I think we could avoid that with a more direct approach. Most of these changes are no-ops. For the relay handler, we no longer treat `GetProcAddress` calls inside `DllMain` as coming from a loaded DLL. I believe this was more of a side effect of how the code was structured rather than an intentional behavior that needs to be preserved. One more use of `current_modref` remains, which will be removed by !7. -- v4: ntdll: Remove no longer needed current_modref. ntdll: Use NULL importer in LdrGetProcedureAddress. https://gitlab.winehq.org/wine/wine/-/merge_requests/7287

2 7

[PATCH v3 0/7] MR7287: ntdll: Avoid using current_modref.
by Jacek Caban (＠jacek) Feb. 11, 2025

Feb. 11, 2025

This is a cleanup in preparation for !7. Originally, !7 extended the use of `current_modref`, but I think we could avoid that with a more direct approach. Most of these changes are no-ops. For the relay handler, we no longer treat `GetProcAddress` calls inside `DllMain` as coming from a loaded DLL. I believe this was more of a side effect of how the code was structured rather than an intentional behavior that needs to be preserved. One more use of `current_modref` remains, which will be removed by !7. -- v3: ntdll: Remove no longer needed current_modref. null: Use NULL importer in LdrGetProcedureAddress. ntdll: Pass importer pointer to build_import_name. ntdll: Pass importer pointer to find_forwarded_export. ntdll: Pass importer pointer to find_named_export. ntdll: Pass importer pointer to find_ordinal_export. ntdll: Pass WINE_MODREF to import_dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/7287

3 9

[PATCH v2 0/7] MR7287: ntdll: Avoid using current_modref.
by Jacek Caban (＠jacek) Feb. 11, 2025

Feb. 11, 2025

This is a cleanup in preparation for !7. Originally, !7 extended the use of `current_modref`, but I think we could avoid that with a more direct approach. Most of these changes are no-ops. For the relay handler, we no longer treat `GetProcAddress` calls inside `DllMain` as coming from a loaded DLL. I believe this was more of a side effect of how the code was structured rather than an intentional behavior that needs to be preserved. One more use of `current_modref` remains, which will be removed by !7. -- v2: ntdll: Remove no longer needed current_modref. null: Use NULL importer in LdrGetProcedureAddress. ntdll: Pass importer pointer to build_import_name. ntdll: Pass importer pointer to find_forwarded_export. ntdll: Pass importer pointer to find_named_export. ntdll: Pass importer pointer to find_ordinal_export. ntdll: Pass WINE_MODREF to import_dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/7287

3 15

[PATCH v2 0/3] MR7204: Fix running arm+arm64 in old wow64 mode
by Martin Storsjö Feb. 11, 2025

Feb. 11, 2025

This allows using one single wineprefix, one wineserver and one single wine executable for running both arm and arm64 executables. This setup actually has worked earlier; Ubuntu 22.04 packages Wine 6.0, where the wine32 + wine64 packages together end up working this way. However, since Wine 6.0, a couple of refactorings has broken this setup along the way; reinstate this way of working. The new wow64 mode probably won't work on arm, as it's not easily possible to switch between 32 and 64 bit execution mode within a process, as far as I know, but the old wow64 mode is still a great convenience - especially considering distro-packaged use for users who aren't familiar with the particular quirks on this architecture. -- v2: configure: Allow using --enable-win64 on aarch64 server: Include ARMNT as one of the supported architectures on aarch64 ntdll: Allow running arm/aarch64 in (old) wow64 mode https://gitlab.winehq.org/wine/wine/-/merge_requests/7204

3 8

[PATCH 0/1] MR7310: server: Don't fail SetThreadPriority() on terminated threads
by Jinoh Kang (＠iamahuman) Feb. 11, 2025

Feb. 11, 2025

Fixes: 0559442de9c139ec2b66fee69f87a58b60df4b10 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57824 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7310

2 1

[PATCH v3 0/1] MR7238: winebus,mmdevapi: implement audio device container id
by Harald Sitter (＠sitter) Feb. 11, 2025

Feb. 11, 2025

This is a bit convoluted because of the amount of pieces involved. I'll try to untangle things a bit. The container id is meant to be globally unique and stable. We therefore need a suitable amount of stable entropy that we can feed into a hash function to get a stable and unique output. This happens in winebus. The corner stone of hash inputs is the linux device topology (sysfs path) obtained via udev. Along with all other possible data we feed this into a hash function to obtain our container id. A bunch of extra wine-specific keys needed to be added to carry the necessary metadata from the driver into the ntoskrnl (where it gets written to the property registry of the relevant device). Separate from this we also ingest the linux device topology (sysfs path) in the winepulse driver. In mmdevapi we then use winepulse's sysfs path to find the matching device in the setupapi and query its container id. We now have the same container id in both the device and the MMDevice, allowing applications (in particular Games) to find the MMDevice for a given device. For practical reasons we always resolve the sysfs path to the root device as early as possible. Container ids are meant to be equal for sub devices inside a "container" anyway. -- v3: winebus,mmdevapi: implement audio device container id https://gitlab.winehq.org/wine/wine/-/merge_requests/7238

3 4