February 2025 - Wine-GitLab

Re: [PATCH v13 0/3] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) Feb. 10, 2025

Feb. 10, 2025

On Mon Feb 10 20:30:31 2025 +0000, Jacek Caban wrote: > Sorry for not noticing it later, but looking at oleaut32 code, I think > that we should iterate `data` pointer from 0 index here. I fixed that, > changed a bit the style to be more consistent with vbscipt and created > !7304. I hope it's fine for you. Thanks! Sure. Anything that pushes this through is ok by me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_94181

1 0

Re: [PATCH v13 0/3] MR7052: vbscript: implement Join()
by Jacek Caban (＠jacek) Feb. 10, 2025

Feb. 10, 2025

Jacek Caban (@jacek) commented about dlls/vbscript/global.c: > + > + hres = SafeArrayAccessData(sa, (void**)&data); > + if (FAILED(hres)) > + goto cleanup; > + > + str_array = (BSTR *)malloc((ubound - lbound + 1) * sizeof(BSTR)); > + if (!str_array) { > + hres = E_OUTOFMEMORY; > + goto cleanup_data; > + } > + free_str_array = (BSTR *)calloc((ubound - lbound + 1), sizeof(BSTR)); > + if (!free_str_array) { > + hres = E_OUTOFMEMORY; > + goto cleanup_data; > + } > + for (i = lbound; i <= ubound; i++) { Sorry for not noticing it later, but looking at oleaut32 code, I think that we should iterate `data` pointer from 0 index here. I fixed that, changed a bit the style to be more consistent with vbscipt and created !7304. I hope it's fine for you. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7052#note_94179

1 0

[PATCH 0/1] MR7304: vbscript: Add Join implementation.
by Jacek Caban (＠jacek) Feb. 10, 2025

Feb. 10, 2025

Based on !7052. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7304

2 2

[PATCH 0/1] MR7299: server, ntdll: Make monotonic_counter() relative to the server start time.
by Anton Baskanov (＠baskanov) Feb. 10, 2025

Feb. 10, 2025

Fixes long uptimes causing Parkan: Iron Strategy to hang shortly after starting a mission and laggy arrows in GTA San Andreas lowrider challenge. The games seem to not like low values either so add a 5 minute offset to the counter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7299

3 3

[PATCH v2 0/3] MR7211: windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformRotate90) for bitmaps with bpp >= 8.
by Dmitry Timoshkov (＠dmitry) Feb. 10, 2025

Feb. 10, 2025

-- v2: windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformRotate90) for bitmaps with bpp >= 8. windowscodecs: Implement IWICBitmapFlipRotator(WICBitmapTransformFlipHorizontal) for bitmaps with bpp >= 8. windowscodecs/tests: Add some tests for IWICBitmapFlipRotator. https://gitlab.winehq.org/wine/wine/-/merge_requests/7211

3 5

[PATCH v4 0/6] MR7174: rtworkq: Fix handling of platform startup and lock counts.
by Conor McCarthy (＠cmccarthy) Feb. 10, 2025

Feb. 10, 2025

Startup and lock counts in native Windows are separate, and the lock count does not decrease when an async result is freed if the platform has been started. -- v4: rtworkq: Introduce an async result object cache. rtworkq: Introduce a platform startup count. rtworkq/tests: Test work queue. mfplat/tests: Test platform startup and lock counts. mfplat/tests: Test mixing of MF platform functions with their Rtwq equivalents. mfplat/tests: Introduce a helper to check the platform lock count. https://gitlab.winehq.org/wine/wine/-/merge_requests/7174

4 10

[PATCH 0/1] MR7302: winebth.sys: Don't call dbus_pending_call_set_notify with a NULL pending call.
by Vibhav Pant (＠vibhavp) Feb. 10, 2025

Feb. 10, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7302

2 1

[PATCH 0/4] MR7301: Some fixes to cmd.exe.
by eric pouech (＠epo) Feb. 10, 2025

Feb. 10, 2025

This MR fixes two bugzilla entries against cmd.exe. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7301

2 4

[PATCH 0/2] MR7297: win32u: Post WM_MOUSELEAVE immediately when the cursor is not in the specified tracking window.
by Zhiyi Zhang (＠zhiyi) Feb. 10, 2025

Feb. 10, 2025

Fix erwin Data Modeler unable click its comboboxes in listboxes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7297

3 4

[PATCH 0/1] MR7279: wbemprox: Fix a memory leak while filling Win32_PnPEntity fields.
by Nikolay Sivov (＠nsivov) Feb. 10, 2025

Feb. 10, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7279

5 4