February 2025 - Wine-GitLab

[PATCH v3 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v3: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH v3 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) Feb. 7, 2025

Feb. 7, 2025

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v3: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

4 7

[PATCH v2 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v2: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; Consistently written with parameter names as per spec. Fix parameter validation to be consistent with spec. Fix szNameBuf parameter semantics as per spec. Fix szNameBuf casing str search as per spec. Factor out common code into TLB_ helpers vastly improves readability. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/6] MR7284: Splay tree part 5
by Zhiyi Zhang (＠zhiyi) Feb. 7, 2025

Feb. 7, 2025

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7284

2 6

[PATCH v3 0/2] MR7283: documentation: Mac OS X became macOS from 10.12
by Dean M Greer (＠Gcenx) Feb. 7, 2025

Feb. 7, 2025

-- v3: readme: Update mac info section https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

2 3

Re: [PATCH v2 0/1] MR7283: documentation: Mac OS X became macOS from 10.12
by Alfred Agrell (＠Alcaro) Feb. 7, 2025

Feb. 7, 2025

Alfred Agrell (@Alcaro) commented about README.md: > Make sure you have the USER_LDT, SYSVSHM, SYSVSEM, and SYSVMSG options > turned on in your kernel. > > **Mac OS X info**: Not gonna update this one? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283#note_93987

1 0

[PATCH 0/1] MR7283: documentation: Mac OS X became macOS from 10.12
by Dean M Greer (＠Gcenx) Feb. 7, 2025

Feb. 7, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

2 1

[PATCH v4 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu Feb. 6, 2025

Feb. 6, 2025

-- v4: server: When renaming, only fstat the source once. server: Remove source when renaming to a hardlink of itself. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

2 13

[PATCH 0/2] MR7282: winemac: Fix issues found with Main Thread Checker
by Brendan Shanks (＠bshanks) Feb. 6, 2025

Feb. 6, 2025

Fix 3 calls to AppKit that were not being done from the main thread, found using Apple's [Main Thread Checker](https://developer.apple.com/documentation/xcode/diagnosing-memory-…. I used it with Wine by dlopen()ing `/Applications/Xcode.app/Contents/Developer/usr/lib/libMainThreadChecker.dylib` in `macdrv_init()`, commenting out the `SIGABRT` handler in `signal_x86_64.c`, and setting `MTC_CRASH_ON_REPORT=1` so the process will `abort()` and eventually generate a crash log+backtrace. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7282

3 3