February 2025 - Wine-GitLab

Re: [PATCH v5 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

On Fri Feb 7 20:18:51 2025 +0000, Nikolay Sivov wrote: > What this needs first is tests, and then fixes would could normally > touch more than just absolute minimum, like having some helpers etc. But > only renaming local variables is not something we normally do. Yes, three tests are fixed if you review. > absolute minimum That is why commits have been split up to make things trivially clear. > But only renaming local variables is not something we normally do. Except it isn't just renaming variables if you actually looked it over. No offense but this attitude to new contributions explains a lot about why this code is so horrifically inconsistent and in disrepair. There are multiple buffer overflows and deref of invalid ptr's, both of which controllable by the user and other subtle bugs. A few have been addressed here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286#note_94040

1 0

[PATCH 0/2] MR7280: gdiplus/tests: Extend a GdipGetPathGradientBlend() test with excessive output buffer size.
by Nikolay Sivov (＠nsivov) Feb. 7, 2025

Feb. 7, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7280

3 3

[PATCH v9 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Feb. 7, 2025

Feb. 7, 2025

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. For reference, here's how current_modref is being passed around (before this patch): ```mermaid graph TB fii["fixup_imports_ilonly (directly sets current_modref)"] fi["fixup_imports (directly sets current_modref)"] pa["process_attach (directly sets current_modref)"] ld[load_dll] id["import_dll (directly uses current_modref)"] bin["build_import_name (directly uses current_modref)"] foe["find_ordinal_export (uses current_modref for relay)"] ffe["find_forwarded_export (directly uses current_modref)"] fne[find_named_export] MI[MODULE_InitDLL] fii --> ld fi --> id pa --> MI -.-> DllMain id --> bin id --> ld id --> foe id --> fne --> foe --> ffe --> foe ffe --> fne ffe --> bin style DllMain color:red; ``` -- v9: ntdll: Properly track refcount with forwarded exports. ntdll: Don't re-add a module dependency if it already exists. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

3 10

Re: [PATCH v4 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Nikolay Sivov (＠nsivov) Feb. 7, 2025

Feb. 7, 2025

What this needs first is tests, and then fixes would could normally touch more than just absolute minimum, like having some helpers etc. But only renaming local variables is not something we normally do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286#note_94017

1 0

[PATCH v3 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v3: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH v3 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) Feb. 7, 2025

Feb. 7, 2025

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v3: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

4 7

[PATCH v2 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v2: dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/9] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) Feb. 7, 2025

Feb. 7, 2025

Make both method calls; Consistently written with parameter names as per spec. Fix parameter validation to be consistent with spec. Fix szNameBuf parameter semantics as per spec. Fix szNameBuf casing str search as per spec. Factor out common code into TLB_ helpers vastly improves readability. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 9

[PATCH 0/6] MR7284: Splay tree part 5
by Zhiyi Zhang (＠zhiyi) Feb. 6, 2025

Feb. 6, 2025

For React Native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7284

2 6

[PATCH v3 0/2] MR7283: documentation: Mac OS X became macOS from 10.12
by Dean M Greer (＠Gcenx) Feb. 6, 2025

Feb. 6, 2025

-- v3: readme: Update mac info section https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

2 3