February 2025 - Wine-GitLab

[PATCH v2 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) Feb. 6, 2025

Feb. 6, 2025

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v2: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

5 12

[PATCH v8 0/5] MR7: ntdll: Properly track refcount with forwarded exports.
by Jinoh Kang (＠iamahuman) Feb. 6, 2025

Feb. 6, 2025

This fixes https://bugs.winehq.org/show_bug.cgi?id=52094. -- v8: ntdll: Properly track refcount with forwarded exports. ntdll: Don't re-add a module dependency if it already exists. ntdll: Remove some unnecessary NULL checks for current_importer. ntdll: Set export forwarder DLL as the dynamic importer in LdrGetProcedureAddress(). ntdll: Wrap current_modref variable in a new structure. https://gitlab.winehq.org/wine/wine/-/merge_requests/7

4 15

[PATCH 0/1] MR7276: jscript: Fix JSON.stringify for arrays longer than 10.
by Arek Hiler (＠ivyl) Feb. 6, 2025

Feb. 6, 2025

We've been passing `ARRAY_SIZE()` (equal to 16 in this case) as a radix to _itow(). This has caused us trying to get "a" instead of "10", etc. which resulted in unexpected nulls being interspersed in long arrays as well as the arrays being cut short. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7276

3 3

[PATCH 0/1] MR7278: winhttp: Check for the end of the text when stripping trailing newlines from headers (ASan).
by Nikolay Sivov (＠nsivov) Feb. 6, 2025

Feb. 6, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7278

3 2

[PATCH 0/3] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) Feb. 6, 2025

Feb. 6, 2025

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

4 7

[PATCH v4 0/2] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri Feb. 6, 2025

Feb. 6, 2025

This MR intends to add support for the case FileAllocationInformation in function SetFileInformationByHandle of library kernelbase.dll. The code is based on my understanding of [MS documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/d… No test was added, because other cases that could have helped doing so (FileEndOfFileInformation) do not have neither. -- v4: Used posix_fallocate in place of ftruncate + added related test Merge remote-tracking branch 'main/master' into setFileInformationByHandle https://gitlab.winehq.org/wine/wine/-/merge_requests/7115

3 9

[PATCH 0/1] MR7277: winewayland: Round the Wayland refresh rate to calculate the win32 display frequency.
by Alexandros Frantzis (＠afrantzis) Feb. 6, 2025

Feb. 6, 2025

Round the Wayland refresh rate instead of floor-ing it, to report a more accurate win32 display frequency. This can slightly improve FPS values in games that use the reported display frequency to drive their rendering. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56542 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7277

2 1

[PATCH v12 0/3] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) Feb. 6, 2025

Feb. 6, 2025

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v12: clean up created strings https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

2 4

[PATCH v11 0/2] MR7052: vbscript: implement Join()
by Francis De Brabandere (＠francisdb) Feb. 6, 2025

Feb. 6, 2025

closes https://bugs.winehq.org/show_bug.cgi?id=56464 -- v11: also set len if we have an existing string https://gitlab.winehq.org/wine/wine/-/merge_requests/7052

2 2

[PATCH v12 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Feb. 6, 2025

Feb. 6, 2025

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v12: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 5