March 2025 - Wine-GitLab - list.winehq.org

[PATCH v5 0/6] MR7608: server: Avoid delegating console waits to other objects.
by Elizabeth Figura (＠zfigura) March 24, 2025

March 24, 2025

Some console objects currently do several unique things: * Delegate waits onto the queue of another object. This is not really a problem for in-process waits, since we can just return the sync object for the delegate. However, it's also unnecessary, adds to the complexity of the server logic, and is one out of one places where this is done. * Make the wait state dependent on the process. This is difficult to emulate with ntsync and would require creating separate server objects for each process, hacking into duplicate_handle. * Fail a wait entirely in certain circumstances. This is pretty much impossible to emulate with in-process waits. Although ntsync has been in development for some time, I have regrettably failed to notice these problems until now. Fortunately, none of these behaviours happen on modern Windows. Although I/O on unbound handles delegates to the console of the current process, the signaled state does not. As the tests here show, the signaled state of a handle depends on the active console of the process in which the handle was created. If that console no longer exists, the signaled state is no longer updated [with one rather inexplicable exception]. Crucially, in current Windows waits never fail, and the state of an object is the same across all process which hold handles to it. Therefore this patch brings our behaviour to closer match current Windows. In theory these are fds and should use default_fd_signaled(). However, the points at which the handles are signaled are completely different, and I/O does not trigger console handles to become signaled when it normally would. Therefore for the time being I've kept the code using custom signaled ops. There is one other oddity related to consoles, which is the existence of console_add_queue(), which seeks to lazily create an input thread when a console is first waited on. This is one out of two places, after this patch, when the wait process is hijacked (the other being message queues). Fortunately this is easy to handle for in-process synchronization objects, by queueing the ioctl from the callback used to retrieve the in-process synchronization object itself. -- v5: server: Track unbound output signaled state based on its original console. server: Track unbound input signaled state based on its original console. server: Allow waiting on an orphaned screen buffer. server: Use a list of screen buffers per console. server: Fail to create an unbound input/output when there is no console. kernel32/tests: Add more tests for orphaned console handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/7608

2 6

[PATCH v3 0/5] MR7636: d3dx9: Implement saving to DDS files in D3DXSaveTextureToFileInMemory().
by Connor McAdams (＠cmcadams) March 24, 2025

March 24, 2025

The last of the saving patches for d3dx9. :) -- v3: d3dx9: Add support for saving IDirect3DVolumeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DCubeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9/tests: Add more tests for saving textures to DDS files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7636

3 12

Re: [PATCH v2 0/1] MR7637: wow64: skip memcpy for null pointer - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7637

1 0

Re: [PATCH v2 0/1] MR7625: winex11: Use the state tracker for the desktop window _NET_WM_STATE. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7625

1 0

Re: [PATCH v2 0/1] MR7626: winex11: Use the current state when deciding how to reply to WM_TAKE_FOCUS. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7626

1 0

Re: [PATCH v3 0/2] MR7619: comctl32: Implement EVENT_OBJECT_VALUECHANGE for edit controls. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7619

1 0

Re: [PATCH v3 0/1] MR7640: server: Fall back to epoll_wait if epoll_pwait2 doesn't work - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7640

1 0

Re: [PATCH v2 0/1] MR7651: msvcrt: Update file position in _flsbuf() in append mode. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7651

1 0

Re: [PATCH v2 0/5] MR7632: server, ntdll: Return the correct base/actual thread/process priority. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7632

1 0

Re: [PATCH v3 0/1] MR7622: comctl32: Avoid segfault in PROPSHEET_DoCommand when psInfo is NULL. - approved
by Alexandre Julliard (＠julliard) March 24, 2025

March 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7622

1 0