March 2025 - Wine-GitLab - list.winehq.org

[PATCH v29 0/10] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła March 24, 2025

March 24, 2025

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v29: Little fix https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 10

[PATCH v28 0/9] MR7422: winebus/dinput: Support arbitrary number of axes in the virtual PID descriptor
by Tomasz Pakuła March 24, 2025

March 24, 2025

Related Wine issue: https://bugs.winehq.org/show_bug.cgi?id=52714 I'm starting work on updating/extending Linux force feedback API and one of my goals is to expose the number and an array that contains the device's ffb-enabled axes. As I'm mainly working with USB PID driver, I already have a POC of obtaining this data. What prompted this is that currently Wine always creates virtual joysticks with two PID ffb axes. This causes issues with [Richard Burns Rally](https://github.com/ValveSoftware/Proton/issues/6702#issuecomment-267…, as this game incorrectly initializes a `CONSTANT_FORCE` effect with all the FFB axes that contain `DIDOI_FFACTUATOR` flag and then trying to update `cAxes` and `rgdwAxes` values which leads to `DIERR_INVALIDPARAM`. Now, this flag is set by wine while enumerating virtual device's axes and while `(axis index < FFB axes)`, flag is applied. This means, that every device which has FFB functionality and at least two axes, will report FFB on `X`, `Y`. While updated API would mean a lot of steering wheels would correctly report only 1 axis, a lot of USB PID wheels still include `X` and `Y` in their `AXES_ENABLE` and `DIRECTION` usages. This, again, would lead to broken FFB (in affected games). On Windows, there's a possibility of overwriting some joystick capabilities with registry entries, which ends up removing `DIDOI_FFACTUATOR` flag from a selected axis. This doesn't work in Wine. This MR allows Wine to add an arbitrary number (up to `PID_AXES_MAX`) of axes to the PID descriptor, based on the value of Haptic Axes from SDL or from Linux FF api in the future (I'm working on it). Additionally, to work around RBR and other games with similar, wrong FFB handling, I introduced a [hint](https://github.com/libsdl-org/SDL/issues/12341) to SDL that allows a dynamic overwrite of the number of haptic axes. For the Linux API, I'll figure out a nice way to override when the number of axes will be exposed. With these changes, I was able to successfully get force feedback on my Moza Racing R9 with all axes usable. With additional traces in the dinput code, I confirmed that with one axis defined in the PID descriptor, the game created a constant force effect with just one axis and `cAxes = 1`. -- v28: Change few things around dinput/tests: Add tests for 6-axis ff joystick https://gitlab.winehq.org/wine/wine/-/merge_requests/7422

1 9

[PATCH 0/1] MR7652: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) March 24, 2025

March 24, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7652

3 3

Re: [PATCH v11 0/6] MR7610: Draft: win32u: Create a shared object for user handle entries.
by Jinoh Kang (＠iamahuman) March 24, 2025

March 24, 2025

On Mon Mar 24 15:33:24 2025 +0000, Jinoh Kang wrote: > 64-bit volatile stores are not atomic on `__i386__`. I'd advise to just use WriteRelease64. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7610#note_98867

1 0

[PATCH v2 0/5] MR7636: d3dx9: Implement saving to DDS files in D3DXSaveTextureToFileInMemory().
by Connor McAdams (＠cmcadams) March 24, 2025

March 24, 2025

The last of the saving patches for d3dx9. :) -- v2: d3dx9: Add support for saving IDirect3DVolumeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DCubeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9/tests: Add more tests for saving textures to DDS files. d3dx9/tests: Add a test for reading back a texture saved as D3DXIFF_JPG. https://gitlab.winehq.org/wine/wine/-/merge_requests/7636

3 14

Re: [PATCH v11 0/6] MR7610: Draft: win32u: Create a shared object for user handle entries.
by Jinoh Kang (＠iamahuman) March 24, 2025

March 24, 2025

Jinoh Kang (@iamahuman) commented about server/user.c: > + * need atomic intrinsics to guarantee that. */ > +#if defined(__i386__) || defined(__x86_64__) > + *ptr = value; > +#else > + __atomic_store_n(ptr, value, __ATOMIC_SEQ_CST); > +#endif > +} > + > +static void atomic_store_u64(volatile unsigned __int64 *ptr, unsigned __int64 value) > +{ > + /* on x86 there should be total store order guarantees, so volatile is > + * enough to ensure the stores aren't reordered by the compiler, and then > + * they will always be seen in-order from other CPUs. On other archs, we > + * need atomic intrinsics to guarantee that. */ > +#if defined(__i386__) || defined(__x86_64__) > + *ptr = value; 64-bit volatile stores are not atomic on `__i386__`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7610#note_98862

1 0

[PATCH v5 0/13] MR6944: Draft: winex11: Workaround various window manager bugs.
by Rémi Bernon March 24, 2025

March 24, 2025

This workarounds KWin and Mutter window manager bugs/fanciness. The KWin bug is with maximized windows getting broken after sending a configure request, and which fix has been merged upstream already. The Mutter issue is unlikely to be fixed upstream, at least not its specific behavior, and we would instead better handle it as well as we can. -- v5: winex11: Workaround KWin bug with maximized windows. winex11: Set _NET_WM_USER_TIME to 0 to implement SWP_NOACTIVATE. winex11: Keep track of the SWP flags to be used when mapping windows. winex11: Keep _NET_WM_USER_TIME on the individual windows. winex11: Workaround Mutter bug when changing decorations. winex11: Update _MOTIF_WM_HINTS after _NET_WM_STATE and config. winex11: Avoid creating windows with override-redirect flag set. winex11: Track _MOTIF_WM_HINTS property in the state tracker. winex11: Introduce a new handle_state_change helper. winex11: Ignore transient state changes in other processes. winex11: Give focus to the expected window when unampping with focus. winex11: Use the current state when deciding how to reply to WM_TAKE_FOCUS. winex11: Use the state tracker for the desktop window _NET_WM_STATE. https://gitlab.winehq.org/wine/wine/-/merge_requests/6944

2 17

[PATCH 0/4] MR7648: user32/tests: Add some tests for current selection with LBS_NOSEL.
by Nikolay Sivov (＠nsivov) March 24, 2025

March 24, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7648

3 5

[PATCH v10 0/6] MR7610: Draft: win32u: Create a shared object for user handle entries.
by Rémi Bernon March 24, 2025

March 24, 2025

For https://gitlab.winehq.org/wine/wine/-/merge_requests/7512 to use it to locate window shared objects. -- v10: win32u: Use the session shared object for user handle entries. win32u: Use the session shared object to implement is_window. server: Move the user object handle table to the shared memory. server: Use NTUSER_OBJ constants for user object types. server: Create a shared memory object for the global session. include: Implement ReadAcquire64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7610

1 6

[PATCH v7 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) March 24, 2025

March 24, 2025

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v7: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

5 13