March 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Jinoh Kang (＠iamahuman) March 3, 2025

March 3, 2025

On Mon Mar 3 08:08:34 2025 +0000, Dmitry Timoshkov wrote: > It looks like you are right, new tests actually pass with current > implementation. Although the patch makes support for > WICBitmapTransformRotate270 more explicit I'm not opposed to leave the > code intact. I'm open to suggestions. My two cents: This PR is a no-op change except for the test. While this PR improves readability a little, I guess we could go further and handle flip horz/vert flags in a more readable way if we want to go that direction? (Otherwise just keeping the test should be fine too.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96525

1 0

[PATCH v5 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) March 3, 2025

March 3, 2025

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v5: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 3

[PATCH v4 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) March 3, 2025

March 3, 2025

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v4: winedmo: Call avformat_find_stream_info for the mp3 format. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 2

Re: [PATCH v3 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) March 3, 2025

March 3, 2025

Brendan McGrath (@redmcg) commented about dlls/winedmo/unix_demuxer.c: > } > format = demuxer->ctx->iformat; > > - if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE) > + if ((params->duration = get_context_duration( demuxer->ctx )) == AV_NOPTS_VALUE || > + strstr( format->name, "mp3")) > { > if ((ret = avformat_find_stream_info( demuxer->ctx, NULL )) < 0) > { > ERR( "Failed to find stream info, error %s.\n", debugstr_averr(ret) ); > goto failed; > } > - params->duration = get_context_duration( demuxer->ctx ); > + if (params->duration == AV_NOPTS_VALUE) > + params->duration = get_context_duration( demuxer->ctx ); @rbernon I wasn't sure how harmless/harmful this assignment was, so I added a check just in case. If you think it's unnecessary I'll remove. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7439#note_96517

1 0

[PATCH v2 0/1] MR7439: winedmo: Find mp3 stream info if channel data is missing.
by Brendan McGrath (＠redmcg) March 3, 2025

March 3, 2025

This fixes missing mp3 channel data in the FFmpeg demuxer. -- v2: winedmo: Find mp3 stream info if channel data is missing. https://gitlab.winehq.org/wine/wine/-/merge_requests/7439

3 5

[PATCH v9 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.
by Yuxuan Shui (＠yshui) March 3, 2025

March 3, 2025

## Context This is a problem discovered when running "Max: The Curse of Brotherhood" under proton. This game writes 4MB a piece into `wg_transform`, which contains about 4 seconds of compressed video. `wg_transform` calls `gst_pad_push` in `transform_ProcessOutput`, which takes \~300ms (i.e. 20 frames @ 60fps) to decode this buffer of video. So the end result is the game hitches every 4 seconds while playing cut scene videos. Proton currently has a special case for this particular game, for which it breaks up the buffer into small chunks to avoid long blocks. This MR adopts that and applies it generally. One concern raised by @redmcg is: > The only issue I can think of is if there are any decoders which don't have a parser; then they might not know how to deal with an arbitrary 4096 byte buffer (the parser is generally responsible for taking arbitrary buffers and producing something the decoder can work with, for example: a full frame). So this MR only enables this strategy when there is a parser element. -- v9: winegstreamer: Avoid large buffer pushes in wg_transform. https://gitlab.winehq.org/wine/wine/-/merge_requests/7288

3 4

[PATCH 0/2] MR7362: winex11.drv: Better detect and switch windows to managed.
by Paul Gofman (＠gofman) March 3, 2025

March 3, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7362

4 8

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) March 3, 2025

March 3, 2025

On Mon Mar 3 06:33:06 2025 +0000, Dmitry Timoshkov wrote: > The tests don't pass with existing code. It looks like you are right, new tests actually pass with current implementation. Although the patch makes support for WICBitmapTransformRotate270 more explicit I'm not opposed to leave the code intact. I'm open to suggestions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96507

1 0

[PATCH 0/1] MR7464: cryptnet: Uniform return value that is the same as _wfsopen.
by Haoyang Chen (＠chenhaoyang) March 3, 2025

March 3, 2025

INVALID_HANDLE_VALUE is non-zero, and the caller may fail to handle the error. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7464

3 2

Re: [PATCH v2 0/1] MR7459: windowscodecs: Add support for WICBitmapTransformRotate270.
by Dmitry Timoshkov (＠dmitry) March 3, 2025

March 3, 2025

On Mon Mar 3 06:33:06 2025 +0000, Elizabeth Figura wrote: > Wait, isn't this already implemented? WICBitmapTransformRotate270 is the > bitwise OR of 90 and 180, and the code seems to take that into account, > am I missing something? The tests don't pass with existing code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7459#note_96498

1 0