April 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR7890: msvcrt: Avoid dynamic allocation when storing locale name. - approved
by Alexandre Julliard (＠julliard) April 24, 2025

April 24, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7890

1 0

[PATCH 0/1] MR7837: shell32/tests: Avoid hang in test_rename.
by Bernhard Übelacker April 24, 2025

April 24, 2025

Followup of 0eab97ffa8. Usually version checks have to be avoided, but this modifies a pre-existing version check to skip that single test just with Windows 7. [Test pattern page.](https://test.winehq.org/data/patterns.html#shell32:shlfileop) [Testbot run with this patch included.](https://testbot.winehq.org/JobDetails.pl?Key=157955) CC: @zhui -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7837

3 9

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) April 24, 2025

April 24, 2025

On Thu Apr 24 21:00:45 2025 +0000, Nikolay Sivov wrote: > Yes, if you resume from same position it will be assumed that source > produces sane time mark in the event. But there are a lot of assumptions > already, and it's relatively fragile on Windows in other aspects once > you start to go off default behavior. > Regarding multiple sources, as I recall it works in general, e.g. you > can have two completely separate video rendering branches (topoedit > could be used for testing), and it works reliably. Which one is correct > we can only test manually, if you return time+10 for one source and > time+20 another source and see which one reaches the sink clock state > method. What I haven't tried is using two separate source branches and > checking if same clock instance is used for both sinks. If it's doing > something mad and creates one clock per branch, next question would be > what happens to the junction nodes, like transforms with multiple inputs > where streams converging (there is an optional IMFClockConsumer thing > where you can obviously use only one clock). FYI - I just edited my comment above: https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101671 as I had missed a step. It calls `IMFMediaSource::Stop` before flushing the MFT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101828

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) April 24, 2025

April 24, 2025

On Thu Apr 24 20:50:29 2025 +0000, Brendan McGrath wrote: > I think Windows' approach has merit if we are requesting a new start > time, but for resumption I don't think it does. They don't perform any > of the flushing in this scenario. So if the source changes the position > significantly, then all the sinks and MFTs will have stale data. I guess > they just rely on the source not doing that on resumption. > But the other issue is, as you say, there will now be multiple sources > of truth. If we get different values from all the different streams, > which one is correct? Yes, if you resume from same position it will be assumed that source produces sane time mark in the event. But there are a lot of assumptions already, and it's relatively fragile on Windows in other aspects once you start to go off default behavior. Regarding multiple sources, as I recall it works in general, e.g. you can have two completely separate video rendering branches (topoedit could be used for testing), and it works reliably. Which one is correct we can only test manually, if you return time+10 for one source and time+20 another source and see which one reaches the sink clock state method. What I haven't tried is using two separate source branches and checking if same clock instance is used for both sinks. If it's doing something mad and creates one clock per branch, next question would be what happens to the junction nodes, like transforms with multiple inputs where streams converging (there is an optional IMFClockConsumer thing where you can obviously use only one clock). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101827

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) April 24, 2025

April 24, 2025

On Thu Apr 24 11:02:43 2025 +0000, Nikolay Sivov wrote: > > It was calling `OnClockStart`, but it turns out that was because I had > hard-coded the value in my `MESourceStarted` and `MEStreamStarted` > events. After changing these events to instead use `pvarStartPosition` > passed in `IMFMediaSource::Start`, I get: > > > > ``` > > 1330.024952|10088|source_mock_Start: format: > {00000000-0000-0000-0000-000000000000} (GUID_NULL) position: <EMPTY> > > 1330.025598|10088|clock_sink_OnClockRestart: system time 13300255028 > > ``` > > > > So sending those events with a hard-coded `VT_I8` value of zero caused > `OnClockStart` to be called, but now those events have a value of > `VT_EMPTY` and `OnClockRestart` is called. > I see, this is something we do differently. We are using original > session Start() timestamp when restarting the clock, and Windows > apparently is using whatever source reports. I think there is a value in > doing the same - the idea here I'm guessing is to adjust to the source > time, which could deviate both ways from the time client asked for. What > we'll need to figure out is which stamp we should actually be using for > the new clock position. You can have multiple sources with multiple > streams, so number of events with timestamps is potentially number of > streams across all sources + number of sources. I think Windows' approach has merit if we are requesting a new start time, but for resumption I don't think it does. They don't perform any of the flushing in this scenario. So if the source changes the position significantly, then all the sinks and MFTs will have stale data. I guess they just rely on the source not doing that on resumption. But the other issue is, as you say, there will now be multiple sources of truth. If we get different values from all the different streams, which one is correct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101826

1 0

[PATCH v7 0/4] MR7779: mshtml: Misc constructor and prototype improvements.
by Gabriel Ivăncescu April 24, 2025

April 24, 2025

-- v7: mshtml: Define "create" from XMLHttpRequest constructor as a jscript prop mshtml: Define the constructor's prototype on mshtml side. mshtml: Consolidate the functional constructors into a common struct mshtml: Rename struct constructor to stub_constructor. https://gitlab.winehq.org/wine/wine/-/merge_requests/7779

2 8

[PATCH v4 0/2] MR7771: win32u: Make font handle table dynamically growable.
by Brendan Shanks (＠bshanks) April 24, 2025

April 24, 2025

This fixes "out of realized font handles" errors seen with Valve games like Half-Life 2 (which uses more than 1000 font handles). The new limit of 5000 is roughly inspired by the Windows limit, although there are differences. On Windows 11 I can call `CreateFont()` (and then `SetMapMode()`, `SelectObject()`, `SetTextAlign()` to realize the font) exactly 5000 times before it hits the handle limit. Under Wine, child fonts use handles as well, so the limit is usually hit before 5000 `CreateFont()` calls. But, there is caching so that `CreateFont()` calls with identical arguments do not count towards the limit. Ultimately the old limit of 256 was sufficient for almost all applications, and 5000 should be enough for all but the worst-behaved apps. -- v4: win32u: Raise realized font handle limit to 5000. https://gitlab.winehq.org/wine/wine/-/merge_requests/7771

2 3

[PATCH v22 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) April 24, 2025

April 24, 2025

Follow-up of !2786, which appears to have been abandoned. -- v22: ws2_32/tests: Add test for AF_UNIX sockets server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH 0/2] MR7892: winewayland: Always check the role to determine whether a surface is a toplevel.
by Alexandros Frantzis (＠afrantzis) April 24, 2025

April 24, 2025

Since the role objects in the wayland_surface struct are part of a union, we first need to check whether the surface has the right role before checking the role objects themselves. Otherwise we risk using a subsurface as a toplevel or vice-versa. The second commit introduces a helper to deduplicate the toplevel checks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7892

2 2

[PATCH v5 0/1] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) April 24, 2025

April 24, 2025

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8) (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v5: combase: Add stub for RoOriginateErrorW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

3 2