April 2025 - Wine-GitLab - list.winehq.org

[PATCH v2 0/1] MR7669: Draft: ntdll/server: Make robust to spurious short writes
by Bernhard Übelacker April 24, 2025

April 24, 2025

Version 1 of the patch by Keno Fischer. -- v2: ntdll/server: Make robust to spurious short writes https://gitlab.winehq.org/wine/wine/-/merge_requests/7669

3 5

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) April 23, 2025

April 23, 2025

On Wed Apr 23 23:51:29 2025 +0000, Brendan McGrath wrote: > > Just so I understand, SAR clock jumps to pts + \<time it actually took > to play this sample/time it would take according to sample rate\> or it > jumps blindly to pts + mf sample duration, ignoring actual playback > time? I don't know how well sample duration is validated against actual > buffer sizes. > It will jump to PTS and then progress from there at the playback rate. I > don't think it uses the duration value, just buffer size to determine > duration (which is easy to calculate based on frame size and sample rate). I should add that the clock stops once playback of the provided sample(s) are complete. It won't start again until it receives another sample. But if that happens, it seems to add an implicit discontinuity. And after a discontinuity (either implicit as described above, or explicit via a sample attribute) it doesn't just jump forward anymore. It will instead insert a period of silence, so the clock will progress at the playback rate until the next PTS, and at that point it'll start playing the next sample. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101769

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) April 23, 2025

April 23, 2025

> Just so I understand, SAR clock jumps to pts + \<time it actually took to play this sample/time it would take according to sample rate\> or it jumps blindly to pts + mf sample duration, ignoring actual playback time? I don't know how well sample duration is validated against actual buffer sizes. It will jump to PTS and then progress from there at the playback rate. I don't think it uses the duration value, just buffer size to determine duration (which is easy to calculate based on frame size and sample rate). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101767

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) April 23, 2025

April 23, 2025

> Is this an artifact of your tracing or OnClockRestart() is actually never used? It was calling `OnClockStart`, but it turns out that was because I had hard-coded the value in my `MESourceStarted` and `MEStreamStarted` events. After changing these events to instead use `pvarStartPosition` passed in `IMFMediaSource::Start`, I get: ``` 1330.024952|10088|source_mock_Start: format: {00000000-0000-0000-0000-000000000000} (GUID_NULL) position: <EMPTY> 1330.025598|10088|clock_sink_OnClockRestart: system time 13300255028 ``` So sending those events with a hard-coded `VT_I8` value of zero caused `OnClockStart` to be called, but now those events have a value of `VT_EMPTY` and `OnClockRestart` is called. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101766

1 0

[PATCH 0/1] MR7888: wbemprox: Implement Win32_CacheMemory table.
by Paul Gofman (＠gofman) April 23, 2025

April 23, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7888

2 3

Re: [PATCH v2 0/1] MR7887: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) April 23, 2025

April 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7887

1 0

Re: [PATCH v2 0/4] MR7882: msvcr: Link to msvcr{80,90}. - approved
by Alexandre Julliard (＠julliard) April 23, 2025

April 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7882

1 0

Re: [PATCH v2 0/1] MR7886: msvcrt: Fix memory leaks in create_locinfo. - approved
by Alexandre Julliard (＠julliard) April 23, 2025

April 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7886

1 0

Re: [PATCH v4 0/1] MR7829: d3d9/tests: Skip some d3d12 tests instead of crashing. - approved
by Alexandre Julliard (＠julliard) April 23, 2025

April 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7829

1 0

Re: [PATCH v2 0/1] MR7834: d3d11/tests: Add broken to test_nv12. - approved
by Alexandre Julliard (＠julliard) April 23, 2025

April 23, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7834

1 0