April 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon April 15, 2025

April 15, 2025

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/unixlib.h: > WG_SAMPLE_FLAG_HAS_DURATION = 4, > WG_SAMPLE_FLAG_SYNC_POINT = 8, > WG_SAMPLE_FLAG_DISCONTINUITY = 0x10, > + WG_SAMPLE_FLAG_HAS_DTS = 0x20, > + WG_SAMPLE_FLAG_WG_TIMESTAMP = 0x40, > }; > > struct wg_sample > { > /* timestamp and duration are in 100-nanosecond units. */ > - UINT64 pts; > - UINT64 duration; > + INT64 pts; > + INT64 duration; > + INT64 dts; How useful are DTS? Do we really need to pass them through? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100982

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon April 15, 2025

April 15, 2025

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c: > buffer_add_video_meta(buffer, &video_info); > } > > + /* we perform DTS first as it should never be later than PTS, so any required timestamp offset should be the maximum here */ > + if (sample->flags & WG_SAMPLE_FLAG_HAS_DTS) > + { > + dts = sample->dts += transform->ts_offset; > + if (dts < 0) > + { > + transform->ts_offset -= dts; Updating the offset continuously feels weird, though I've only skimmed over the code for now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100983

1 0

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Rémi Bernon April 15, 2025

April 15, 2025

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/gst_guids.h: > DEFINE_GUID(CLSID_decodebin_parser, 0xf9d8d64e, 0xa144, 0x47dc, 0x8e, 0xe0, 0xf5, 0x34, 0x98, 0x37, 0x2c, 0x29); > DEFINE_GUID(CLSID_mpeg_layer3_decoder, 0x38be3000, 0xdbf4, 0x11d0, 0x86, 0x0e, 0x00, 0xa0, 0x24, 0xcf, 0xef, 0x6d); > DEFINE_GUID(WINESUBTYPE_Gstreamer, 0xffffffff, 0x128f, 0x4dd1, 0xad, 0x22, 0xbe, 0xcf, 0xa6, 0x6c, 0xe7, 0xaa); > +DEFINE_GUID(MFSampleExtension_WG_Timestamp, 0x42554ce2, 0xed8c, 0x43ee, 0x8a, 0x04, 0xd6, 0xa1, 0x68, 0xf1, 0x8f, 0xee); Do we really need this custom GUID? Can't the fixups be confined on the unix side only? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_100981

1 0

Re: [PATCH v5 0/1] MR7706: powrprof.dll: Partially implement PowerGetActiveScheme for SteamVR
by Robert Lippmann (＠rlippmann) April 15, 2025

April 15, 2025

It is defined in winnt.h as GUID_MIN_POWER_SAVINGS. Unfortunately, if I put those DEFINE_GUID statements into winnt.h, it breaks compilation of other modules. ``` // // ========================================= // Define GUIDs which represent well-known power schemes // ========================================= // // // Maximum Power Savings - indicates that very aggressive power savings measures will be used to help // stretch battery life. // // {a1841308-3541-4fab-bc81-f71556f20b4a} // DEFINE_GUID( GUID_MAX_POWER_SAVINGS, 0xA1841308, 0x3541, 0x4FAB, 0xBC, 0x81, 0xF7, 0x15, 0x56, 0xF2, 0x0B, 0x4A ); // // No Power Savings - indicates that almost no power savings measures will be used. // // {8c5e7fda-e8bf-4a96-9a85-a6e23a8c635c} // DEFINE_GUID( GUID_MIN_POWER_SAVINGS, 0x8C5E7FDA, 0xE8BF, 0x4A96, 0x9A, 0x85, 0xA6, 0xE2, 0x3A, 0x8C, 0x63, 0x5C ); // // Typical Power Savings - indicates that fairly aggressive power savings measures will be used. // // {381b4222-f694-41f0-9685-ff5bb260df2e} // DEFINE_GUID( GUID_TYPICAL_POWER_SAVINGS, 0x381B4222, 0xF694, 0x41F0, 0x96, 0x85, 0xFF, 0x5B, 0xB2, 0x60, 0xDF, 0x2E ); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7706#note_100980

1 0

Re: [PATCH v3 0/6] MR7775: shell32: Test and rework rename operation. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7775

1 0

Re: [PATCH v6 0/8] MR7758: win32u: Introduce a generic pbuffer implementation. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7758

1 0

Re: [PATCH v2 0/1] MR7830: dbghelp/tests: Remove now succeeding todo_wine. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7830

1 0

Re: [PATCH v2 0/1] MR7832: advapi32/tests: Avoid crash in test_LsaLookupNames2 by setting len to zero. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7832

1 0

Re: [PATCH v2 0/1] MR7828: setupapi/tests: Add broken to test_SetupDiOpenDeviceInterface. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7828

1 0

Re: [PATCH v2 0/1] MR7821: winhttp/tests: Add broken to test_redirect. - approved
by Alexandre Julliard (＠julliard) April 15, 2025

April 15, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7821

1 0