April 2025 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR7742: Cmd engine rewrite (part XXIX)
by eric pouech (＠epo) April 4, 2025

April 4, 2025

This is part XXIX of the rewrite of cmd engine. It's time to tackle the lexer... So far, I left it mainly untouched. As it's a &#:!\_%% piece of code. It maintains (or actually tries to maintain) a state machine with a dozen of boolean variables. Which makes the code quickly unreadable... Not speaking of changing it... [ Exercice for the reader: think of the boolean variables as a set of ] [ binary digits, which is the base two representation of the state number. ] [ Rewrite the code using a single state number in order to get rid of ] [ all the boolean variables. ] [ -- Good luck. -- ] There's a small amount of known bugs in the lexer (some in bugzilla, some I got from direct reports -- thanks Hans --, others from local testings). This is the first MR (out of 3) to go for that lexer rewrite. Basically, it's done with: - reusing the already parsed token stack to get back to the state for lexer, - reducing leaves directly (tokens for which we can from first character(s) work on end condition) instead of handling every character in the state machine, - factorizing (eg end of line was handled at two different places, needless to say there "slight" differences in the two parts). The good news: LoC for lexer (after third MR) is reduced by 30% and fixes most of bugzilla entries related to cmd's lexer. The bad news: wait for bug reports. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7742

2 5

[PATCH 0/1] MR7710: d3d10/effect: Fix constant buffer overrun when updating expression constants (ASan).
by Nikolay Sivov (＠nsivov) April 4, 2025

April 4, 2025

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7710

3 4

[PATCH 0/1] MR7703: d2d1: Add [loop] attribute in sample_gradient() shader function.
by Francisco Casas (＠fcasas) April 4, 2025

April 4, 2025

Skips loop unrolling when compiling the shader, which lowers compilation time from ~80ms to ~40ms on my machine, which might preempt stutters for applications that call d2d_device_context_init() many times. This can help [CW bug 25000](https://www.codeweavers.com/support/bugs/browse/?cmd=bug_edit;bug_id…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7703

4 5

[PATCH 0/1] MR7604: kerberos: Accept NULL password, libkrb5 uses cached credentials in that case.
by Dmitry Timoshkov (＠dmitry) April 4, 2025

April 4, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7604

3 6

[PATCH 0/5] MR7739: winex11: Remove some pbuffer related dead code.
by Rémi Bernon April 4, 2025

April 4, 2025

Various pbuffer struct members aren't used, use_render_texture_emulation is always TRUE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7739

2 6

[PATCH 0/1] MR7738: cryptui: Copy localized name of selected store to textbox.
by Alex Henrie (＠alexhenrie) April 4, 2025

April 4, 2025

Match the behavior on Windows: When the CryptUIWizImport function is called, the "Certificate store" textbox initially says "Determined by the program" instead of having the specific name of the store passed to the function. When the user clicks Browse to select a store, the stores are listed by localized name. After clicking OK, the selected store's localized name is copied into the textbox. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58057 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7738

2 1

Re: [PATCH v3 0/3] MR7737: mshtml/jscript: Regression + leak fixes. - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7737

1 0

Re: [PATCH v2 0/1] MR7556: wmp: Check the return value of IOleClientSite_QueryInterface(). - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7556

1 0

Re: [PATCH v2 0/6] MR7686: winebth.sys part 8: Add support for replying to authentication/pairing requests. - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7686

1 0

Re: [PATCH v7 0/5] MR7727: cfgmgr32, setupapi: Implement a few functions. - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7727

1 0