April 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/2] MR7656: wined3d: Two unrelated fixes. - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7656

1 0

Re: [PATCH v3 0/6] MR7561: wined3d: Vulkan H.264 decode, part 3/3. - approved
by Alexandre Julliard (＠julliard) April 3, 2025

April 3, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7561

1 0

[PATCH v5 0/6] MR7708: Fix Imperiums: Greek Wars (1183470) not covering the entire screen in fullscreen mode.
by Zhiyi Zhang (＠zhiyi) April 3, 2025

April 3, 2025

-- v5: win32u: Properly scale monitor work area when emulate_modeset is enabled. https://gitlab.winehq.org/wine/wine/-/merge_requests/7708

4 8

[PATCH v2 0/3] MR7737: mshtml/jscript: Regression + leak fixes.
by Gabriel Ivăncescu April 3, 2025

April 3, 2025

For some reason I thought it wasn't needed anymore (I had it initially), sorry for the mess up. -- v2: jscript: Don't leak when return value of host constructor is not used. jscript: Don't leak when popping (u)int values off the stack. mshtml: Don't mess with the outer window if we're already detached. https://gitlab.winehq.org/wine/wine/-/merge_requests/7737

2 4

[PATCH 0/1] MR7556: wmp: Check the return value of IOleClientSite_QueryInterface().
by Yongjie Yao (＠yaoyongjie) April 3, 2025

April 3, 2025

It should be assigned to hres before checking hres as "if (FAILED(hres)) xxx". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7556

3 2

[PATCH 0/6] MR7686: winebth.sys part 8: Add support for replying to authentication/pairing requests.
by Vibhav Pant (＠vibhavp) April 3, 2025

April 3, 2025

Implement `BluetoothSendAuthenticationResponseEx` over the `IOCTL_WINEBTH_RADIO_SEND_AUTH_RESPONSE` command in winebth.sys. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7686

3 7

[PATCH v6 0/5] MR7727: cfgmgr32, setupapi: Implement a few functions.
by Paul Gofman (＠gofman) April 3, 2025

April 3, 2025

-- v6: cfgmgr32: Implement CM_Get_Device_Interface_PropertyW() for DEVPKEY_Device_InstanceId. cfgmgr32: Implement CM_Get_Device_Interface_List[_Size][_Ex]A(). cfgmgr32: Implement CM_Get_Device_Interface_List[_Size][_Ex]W(). setupapi/tests: Add a test for SetupDiOpenDeviceInterface(). setupapi: Implement SetupDiOpenDeviceInterface(A|W). https://gitlab.winehq.org/wine/wine/-/merge_requests/7727

4 7

[PATCH 0/3] MR7737: mshtml/jscript: Regression + leak fixes.
by Gabriel Ivăncescu April 3, 2025

April 3, 2025

For some reason I thought it wasn't needed anymore (I had it initially), sorry for the mess up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7737

2 5

[PATCH v2 0/1] MR7701: winemac.drv: Only send key down events to the window's inputContext.
by Tim Clem (＠tclem) April 3, 2025

April 3, 2025

Sending key events through `-[NSTextInputContext handleEvent:]`, as we do in `macdrv_send_text_input_event`, results in doubled characters for certain macOS input sources. The Romaji source does this reliably, as do certain third-party sources. (The built-in dictation does it as well, but we already blacklist that - !5660 - because it remains "active" even when it's not.) I can't find this spelled out directly, but if you read between the lines, it seems clear that you're only supposed to send key *down* events to `-[NSTextInputContext handleEvent:]` and not key ups. Supporting evidence: 1. [The old documentation on the text system](https://developer.apple.com/library/archive/documentation/TextFonts… only mentions `handleEvent:` being called in the context of `-keyDown:`. 2. [The guide to implementing a custom text view/NSTextInputClient](https://developer.apple.com/library/archive/documen… only mentions overriding `-keyDown:` and sending those events to `-handleEvent:`. 3. [iTerm only sends key down events to `-handleEvent:`](https://github.com/gnachman/iTerm2/blob/6134ea0a9d9d0fee5e7d7704fc98efec1fc77c24/sources/iTermKeyboardHandler.m#L355). You have to unpack the logic a bit from there, but `-handleKeyDownEvent:...` is the only method that calls `-handleEventWithCocoa:inputContext:`, which is what (usually) calls `-handleEvent:` on the `inputContext`. 4. [The InputMethodKit method on the IMKServerInput protocol to handle NSEvents directly](https://developer.apple.com/documentation/objectivec/nsobject/138… only mentions getting key down events. So presumably input source authors sometimes do not check the type of the NSEvent they're receiving and process all key events equally, be they downs or ups, which results in the doubled input. This patch fixes the issues with Romaji and the problematic third-party method we've encountered. -- v2: winemac.drv: Only send key down events to the window's inputContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/7701

3 5

[PATCH v5 0/5] MR7727: cfgmgr32, setupapi: Implement a few functions.
by Paul Gofman (＠gofman) April 3, 2025

April 3, 2025

-- v5: cfgmgr32: Implement CM_Get_Device_Interface_PropertyW() for DEVPKEY_Device_InstanceId. cfgmgr32: Implement CM_Get_Device_Interface_List[_Size][_Ex]A(). cfgmgr32: Implement CM_Get_Device_Interface_List[_Size][_Ex]W(). setupapi/tests: Add a test for SetupDiOpenDeviceInterface(). setupapi: Implement SetupDiOpenDeviceInterface(A|W). https://gitlab.winehq.org/wine/wine/-/merge_requests/7727

4 8