June 2025 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/2] MR8360: include: Don't evaluate format arguments to ok() unless we need them.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

On Thu Jun 19 02:07:03 2025 +0000, Yuxuan Shui wrote: > And for some reason build-linux doesn't want to pick up my new commit... > Let me try force pushing it again. ?? build-linux just ignores the tip of this branch, does it not like me bad mouthing the compiler? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8360#note_107160

1 0

[PATCH v2 0/2] MR8360: include: Don't evaluate format arguments to ok() unless we need them.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

Across the codebase there are several test cases where the arguments to ok() is not safe to evaluate unless the test case fails. For example: ok(i == ARRAY_SIZE(array), "i is too small: %d\n", array[i]); Only when the test fails (i.e. i < ARRAY_SIZE(array)), is array[i] safe to evaluate. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58320 * * * The other option is to fix all such cases in the test suite, and add some documentation to make it clear arguments to `ok()` are _always_ evaluated. I don't know which one is better. -- v2: include: Shut the compiler up about PDNS_RECORD array bounds. https://gitlab.winehq.org/wine/wine/-/merge_requests/8360

2 3

[PATCH 0/1] MR8360: include: Don't evaluate format arguments to ok() unless we need them.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

Across the codebase there are several test cases where the arguments to ok() is not safe to evaluate unless the test case fails. For example: ok(i == ARRAY_SIZE(array), "i is too small: %d\n", array[i]); Only when the test fails (i.e. i < ARRAY_SIZE(array)), is array[i] safe to evaluate. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58320 * * * The other option is to fix all such cases in the test suite, and add some documentation to make it clear arguments to `ok()` are _always_ evaluated. I don't know which one is better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8360

2 3

[PATCH 0/1] MR8366: user32: Reserve more space in kernel_callback_table[].
by Paul Gofman (＠gofman) June 18, 2025

June 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8366

2 2

[PATCH 0/2] MR8365: mmdevapi: Round min_period_frames.
by Paul Gofman (＠gofman) June 18, 2025

June 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8365

2 3

[PATCH 0/6] MR8364: quartz/avidec: Handle dynamic format change.
by Elizabeth Figura (＠zfigura) June 18, 2025

June 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8364

2 6

Re: [PATCH v3 0/5] MR8340: widl: Add rows for propget methods. - approved
by Alexandre Julliard (＠julliard) June 18, 2025

June 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8340

1 0

Re: [PATCH v4 0/2] MR8346: wininet: Fix 2 out-of-bound problems in url cache hash calculation - approved
by Alexandre Julliard (＠julliard) June 18, 2025

June 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8346

1 0

Re: [PATCH v2 0/1] MR8312: rpcrt4/tests: Fix out-of-bound write in test_pointer_marshal. - approved
by Alexandre Julliard (＠julliard) June 18, 2025

June 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8312

1 0

Re: [PATCH v2 0/1] MR8343: usp10/tests: Avoid out-of-bound use of glyphItems when nGlyphs mismatches. - approved
by Alexandre Julliard (＠julliard) June 18, 2025

June 18, 2025

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8343

1 0