June 2025 - Wine-GitLab - list.winehq.org

[PATCH v10 0/6] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon June 18, 2025

June 18, 2025

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v10: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. server: Move signal access checks outside of the objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

1 7

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Zhiyi Zhang (＠zhiyi) June 18, 2025

June 18, 2025

On Wed Jun 18 15:09:09 2025 +0000, Nikolay Sivov wrote: > Should we check anything here? For example ActiveFrame could be null or > it could be that ActiveFrame != &frame_extended->Frame. Both of these cases lead to crashes on Windows. So I guess it's just unsafe, as the function name states. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107066

1 0

[PATCH v2 0/2] MR8346: wininet: Fix 2 out-of-bound problems in url cache hash calculation
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

-- v2: wininet: Use BYTE instead of char for hash calculation. https://gitlab.winehq.org/wine/wine/-/merge_requests/8346

2 2

[PATCH 0/2] MR8346: wininet: Fix 2 out-of-bound problems in url cache hash calculation
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8346

3 3

[PATCH v2 0/1] MR8352: xcopy: Fix out-of-bound access when parsing arguments.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

We didn't check if the argument string is long enough before indexing into it. -- v2: xcopy: Fix out-of-bound access when parsing arguments. https://gitlab.winehq.org/wine/wine/-/merge_requests/8352

3 2

[PATCH 0/1] MR8352: xcopy: Fix out-of-bound access when parsing arguments.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

We didn't check if the argument string is long enough before indexing into it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8352

4 7

[PATCH 0/1] MR8361: shell32/tests: Fix expected ret for moving file to empty destination.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

Related to 57817044b983683f115edea6c5068ed6cddd858b. I believe originally the missing double null terminator caused Windows to take garbage memory as file name resulted in the ERROR_FILE_NOT_FOUND. Now it's fixed we are seeing what Windows actually returns. !8316 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8361

2 1

[PATCH v2 0/1] MR8350: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam.
by Yuxuan Shui (＠yshui) June 18, 2025

June 18, 2025

* * * While investigating another problem, I found we are handling empty attributes list differently compared native. But the actual problem is this, shouldn't `CRYPT_SizeOfAttributes` add `sizeof(CRYPT_ATTRIBUTES)` to `size`? Basically we return `size == 0` when the attributes list is empty, so the caller allocates zero bytes and call `GetParam` again, and we write out-of-bound trying to `out->cAttrs = in->cAttrs` in `CRYPT_ConstructAttributes`. (Of course with this MR this problem no longer show up, but the question still stands.) -- v2: crypt32: Handle missing attributes in CDecodeSignedMsg_GetParam. https://gitlab.winehq.org/wine/wine/-/merge_requests/8350

2 1

[PATCH v11 0/6] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Yongjie Yao (＠yaoyongjie) June 18, 2025

June 18, 2025

In CopyFileEx, and DeleteFile functions, by default, the file name and path are limited to MAX_PATH characters. To extend this limit to 32,767 wide characters, need prepend "\\\\?\\" to the path. -- v11: kernelbase: Limit the maximum path length for DeleteFile. kernelbase: Fix DeleteFileA doesn't support long path. kernelbase: Limit the maximum path length for filesystem. ntdll: Check if long path aware is enabled. kernel32/tests: Add tests for DeleteFile kernel32/tests: Add tests for maximum path length limitation. https://gitlab.winehq.org/wine/wine/-/merge_requests/7540

2 6

Re: [PATCH v4 0/6] MR8326: ntdll: Implement RtlActivateActivationContextUnsafeFast().
by Nikolay Sivov (＠nsivov) June 18, 2025

June 18, 2025

Nikolay Sivov (@nsivov) commented about dlls/ntdll/actctx.c: > +/****************************************************************** > + * RtlDeactivateActivationContextUnsafeFast (NTDLL.@) > + * > + * FIXME: function prototype might be wrong > + */ > +VOID FASTCALL RtlDeactivateActivationContextUnsafeFast( RTL_CALLER_ALLOCATED_ACTIVATION_CONTEXT_STACK_FRAME_EXTENDED *frame_extended ) > +{ > + ACTIVATION_CONTEXT_STACK *actctx_stack = NtCurrentTeb()->ActivationContextStackPointer; > + ACTIVATION_CONTEXT *actctx; > + > + TRACE( "%p\n", frame_extended ); > + > + actctx = actctx_stack->ActiveFrame->ActivationContext; > + actctx_stack->ActiveFrame = frame_extended->Frame.Previous; > + RtlReleaseActivationContext( actctx ); > +} Should we check anything here? For example ActiveFrame could be null or it could be that ActiveFrame != &frame_extended->Frame. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8326#note_107024

1 0